add more checks on creation and modification interface (#2722)

EtienneLt · EtienneLt · commit 6b946e82b957 · 2025-04-14T15:13:23.000+02:00
Signed-off-by: Etienne LESOT &lt;etienne.lesot@rte-france.com&gt;
diff --git a/src/components/dialogs/active-power-control/active-power-control-utils.ts b/src/components/dialogs/active-power-control/active-power-control-utils.ts
@@ -24,6 +24,8 @@ export const getActivePowerControlSchema = (isEquipmentModification = false) =>
     [DROOP]: yup
         .number()
         .nullable()
+        .min(0, 'NormalizedPercentage')
+        .max(100, 'NormalizedPercentage')
         .when([FREQUENCY_REGULATION], {
             is: (frequencyRegulation: boolean) => !isEquipmentModification && frequencyRegulation,
             then: (schema) => schema.required(),
diff --git a/src/components/dialogs/network-modifications/generator/creation/generator-creation-dialog.tsx b/src/components/dialogs/network-modifications/generator/creation/generator-creation-dialog.tsx
@@ -114,7 +114,7 @@ const formSchema = yup
         [ENERGY_SOURCE]: yup.string().nullable().required(),
         [MAXIMUM_ACTIVE_POWER]: yup.number().nullable().required(),
         [MINIMUM_ACTIVE_POWER]: yup.number().nullable().required(),
-        [RATED_NOMINAL_POWER]: yup.number().nullable(),
+        [RATED_NOMINAL_POWER]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero'),
         [TRANSFORMER_REACTANCE]: yup.number().nullable(),
         [TRANSIENT_REACTANCE]: yup
             .number()
diff --git a/src/components/dialogs/network-modifications/generator/modification/generator-modification-dialog.tsx b/src/components/dialogs/network-modifications/generator/modification/generator-modification-dialog.tsx
@@ -130,7 +130,7 @@ const formSchema = yup
                 then: (schema) =>
                     schema.max(yup.ref(MAXIMUM_ACTIVE_POWER), 'MinActivePowerMustBeLessOrEqualToMaxActivePower'),
             }),
-        [RATED_NOMINAL_POWER]: yup.number().nullable(),
+        [RATED_NOMINAL_POWER]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero'),
         [TRANSIENT_REACTANCE]: yup.number().nullable(),
         [TRANSFORMER_REACTANCE]: yup.number().nullable(),
         [PLANNED_ACTIVE_POWER_SET_POINT]: yup.number().nullable(),
diff --git a/src/components/dialogs/network-modifications/hvdc-line/vsc/converter-station/converter-station-utils.tsx b/src/components/dialogs/network-modifications/hvdc-line/vsc/converter-station/converter-station-utils.tsx
@@ -125,10 +125,10 @@ export function getVscConverterStationModificationSchema(id: string) {
         [id]: yup.object().shape({
             [CONVERTER_STATION_ID]: yup.string(),
             [CONVERTER_STATION_NAME]: yup.string().nullable(),
-            [LOSS_FACTOR]: yup.number().nullable(),
+            [LOSS_FACTOR]: yup.number().nullable().min(0, 'NormalizedPercentage').max(100, 'NormalizedPercentage'),
             [VOLTAGE_REGULATION_ON]: yup.boolean().nullable(),
             [REACTIVE_POWER]: yup.number().nullable(),
-            [VOLTAGE]: yup.number().nullable(),
+            [VOLTAGE]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero'),
             ...getReactiveLimitsSchema(true),
         }),
     };
diff --git a/src/components/dialogs/network-modifications/hvdc-line/vsc/hvdc-line-pane/vsc-hvdc-line-pane-utils.tsx b/src/components/dialogs/network-modifications/hvdc-line/vsc/hvdc-line-pane/vsc-hvdc-line-pane-utils.tsx
@@ -23,8 +23,8 @@ export function getVscHvdcLinePaneSchema(id: string) {
     return {
         [id]: yup.object().shape(
             {
-                [NOMINAL_V]: yup.number().nullable().required(),
-                [R]: yup.number().nullable().required(),
+                [NOMINAL_V]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero').required(),
+                [R]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero').required(),
                 [MAX_P]: yup.number().nullable().required(),
                 [OPERATOR_ACTIVE_POWER_LIMIT_SIDE1]: yup.number().nullable(),
                 [OPERATOR_ACTIVE_POWER_LIMIT_SIDE2]: yup.number().nullable(),
@@ -57,8 +57,8 @@ export function getVscHvdcLineModificationPaneSchema(id: string) {
     return {
         [id]: yup.object().shape(
             {
-                [NOMINAL_V]: yup.number().nullable(),
-                [R]: yup.number().nullable(),
+                [NOMINAL_V]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero'),
+                [R]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero'),
                 [MAX_P]: yup.number().nullable(),
                 [OPERATOR_ACTIVE_POWER_LIMIT_SIDE1]: yup.number().nullable(),
                 [OPERATOR_ACTIVE_POWER_LIMIT_SIDE2]: yup.number().nullable(),
diff --git a/src/components/dialogs/network-modifications/line/characteristics-pane/line-characteristics-pane-utils.js b/src/components/dialogs/network-modifications/line/characteristics-pane/line-characteristics-pane-utils.js
@@ -24,12 +24,14 @@ import {
 
 const characteristicsValidationSchema = (id, displayConnectivity, modification) => ({
     [id]: yup.object().shape({
-        [R]: modification ? yup.number().nullable() : yup.number().nullable().required(),
+        [R]: modification
+            ? yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero')
+            : yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero').required(),
         [X]: modification ? yup.number().nullable() : yup.number().nullable().required(),
         [B1]: yup.number().nullable(),
-        [G1]: yup.number().nullable(),
+        [G1]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero'),
         [B2]: yup.number().nullable(),
-        [G2]: yup.number().nullable(),
+        [G2]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero'),
         ...(displayConnectivity && getConnectivityWithPositionValidationSchema(false, CONNECTIVITY_1)),
         ...(displayConnectivity && getConnectivityWithPositionValidationSchema(false, CONNECTIVITY_2)),
     }),
diff --git a/src/components/dialogs/network-modifications/static-var-compensator/creation/set-points-limits-form-utils.ts b/src/components/dialogs/network-modifications/static-var-compensator/creation/set-points-limits-form-utils.ts
@@ -74,6 +74,7 @@ export const getReactiveFormValidationSchema = () =>
         [VOLTAGE_SET_POINT]: yup
             .number()
             .nullable()
+            .min(0, 'mustBeGreaterOrEqualToZero')
             .when([VOLTAGE_REGULATION_MODE], {
                 is: (voltageRegulationMode: string) => voltageRegulationMode === VOLTAGE_REGULATION_MODES.VOLTAGE.id,
                 then: (schema) => schema.required(),
diff --git a/src/components/dialogs/network-modifications/static-var-compensator/creation/standby-automaton-form-utils.ts b/src/components/dialogs/network-modifications/static-var-compensator/creation/standby-automaton-form-utils.ts
@@ -83,10 +83,10 @@ export const getStandbyAutomatonFormValidationSchema = () =>
                     addStandbyAutomaton && voltageRegulationMode === VOLTAGE_REGULATION_MODES.VOLTAGE.id,
                 then: (schema) => schema.required(),
             }),
-        [LOW_VOLTAGE_SET_POINT]: requiredIfAddStandbyAutomaton(yup.number()),
-        [HIGH_VOLTAGE_SET_POINT]: requiredIfAddStandbyAutomaton(yup.number()),
-        [LOW_VOLTAGE_THRESHOLD]: requiredIfAddStandbyAutomaton(yup.number()),
-        [HIGH_VOLTAGE_THRESHOLD]: requiredIfAddStandbyAutomaton(yup.number()),
+        [LOW_VOLTAGE_SET_POINT]: requiredIfAddStandbyAutomaton(yup.number().min(0, 'mustBeGreaterOrEqualToZero')),
+        [HIGH_VOLTAGE_SET_POINT]: requiredIfAddStandbyAutomaton(yup.number().min(0, 'mustBeGreaterOrEqualToZero')),
+        [LOW_VOLTAGE_THRESHOLD]: requiredIfAddStandbyAutomaton(yup.number().min(0, 'mustBeGreaterOrEqualToZero')),
+        [HIGH_VOLTAGE_THRESHOLD]: requiredIfAddStandbyAutomaton(yup.number().min(0, 'mustBeGreaterOrEqualToZero')),
         [B0]: requiredWhenSusceptanceChoice(yup.number().nullable()),
         [Q0]: requiredWhenQatNominalVChoice(yup.number().nullable()),
     });
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane-utils.js b/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane-utils.js
@@ -10,13 +10,21 @@ import yup from 'components/utils/yup-config';
 
 const characteristicsValidationSchema = (isModification, additionalFields) => ({
     [CHARACTERISTICS]: yup.object().shape({
-        [R]: isModification ? yup.number().nullable() : yup.number().nullable().required(),
+        [R]: isModification
+            ? yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero')
+            : yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero').required(),
         [X]: isModification ? yup.number().nullable() : yup.number().nullable().required(),
-        [G]: isModification ? yup.number().nullable() : yup.number().nullable().required(),
+        [G]: isModification
+            ? yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero')
+            : yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero').required(),
         [B]: isModification ? yup.number().nullable() : yup.number().nullable().required(),
         [RATED_S]: yup.number().nullable().positive('RatedNominalPowerMustBeGreaterThanZero'),
-        [RATED_U1]: isModification ? yup.number().nullable() : yup.number().nullable().required(),
-        [RATED_U2]: isModification ? yup.number().nullable() : yup.number().nullable().required(),
+        [RATED_U1]: isModification
+            ? yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero')
+            : yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero').required(),
+        [RATED_U2]: isModification
+            ? yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero')
+            : yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero').required(),
         ...additionalFields,
     }),
 });
diff --git a/src/components/dialogs/network-modifications/voltage-level/creation/voltage-level-creation-dialog.jsx b/src/components/dialogs/network-modifications/voltage-level/creation/voltage-level-creation-dialog.jsx
@@ -121,9 +121,9 @@ const formSchema = yup
         [SUBSTATION_NAME]: yup.string().nullable(),
         [COUNTRY]: yup.string().nullable(),
         [SUBSTATION_CREATION]: creationPropertiesSchema,
-        [NOMINAL_V]: yup.number().nullable().required(),
-        [LOW_VOLTAGE_LIMIT]: yup.number().nullable(),
-        [HIGH_VOLTAGE_LIMIT]: yup.number().nullable(),
+        [NOMINAL_V]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero').required(),
+        [LOW_VOLTAGE_LIMIT]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero'),
+        [HIGH_VOLTAGE_LIMIT]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero'),
         [LOW_SHORT_CIRCUIT_CURRENT_LIMIT]: yup
             .number()
             .nullable()
diff --git a/src/components/dialogs/network-modifications/voltage-level/modification/voltage-level-modification-dialog.jsx b/src/components/dialogs/network-modifications/voltage-level/modification/voltage-level-modification-dialog.jsx
@@ -60,9 +60,9 @@ const formSchema = yup
     .shape({
         [EQUIPMENT_NAME]: yup.string().nullable(),
         [SUBSTATION_ID]: yup.string().nullable(),
-        [NOMINAL_V]: yup.number().nullable(),
-        [LOW_VOLTAGE_LIMIT]: yup.number().nullable(),
-        [HIGH_VOLTAGE_LIMIT]: yup.number().nullable(),
+        [NOMINAL_V]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero'),
+        [LOW_VOLTAGE_LIMIT]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero'),
+        [HIGH_VOLTAGE_LIMIT]: yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero'),
         [LOW_SHORT_CIRCUIT_CURRENT_LIMIT]: yup
             .number()
             .nullable()
diff --git a/src/components/dialogs/voltage-regulation/voltage-regulation-utils.ts b/src/components/dialogs/voltage-regulation/voltage-regulation-utils.ts
@@ -44,6 +44,7 @@ export const getVoltageRegulationSchema = (isEquipmentModification = false) => (
     [VOLTAGE_SET_POINT]: yup
         .number()
         .nullable()
+        .min(0, 'mustBeGreaterOrEqualToZero')
         .when([VOLTAGE_REGULATION], {
             is: (value: string) => !isEquipmentModification && value,
             then: (schema) => schema.required(),
diff --git a/src/translations/en.json b/src/translations/en.json
@@ -1576,5 +1576,6 @@
     "qmin": "Min Q",
     "qmax": "Max Q",
     "nodeAliasesRetrievingError": "An error occured while retrieving node aliases",
-    "nodeAliasesUpdateError": "An error occured while updating node aliases"
+    "nodeAliasesUpdateError": "An error occured while updating node aliases",
+    "mustBeGreaterOrEqualToZero": "Must be greater than or equal to 0"
 }
diff --git a/src/translations/fr.json b/src/translations/fr.json
@@ -1572,5 +1572,6 @@
     "qmin": "Q Min",
     "qmax": "Q Max",
     "nodeAliasesRetrievingError": "Erreur lors de la récupération des alias de nœuds",
-    "nodeAliasesUpdateError": "Erreur lors de la mise à jour des alias de nœuds"
+    "nodeAliasesUpdateError": "Erreur lors de la mise à jour des alias de nœuds",
+    "mustBeGreaterOrEqualToZero": "Cette valeur doit être supérieure ou égale à 0"
 }
