refactor: Refactor integration tests to use assert and remove comments/logs

Author: yaacovCR

integrationTests/dev-bun/test.js

@@ -1,6 +1,6 @@
+import assert from 'assert';
 import { isObjectType } from 'graphql';
 
-// Create a fake GraphQLObjectType to test instanceof behavior
 class FakeGraphQLObjectType {
   constructor() {
     this.name = 'Fake';
@@ -10,17 +10,11 @@ class FakeGraphQLObjectType {
 const fakeInstance = new FakeGraphQLObjectType();
 
 try {
-  const result = isObjectType(fakeInstance);
-  
-  // In development mode, this should throw an error about multiple GraphQL modules
-  // If we get here without an error, development mode is not working
-  console.error('✗ Development mode test failed - expected error was not thrown');
-  process.exit(1);
+  isObjectType(fakeInstance);
+  assert.fail('Expected isObjectType to throw an error in Bun development mode.');
 } catch (error) {
-  if (error.message.includes('multiple') || error.message.includes('GraphQL')) {
-    console.log('✓ Bun development mode integration test passed');
-  } else {
-    console.error('✗ Development mode test failed - unexpected error:', error.message);
-    process.exit(1);
-  }
+  assert.ok(
+    error.message.includes('multiple') || error.message.includes('GraphQL'),
+    `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`
+  );
 }

integrationTests/dev-deno/test.js

@@ -1,6 +1,6 @@
+import assert from 'assert';
 import { isObjectType } from 'graphql';
 
-// Create a fake GraphQLObjectType to test instanceof behavior
 class FakeGraphQLObjectType {
   constructor() {
     this.name = 'Fake';
@@ -10,17 +10,11 @@ class FakeGraphQLObjectType {
 const fakeInstance = new FakeGraphQLObjectType();
 
 try {
-  const result = isObjectType(fakeInstance);
-  
-  // In development mode, this should throw an error about multiple GraphQL modules
-  // If we get here without an error, development mode is not working
-  console.error('✗ Development mode test failed - expected error was not thrown');
-  process.exit(1);
+  isObjectType(fakeInstance);
+  assert.fail('Expected isObjectType to throw an error in Deno development mode.');
 } catch (error) {
-  if (error.message.includes('multiple') || error.message.includes('GraphQL')) {
-    console.log('✓ Deno development mode integration test passed');
-  } else {
-    console.error('✗ Development mode test failed - unexpected error:', error.message);
-    process.exit(1);
-  }
+  assert.ok(
+    error.message.includes('multiple') || error.message.includes('GraphQL'),
+    `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`
+  );
 }

integrationTests/dev-esbuild/src/index.js

@@ -1,6 +1,6 @@
+import assert from 'assert';
 import { isObjectType } from 'graphql';
 
-// Create a fake GraphQLObjectType to test instanceof behavior
 class FakeGraphQLObjectType {
   constructor() {
     this.name = 'Fake';
@@ -10,17 +10,11 @@ class FakeGraphQLObjectType {
 const fakeInstance = new FakeGraphQLObjectType();
 
 try {
-  const result = isObjectType(fakeInstance);
-  
-  // In development mode, this should throw an error about multiple GraphQL modules
-  // If we get here without an error, development mode is not working
-  console.error('✗ Development mode test failed - expected error was not thrown');
-  process.exit(1);
+  isObjectType(fakeInstance);
+  assert.fail('Expected isObjectType to throw an error in esbuild development mode.');
 } catch (error) {
-  if (error.message.includes('multiple') || error.message.includes('GraphQL')) {
-    console.log('✓ esbuild development mode integration test passed');
-  } else {
-    console.error('✗ Development mode test failed - unexpected error:', error.message);
-    process.exit(1);
-  }
+  assert.ok(
+    error.message.includes('multiple') || error.message.includes('GraphQL'),
+    `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`
+  );
 }

integrationTests/dev-nextjs/test.js

@@ -1,6 +1,6 @@
+import assert from 'assert';
 import { isObjectType } from 'graphql';
 
-// Create a fake GraphQLObjectType to test instanceof behavior
 class FakeGraphQLObjectType {
   constructor() {
     this.name = 'Fake';
@@ -10,17 +10,11 @@ class FakeGraphQLObjectType {
 const fakeInstance = new FakeGraphQLObjectType();
 
 try {
-  const result = isObjectType(fakeInstance);
-  
-  // In development mode, this should throw an error about multiple GraphQL modules
-  // If we get here without an error, development mode is not working
-  console.error('✗ Development mode test failed - expected error was not thrown');
-  process.exit(1);
+  isObjectType(fakeInstance);
+  assert.fail('Expected isObjectType to throw an error in Next.js development mode.');
 } catch (error) {
-  if (error.message.includes('multiple') || error.message.includes('GraphQL')) {
-    console.log('✓ Next.js development mode integration test passed');
-  } else {
-    console.error('✗ Development mode test failed - unexpected error:', error.message);
-    process.exit(1);
-  }
+  assert.ok(
+    error.message.includes('multiple') || error.message.includes('GraphQL'),
+    `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`
+  );
 }

integrationTests/dev-node-explicit/test.js

@@ -1,6 +1,6 @@
+import assert from 'assert';
 import { isObjectType } from 'graphql';
 
-// Create a fake GraphQLObjectType to test instanceof behavior
 class FakeGraphQLObjectType {
   constructor() {
     this.name = 'Fake';
@@ -10,17 +10,11 @@ class FakeGraphQLObjectType {
 const fakeInstance = new FakeGraphQLObjectType();
 
 try {
-  const result = isObjectType(fakeInstance);
-  
-  // In development mode, this should throw an error about multiple GraphQL modules
-  // If we get here without an error, development mode is not working
-  console.error('✗ Development mode test failed - expected error was not thrown');
-  process.exit(1);
+  isObjectType(fakeInstance);
+  assert.fail('Expected isObjectType to throw an error in Node.js explicit development mode.');
 } catch (error) {
-  if (error.message.includes('multiple') || error.message.includes('GraphQL')) {
-    console.log('✓ Node.js explicit development mode integration test passed');
-  } else {
-    console.error('✗ Development mode test failed - unexpected error:', error.message);
-    process.exit(1);
-  }
+  assert.ok(
+    error.message.includes('multiple') || error.message.includes('GraphQL'),
+    `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`
+  );
 }

integrationTests/dev-node-implicit/test.js

@@ -1,6 +1,6 @@
+import assert from 'assert';
 import { isObjectType } from 'graphql';
 
-// Create a fake GraphQLObjectType to test instanceof behavior
 class FakeGraphQLObjectType {
   constructor() {
     this.name = 'Fake';
@@ -10,17 +10,11 @@ class FakeGraphQLObjectType {
 const fakeInstance = new FakeGraphQLObjectType();
 
 try {
-  const result = isObjectType(fakeInstance);
-  
-  // In development mode, this should throw an error about multiple GraphQL modules
-  // If we get here without an error, development mode is not working
-  console.error('✗ Development mode test failed - expected error was not thrown');
-  process.exit(1);
+  isObjectType(fakeInstance);
+  assert.fail('Expected isObjectType to throw an error in Node.js implicit development mode.');
 } catch (error) {
-  if (error.message.includes('multiple') || error.message.includes('GraphQL')) {
-    console.log('✓ Node.js development mode integration test passed');
-  } else {
-    console.error('✗ Development mode test failed - unexpected error:', error.message);
-    process.exit(1);
-  }
+  assert.ok(
+    error.message.includes('multiple') || error.message.includes('GraphQL'),
+    `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`
+  );
 }

integrationTests/dev-rollup/src/index.js

@@ -1,6 +1,6 @@
+import assert from 'assert';
 import { isObjectType } from 'graphql';
 
-// Create a fake GraphQLObjectType to test instanceof behavior
 class FakeGraphQLObjectType {
   constructor() {
     this.name = 'Fake';
@@ -10,17 +10,11 @@ class FakeGraphQLObjectType {
 const fakeInstance = new FakeGraphQLObjectType();
 
 try {
-  const result = isObjectType(fakeInstance);
-  
-  // In development mode, this should throw an error about multiple GraphQL modules
-  // If we get here without an error, development mode is not working
-  console.error('✗ Development mode test failed - expected error was not thrown');
-  process.exit(1);
+  isObjectType(fakeInstance);
+  assert.fail('Expected isObjectType to throw an error in Rollup development mode.');
 } catch (error) {
-  if (error.message.includes('multiple') || error.message.includes('GraphQL')) {
-    console.log('✓ Rollup development mode integration test passed');
-  } else {
-    console.error('✗ Development mode test failed - unexpected error:', error.message);
-    process.exit(1);
-  }
+  assert.ok(
+    error.message.includes('multiple') || error.message.includes('GraphQL'),
+    `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`
+  );
 }

integrationTests/dev-swc/src/index.js

@@ -1,6 +1,6 @@
+import assert from 'assert';
 import { isObjectType } from 'graphql';
 
-// Create a fake GraphQLObjectType to test instanceof behavior
 class FakeGraphQLObjectType {
   constructor() {
     this.name = 'Fake';
@@ -10,17 +10,11 @@ class FakeGraphQLObjectType {
 const fakeInstance = new FakeGraphQLObjectType();
 
 try {
-  const result = isObjectType(fakeInstance);
-  
-  // In development mode, this should throw an error about multiple GraphQL modules
-  // If we get here without an error, development mode is not working
-  console.error('✗ Development mode test failed - expected error was not thrown');
-  process.exit(1);
+  isObjectType(fakeInstance);
+  assert.fail('Expected isObjectType to throw an error in SWC development mode.');
 } catch (error) {
-  if (error.message.includes('multiple') || error.message.includes('GraphQL')) {
-    console.log('✓ SWC development mode integration test passed');
-  } else {
-    console.error('✗ Development mode test failed - unexpected error:', error.message);
-    process.exit(1);
-  }
+  assert.ok(
+    error.message.includes('multiple') || error.message.includes('GraphQL'),
+    `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`
+  );
 }

integrationTests/dev-vite/src/index.js

@@ -1,6 +1,6 @@
+import assert from 'assert';
 import { isObjectType } from 'graphql';
 
-// Create a fake GraphQLObjectType to test instanceof behavior
 class FakeGraphQLObjectType {
   constructor() {
     this.name = 'Fake';
@@ -10,17 +10,11 @@ class FakeGraphQLObjectType {
 const fakeInstance = new FakeGraphQLObjectType();
 
 try {
-  const result = isObjectType(fakeInstance);
-  
-  // In development mode, this should throw an error about multiple GraphQL modules
-  // If we get here without an error, development mode is not working
-  console.error('✗ Development mode test failed - expected error was not thrown');
-  process.exit(1);
+  isObjectType(fakeInstance);
+  assert.fail('Expected isObjectType to throw an error in Vite development mode.');
 } catch (error) {
-  if (error.message.includes('multiple') || error.message.includes('GraphQL')) {
-    console.log('✓ Vite development mode integration test passed');
-  } else {
-    console.error('✗ Development mode test failed - unexpected error:', error.message);
-    process.exit(1);
-  }
+  assert.ok(
+    error.message.includes('multiple') || error.message.includes('GraphQL'),
+    `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`
+  );
 }

integrationTests/dev-webpack/src/index.js

@@ -1,6 +1,6 @@
+import assert from 'assert';
 import { isObjectType } from 'graphql';
 
-// Create a fake GraphQLObjectType to test instanceof behavior
 class FakeGraphQLObjectType {
   constructor() {
     this.name = 'Fake';
@@ -10,17 +10,11 @@ class FakeGraphQLObjectType {
 const fakeInstance = new FakeGraphQLObjectType();
 
 try {
-  const result = isObjectType(fakeInstance);
-  
-  // In development mode, this should throw an error about multiple GraphQL modules
-  // If we get here without an error, development mode is not working
-  console.error('✗ Development mode test failed - expected error was not thrown');
-  process.exit(1);
+  isObjectType(fakeInstance);
+  assert.fail('Expected isObjectType to throw an error in Webpack development mode.');
 } catch (error) {
-  if (error.message.includes('multiple') || error.message.includes('GraphQL')) {
-    console.log('✓ Webpack development mode integration test passed');
-  } else {
-    console.error('✗ Development mode test failed - unexpected error:', error.message);
-    process.exit(1);
-  }
+  assert.ok(
+    error.message.includes('multiple') || error.message.includes('GraphQL'),
+    `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`
+  );
 }

integrationTests/prod-bun/test.js

@@ -1,25 +1,12 @@
+import assert from 'assert';
 import { isObjectType } from 'graphql';
 
-// Create a fake GraphQLObjectType to test instanceof behavior
 class FakeGraphQLObjectType {
   constructor() {
     this.name = 'Fake';
   }
 }
 
 const fakeInstance = new FakeGraphQLObjectType();
-
-try {
-  const result = isObjectType(fakeInstance);
-  
-  // In production mode, this should return false without throwing
-  if (result === false) {
-    console.log('✓ Bun production mode integration test passed');
-  } else {
-    console.error('✗ Production mode test failed - expected false, got:', result);
-    process.exit(1);
-  }
-} catch (error) {
-  console.error('✗ Production mode test failed - unexpected error:', error.message);
-  process.exit(1);
-}
+const result = isObjectType(fakeInstance);
+assert.strictEqual(result, false, 'isObjectType should return false in Bun production mode.');

integrationTests/prod-deno/test.js

@@ -1,25 +1,12 @@
+import assert from 'assert';
 import { isObjectType } from 'graphql';
 
-// Create a fake GraphQLObjectType to test instanceof behavior
 class FakeGraphQLObjectType {
   constructor() {
     this.name = 'Fake';
   }
 }
 
 const fakeInstance = new FakeGraphQLObjectType();
-
-try {
-  const result = isObjectType(fakeInstance);
-  
-  // In production mode, this should return false without throwing
-  if (result === false) {
-    console.log('✓ Deno production mode integration test passed');
-  } else {
-    console.error('✗ Production mode test failed - expected false, got:', result);
-    process.exit(1);
-  }
-} catch (error) {
-  console.error('✗ Production mode test failed - unexpected error:', error.message);
-  process.exit(1);
-}
+const result = isObjectType(fakeInstance);
+assert.strictEqual(result, false, 'isObjectType should return false in Deno production mode.');