Closed
Description
Any reason that the return type of complete_list_value
is AwaitableOrValue[Any]
rather than AwaitableOrValue[List[Any]]
:
graphql-core/src/graphql/execution/execute.py
Lines 756 to 763 in c6f73a8
For comparison, execute_fields
returns AwaitableOrValue[Dict[str, Any]]
:
graphql-core/src/graphql/execution/execute.py
Lines 418 to 424 in c6f73a8
Metadata
Metadata
Assignees
Labels
No labels
Activity
Cito commentedon May 5, 2021
Thank you, good catch! I've fixed it already.
cancan101 commentedon May 5, 2021
@Cito I think you also want to update the return types of
get_completed_results
, etc (the inner / helper functions).Cito commentedon May 5, 2021
Yes, but only one of them needed to be changed (5bfc3a0). Anything else I overlooked?
cancan101 commentedon May 5, 2021
That looks good.