Skip to content

Improve parsing of module-info #175

Open
@TheGoesen

Description

@TheGoesen

Currently this plugin uses a simple line parser. This is currently sufficient for all relevant use cases, but technically incorrect.
It is allowed to have multiple require statements in a single line (but there probably arent many people on this world doing that)
However to consider #174 a more mature parser would be nice.
On paper I would think it would be a nice solution to use a thirdparty library like https://github.com/javaparser/javaparser to do the parsing and maybe only handle the custom runtimeOnly comment using some other code. But there is also to consider performance as gradle currently will have to reparse the module-info every single run until gradle does something about the following issue:

gradle/gradle#32393

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions