Skip to content

Commit b9bcd4e

Browse files
committed
Never attempt to create dependency for JDK core module
1 parent ec6708c commit b9bcd4e

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/main/java/org/gradlex/javamodule/dependencies/JavaModuleDependenciesExtension.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,10 @@ private String toProjectName(String moduleNameSuffix) {
212212
}
213213

214214
public Provider<Dependency> create(String moduleName, SourceSet sourceSetWithModuleInfo) {
215+
if (JDKInfo.MODULES.contains(moduleName)) {
216+
// The module is part of the JDK, no dependency required
217+
return getProviders().provider(() -> null);
218+
}
215219
if (getModuleInfoCache().get().isInitializedInSettings()) {
216220
return createPrecise(moduleName);
217221
} else {

src/main/java/org/gradlex/javamodule/dependencies/JavaModuleDependenciesPlugin.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,6 @@ private void readModuleInfo(ModuleInfo.Directive moduleDirective, SourceSet sour
277277
}
278278

279279
private void declareDependency(String moduleName, Project project, SourceSet sourceSet, Configuration configuration, JavaModuleDependenciesExtension javaModuleDependencies) {
280-
if (JDKInfo.MODULES.contains(moduleName)) {
281-
// The module is part of the JDK, no dependency required
282-
return;
283-
}
284-
285280
project.getDependencies().addProvider(configuration.getName(), javaModuleDependencies.create(moduleName, sourceSet));
286281
}
287282

0 commit comments

Comments
 (0)