Test pass but not encoder ended in encoder_open_state

Author: andyleiserson

src/webgpu/api/validation/encoding/encoder_open_state.spec.ts

@@ -291,15 +291,13 @@ g.test('render_pass_commands')
     `
     Test that functions of GPURenderPassEncoder generate a validation error if the encoder or the
     pass is already finished.
-
-    - TODO: Consider testing: nothing before command, end before command, end+finish before command.
   `
   )
   .params(u =>
     u
       .combine('command', kRenderPassEncoderCommands)
       .beginSubcases()
-      .combine('finishBeforeCommand', [false, true])
+      .combine('finishBeforeCommand', ['no', 'pass', 'encoder'])
   )
   .fn(t => {
     const { command, finishBeforeCommand } = t.params;
@@ -322,8 +320,10 @@ g.test('render_pass_commands')
 
     const bindGroup = t.createBindGroupForTest();
 
-    if (finishBeforeCommand) {
+    if (finishBeforeCommand !== 'no') {
       renderPass.end();
+    }
+    if (finishBeforeCommand === 'encoder') {
       encoder.finish();
     }
 
@@ -437,7 +437,7 @@ g.test('render_pass_commands')
         default:
           unreachable();
       }
-    }, finishBeforeCommand);
+    }, finishBeforeCommand !== 'no');
   });
 
 g.test('render_bundle_commands')
@@ -541,15 +541,13 @@ g.test('compute_pass_commands')
     `
     Test that functions of GPUComputePassEncoder generate a validation error if the encoder or the
     pass is already finished.
-
-    - TODO: Consider testing: nothing before command, end before command, end+finish before command.
   `
   )
   .params(u =>
     u
       .combine('command', kComputePassEncoderCommands)
       .beginSubcases()
-      .combine('finishBeforeCommand', [false, true])
+      .combine('finishBeforeCommand', ['no', 'pass', 'encoder'])
   )
   .fn(t => {
     const { command, finishBeforeCommand } = t.params;
@@ -566,8 +564,10 @@ g.test('compute_pass_commands')
 
     const bindGroup = t.createBindGroupForTest();
 
-    if (finishBeforeCommand) {
+    if (finishBeforeCommand !== 'no') {
       computePass.end();
+    }
+    if (finishBeforeCommand === 'encoder') {
       encoder.finish();
     }
 
@@ -611,5 +611,5 @@ g.test('compute_pass_commands')
         default:
           unreachable();
       }
-    }, finishBeforeCommand);
+    }, finishBeforeCommand !== 'no');
   });