Skip to content

Commit a00f7d0

Browse files
author
Stewart Miles
committed
Worked around Unity 2019's invalid DLL broken errors
Unity 2019 refused to load the iOS Resolver DLL as it has a reference to a potentially missing DLL in the public interface even though the public method would not be called unless the iOS platform is selected and therefore the DLL reference would be resolved successfully. Bug: 136566524 Fixes #247 Change-Id: I0869dfa0b3d03e6a7ea8bd2636d3f46e7dafb67b
1 parent 82c9cd8 commit a00f7d0

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
# Version 1.2.122 - Jul 2, 2019
2+
## Bug Fixes
3+
* iOS Resolver: Worked around Unity not loading the iOS Resolver DLL as it
4+
referenced the Xcode extension in a public interface. The iOS Resolver
5+
DLL still references the Xcode extension internally and just handles
6+
missing type exceptions dynamically.
7+
18
# Version 1.2.121 - Jun 27, 2019
29
## Bug Fixes
310
* Android Resolver: Fixed warning about missing Packages folder when loading

source/IOSResolver/src/IOSResolver.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1579,10 +1579,10 @@ public static IEnumerable<string> XcodeTargetNames {
15791579
/// <summary>
15801580
/// Get Xcode target GUIDs using a method that works across all Unity versions.
15811581
/// </summary>
1582-
/// <param name="project">Project to query.</param>
1582+
/// <param name="xcodeProject">UnityEditor.iOS.Xcode.PBXProject project to query.</param>
15831583
/// <returns>List of target GUIDs.</returns>
1584-
public static IEnumerable<string> GetXcodeTargetGuids(
1585-
UnityEditor.iOS.Xcode.PBXProject project) {
1584+
public static IEnumerable<string> GetXcodeTargetGuids(object xcodeProject) {
1585+
var project = (UnityEditor.iOS.Xcode.PBXProject)xcodeProject;
15861586
var targets = new List<string>();
15871587
if (MultipleXcodeTargetsSupported) {
15881588
// In Unity 2019.3+ TargetGuidByName will throw an exception if the Unity-iPhone target

0 commit comments

Comments
 (0)