Skip to content

Commit ab9c578

Browse files
committed
cmd/golangorg: create datastore connection bofore using it
This change creates a datastore connection before it is used by any of the handlers. Change-Id: I694f3c13bac0433935cf7879d90e7f6ca9b48eca Reviewed-on: https://go-review.googlesource.com/c/website/+/368974 Trust: Carlos Amedee <[email protected]> Run-TryBot: Carlos Amedee <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Website-Publish: Dmitri Shuralyov <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]>
1 parent daaa3e0 commit ab9c578

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

cmd/golangorg/server.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,9 @@ func NewHandler(contentDir, goroot string) http.Handler {
206206
if err != nil {
207207
log.Fatalf("newSite golang.google.cn: %v", err)
208208
}
209+
if runningOnAppEngine {
210+
appEngineSetup(mux)
211+
}
209212
dl.RegisterHandlers(siteMux, godevSite, "", datastoreClient, memcacheClient)
210213
dl.RegisterHandlers(siteMux, chinaSite, "golang.google.cn", datastoreClient, memcacheClient)
211214
mux.Handle("/", siteMux)
@@ -222,10 +225,6 @@ func NewHandler(contentDir, goroot string) http.Handler {
222225

223226
redirect.Register(mux)
224227

225-
if runningOnAppEngine {
226-
appEngineSetup(mux)
227-
}
228-
229228
// Note: Using godevSite (non-China) for global mux registration because there's no sharing in talks.
230229
// Don't need the hassle of two separate registrations for different domains in siteMux.
231230
if err := talks.RegisterHandlers(mux, godevSite, contentFS); err != nil {

0 commit comments

Comments
 (0)