src/utils: move killProcess to test

go-outline usage is removed. This function does not need to be
included in the main extension code.

Change-Id: I8ca3e7b3cfc29015a09c3cff78d7ade668945f55
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/538761
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Peter Weinberger <[email protected]>
TryBot-Result: kokoro <[email protected]>

Author: hyangah

src/utils/processUtils.ts

@@ -21,22 +21,3 @@ export function killProcessTree(p: ChildProcess, logger: (...args: any[]) => voi
 		});
 	});
 }
-
-// Kill a process.
-//
-// READ THIS BEFORE USING THE FUNCTION:
-//
-// TODO: This function is kept for historical reasons and should be removed once
-// its user (go-outline) is replaced. Outlining uses this function and not
-// killProcessTree because of performance issues that were observed in the past.
-// See https://go-review.googlesource.com/c/vscode-go/+/242518/ for more
-// details and background.
-export function killProcess(p: ChildProcess) {
-	if (p && p.pid && p.exitCode === null) {
-		try {
-			p.kill();
-		} catch (e) {
-			console.log(`Error killing process ${p.pid}: ${e}`);
-		}
-	}
-}

test/integration/goDebug.test.ts

@@ -28,7 +28,7 @@ import {
 import * as extConfig from '../../src/config';
 import { GoDebugConfigurationProvider, parseDebugProgramArgSync } from '../../src/goDebugConfiguration';
 import { getBinPath, rmdirRecursive } from '../../src/util';
-import { killProcessTree, killProcess } from '../../src/utils/processUtils';
+import { killProcessTree } from '../../src/utils/processUtils';
 import getPort = require('get-port');
 import util = require('util');
 import { TimestampedLogger } from '../../src/goLogging';
@@ -2565,3 +2565,14 @@ function tryRmdirRecursive(dir: string) {
 		console.log(`failed to delete ${dir}: ${e}`);
 	}
 }
+
+// Kill a process.
+function killProcess(p: cp.ChildProcess) {
+	if (p && p.pid && p.exitCode === null) {
+		try {
+			p.kill();
+		} catch (e) {
+			console.log(`Error killing process ${p.pid}: ${e}`);
+		}
+	}
+}