Skip to content

os: support ReadLinkFS in os.Root.FS [freeze exception] #73887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
neild opened this issue May 27, 2025 · 4 comments
Closed

os: support ReadLinkFS in os.Root.FS [freeze exception] #73887

neild opened this issue May 27, 2025 · 4 comments
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. LibraryProposal Issues describing a requested change to the Go standard library or x/ libraries, but not to a tool
Milestone
Go1.25

Comments

@neild
Copy link
Contributor

neild commented May 27, 2025

This is a request for a freeze exception for https://go.dev/cl/676135.

Proposal #49580, implemented in https://go.dev/cl/385534, adds an io/fs.ReadLinkFS interface and updates the FS returned by os.DirFS to implement this interface. https://go.dev/cl/676135 is a very small followup to this which updates the FS returned by os.Root.FS to also implement ReadLinkFS.

Given the small size and low risk of the change, I think that it's worth giving https://go.dev/cl/676135 a freeze exception to maintain consistency in the features supported by os.DirFS and os.Root.FS.
@gabyhelp
Copy link

Related Issues

Related Code Changes

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gabyhelp gabyhelp added the LibraryProposal Issues describing a requested change to the Go standard library or x/ libraries, but not to a tool label May 27, 2025
@mknyszek mknyszek added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 27, 2025
@mknyszek mknyszek added this to the Go1.25 milestone May 27, 2025
@neild neild added FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels May 28, 2025
@mknyszek
Copy link
Contributor

In the weekly release meeting, we think since the change is small and this bridges a gap between new APIs, that we should go ahead with it. Thanks.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/677395 mentions this issue: _content/doc: update Go 1.25 release note for ReadLinkFS in os.Root.FS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/676135 mentions this issue: os: add implementation of fs.ReadLinkFS to *rootFS

gopherbot pushed a commit to golang/website that referenced this issue May 30, 2025
@zombiezen @gopherbot
_content/doc: update Go 1.25 release note for ReadLinkFS in os.Root.FS
c92a771 
For golang/go#73887

Change-Id: Ibe055ac2ab746a582b3353d2ebd93ee56f1b36c1
Reviewed-on: https://go-review.googlesource.com/c/website/+/677395
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Damien Neil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. LibraryProposal Issues describing a requested change to the Go standard library or x/ libraries, but not to a tool
Projects
Release: Freeze Exceptions
Status: Approved
Milestone
Go1.25
Development

No branches or pull requests
4 participants
@neild @mknyszek @gopherbot @gabyhelp