Skip to content

os: new test TestRootRemoveDot fails on plan9 #73863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
millerresearch opened this issue May 25, 2025 · 0 comments
Open

os: new test TestRootRemoveDot fails on plan9 #73863

millerresearch opened this issue May 25, 2025 · 0 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9
Milestone

Comments

@millerresearch
Copy link
Contributor

CL 661595 added TestRootRemoveDot which fails on Plan 9:

=== RUN   TestRootRemoveDot
    root_test.go:1845: root.Remove(".") = <nil>, want error
    root_test.go:1851: root.Remove(All)?(".") removed the root
--- FAIL: TestRootRemoveDot (0.01s)

@neild, what is the purpose of this test? It appears to be checking that file "." can't be removed, in the context of os.Root where file dot means the directory opened by OpenRoot (not the current working directory as one might normally expect).
I can't find anything in the package documentation for Root that says dot can't be removed. On linux, it seems to be the case as a side effect of the implementation holding an open file descriptor for dot, but on Plan 9 there are no restrictions on deleting an open directory. So it seems to me that this test is checking for an operating system artefact, not checking for correct go behaviour.

@mknyszek mknyszek added OS-Plan9 NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 27, 2025
@mknyszek mknyszek modified the milestones: Backlog, Go1.25 May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9
Projects
None yet
Development

No branches or pull requests

2 participants