`DisplayServer.screen_get_orientation()` returns project settings value instead of runtime orientation when set to `SCREEN_SENSOR*`

[CatMeowByte]

Tested versions

v4.5.stable.official [876b290]

System information

Fedora 43. to test te exported game in Android 12.

Issue description

user likely expect to call the function to get the runtime device orientation so that the logic can branch out accordingly.

turns out calling

DisplayServer.screen_get_orientation()

is equal to

ProjectSettings.get_setting("display/window/handheld/orientation")

someone else mentioned in
#17109

Steps to reproduce

• start a new android project file with appropriate remote debug
• set project settings "display/window/handheld/orientation" to SCREEN_SENSOR
• print(DisplayServer.screen_get_orientation()) anywhere

Minimal reproduction project (MRP)

none provided.

[syntaxerror247]

It makes sense to expect DisplayServer.screen_get_orientation() to return the current device orientation when the screen orientation is set to SENSOR.

That said, how is the user supposed to distinguish whether the returned value represents a fixed orientation (e.g. forced landscape) or a sensor-based orientation where the device is currently in landscape at that moment?

We may need additional constants to express this maybe something like DEVICE_LANDSCAPE and DEVICE_PORTRAIT (or similar).

BTW, how does this behave on iOS? Does it return the actual device orientation there?