load/preload autocomplete injects extra wrapping "

[CNDW]

Godot version

4.4

VS Code version

1.101.2

Godot Tools VS Code extension version

2.5.1

System information

Windows 10

Issue description

when using load or autoload you get autocomplete hints after you add "" as the first argument

when you accept one of the autocomplete options, the string is inserted as a string inside of the "" that was entered to initiate the first argument

I then have to manually clean out the extra ". The autocomplete select should insert the string content, instead of inserting a string literal into the enclosing "

This issue has been present for as long as I have been using the vscode extension since around the 4.0 release, I've only just now realized how to articulate what I was experiencing.

Steps to reproduce

Open any .gd file in any project, begin creating a variable of any name and typing load() or preload() as the assignment value of the variable.

Type " to initiate the autocomplete hints

Select one of the auto-complete options

the auto-complete will insert the enclosing " instead of just completing the string

[DaelonSuzuka]

This extension does not provide autocompletions, it only displays the suggestions given to it by the Godot Language Server.

@HolonProduction thoughts?

[HolonProduction]

The server uses insertText at the moment, this means the server provides full options and the client is responsible for inserting them and matching them with what the user already typed. This is the easiest way to do it, since the builtin editor follows the same architecture, but the problem is that the insertion algorithm is not specified. Godot's builtin insertion algorithm is able to match the quotes with the existing ones in this case, but most other editors seem to use algorithms which don't do that.

The corresponding upstream issue is godotengine/godot#86488

The "correct" solution would be to calculate the insertion on the server side and use textEdit instead of insertText. But that is quite a big change since the GDScript code has no insertion logic at the moment since it is done on the text editor side in the builtin editor.

As quick fix in the meantime it would be possible to not add quotes to the insert text when there already are quotes. Similar to what godotengine/godot#107872 does.

[zimonitrome]

Love this extension but this is my biggest pet peeve.

[Calinou]

@zimonitrome Please don't bump issues without contributing significant new information. Use the 👍 reaction button on the first post instead.