Skip to content

[DRAFT] Expose the EditorScriptHighlighter::_create() method to GDExtension #98929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Nov 7, 2024

Possibly fixes godotengine/godot-cpp#1636

I don't personally know this API, so I don't know if this is the right fix, but throwing this up here either as the fix (if the folks who know this API think this is the right way to do it), or as an example for someone else to take over.

@MXKhronos
Copy link

Would like to see this added soon.

@dsnopek
Copy link
Contributor Author

dsnopek commented Apr 28, 2025

@MXKhronos Do you have a project to test this with? I don't really know these APIs nor have anything setup to test it, which is why this is still marked as a draft

@MXKhronos
Copy link

MXKhronos commented Apr 28, 2025

@MXKhronos Do you have a project to test this with? I don't really know these APIs nor have anything setup to test it, which is why this is still marked as a draft

Yeah, I'm working & learning to add Luau to Godot via a gdextension mimicking the godot/modules/gdscript approach but I have not yet figured out how to get godot-cpp bindings from my custom godot build with this pull's commits.

https://github.com/MXKhronos/LuauGDExtension

It's in src/luauscript/luauscript_syntax_highlighter.h but it's not an override at the moment.

My build gets the same issue as the issue in the post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EditorSyntaxHighlighter is missing _create()
2 participants