Skip to content

Commit 4d600be

Browse files
shindonghwishindonghwi
authored
fix: add missing translations for alpha validators (#1510)
## Summary Add missing English translations for alpha-related validators: - `alphaspace` - `alphanumspace` - `alphaunicode` - `alphanumunicode` These validators exist in `baked_in.go` but had no corresponding translations registered. ## Changes - `translations/en/en.go`: Added 4 new translation entries - `translations/en/en_test.go`: Added test struct fields and expected translations ## Test plan - [x] `go test ./translations/en/...` passes - [x] All existing tests pass Fixes #1480
1 parent b0e4ba2 commit 4d600be

File tree

4 files changed

+90
-6
lines changed

4 files changed

+90
-6
lines changed

‎translations/en/en.go‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1074,6 +1074,26 @@ func RegisterDefaultTranslations(v *validator.Validate, trans ut.Translator) (er
10741074
translation: "{0} can only contain alphanumeric characters",
10751075
override: false,
10761076
},
1077+
{
1078+
tag: "alphaspace",
1079+
translation: "{0} can only contain alphabetic and space characters",
1080+
override: false,
1081+
},
1082+
{
1083+
tag: "alphanumspace",
1084+
translation: "{0} can only contain alphanumeric and space characters",
1085+
override: false,
1086+
},
1087+
{
1088+
tag: "alphaunicode",
1089+
translation: "{0} can only contain unicode alphabetic characters",
1090+
override: false,
1091+
},
1092+
{
1093+
tag: "alphanumunicode",
1094+
translation: "{0} can only contain unicode alphanumeric characters",
1095+
override: false,
1096+
},
10771097
{
10781098
tag: "numeric",
10791099
translation: "{0} must be a valid numeric value",

‎translations/en/en_test.go‎

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,13 @@ func TestTranslations(t *testing.T) {
106106
GteFieldString string `validate:"gtefield=MaxString"`
107107
LtFieldString string `validate:"ltfield=MaxString"`
108108
LteFieldString string `validate:"ltefield=MaxString"`
109-
AlphaString string `validate:"alpha"`
110-
AlphanumString string `validate:"alphanum"`
111-
NumericString string `validate:"numeric"`
109+
AlphaString string `validate:"alpha"`
110+
AlphanumString string `validate:"alphanum"`
111+
AlphaSpaceString string `validate:"alphaspace"`
112+
AlphaNumSpaceString string `validate:"alphanumspace"`
113+
AlphaUnicodeString string `validate:"alphaunicode"`
114+
AlphaNumUnicodeString string `validate:"alphanumunicode"`
115+
NumericString string `validate:"numeric"`
112116
NumberString string `validate:"number"`
113117
HexadecimalString string `validate:"hexadecimal"`
114118
HexColorString string `validate:"hexcolor"`
@@ -487,6 +491,22 @@ func TestTranslations(t *testing.T) {
487491
ns: "Test.AlphaString",
488492
expected: "AlphaString can only contain alphabetic characters",
489493
},
494+
{
495+
ns: "Test.AlphaSpaceString",
496+
expected: "AlphaSpaceString can only contain alphabetic and space characters",
497+
},
498+
{
499+
ns: "Test.AlphaNumSpaceString",
500+
expected: "AlphaNumSpaceString can only contain alphanumeric and space characters",
501+
},
502+
{
503+
ns: "Test.AlphaUnicodeString",
504+
expected: "AlphaUnicodeString can only contain unicode alphabetic characters",
505+
},
506+
{
507+
ns: "Test.AlphaNumUnicodeString",
508+
expected: "AlphaNumUnicodeString can only contain unicode alphanumeric characters",
509+
},
490510
{
491511
ns: "Test.LtFieldString",
492512
expected: "LtFieldString must be less than MaxString",

‎translations/ko/ko.go‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1031,6 +1031,26 @@ func RegisterDefaultTranslations(v *validator.Validate, trans ut.Translator) (er
10311031
translation: "{0}은(는) 알파벳과 숫자만 포함할 수 있습니다.",
10321032
override: false,
10331033
},
1034+
{
1035+
tag: "alphaspace",
1036+
translation: "{0}은(는) 알파벳과 공백만 포함할 수 있습니다.",
1037+
override: false,
1038+
},
1039+
{
1040+
tag: "alphanumspace",
1041+
translation: "{0}은(는) 알파벳, 숫자, 공백만 포함할 수 있습니다.",
1042+
override: false,
1043+
},
1044+
{
1045+
tag: "alphaunicode",
1046+
translation: "{0}은(는) 유니코드 문자만 포함할 수 있습니다.",
1047+
override: false,
1048+
},
1049+
{
1050+
tag: "alphanumunicode",
1051+
translation: "{0}은(는) 유니코드 문자와 숫자만 포함할 수 있습니다.",
1052+
override: false,
1053+
},
10341054
{
10351055
tag: "numeric",
10361056
translation: "{0}은(는) 올바른 숫자여야 합니다.",

‎translations/ko/ko_test.go‎

Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,13 @@ func TestTranslations(t *testing.T) {
102102
GteFieldString string `validate:"gtefield=MaxString"`
103103
LtFieldString string `validate:"ltfield=MaxString"`
104104
LteFieldString string `validate:"ltefield=MaxString"`
105-
AlphaString string `validate:"alpha"`
106-
AlphanumString string `validate:"alphanum"`
107-
NumericString string `validate:"numeric"`
105+
AlphaString string `validate:"alpha"`
106+
AlphanumString string `validate:"alphanum"`
107+
AlphaSpaceString string `validate:"alphaspace"`
108+
AlphaNumSpaceString string `validate:"alphanumspace"`
109+
AlphaUnicodeString string `validate:"alphaunicode"`
110+
AlphaNumUnicodeString string `validate:"alphanumunicode"`
111+
NumericString string `validate:"numeric"`
108112
NumberString string `validate:"number"`
109113
HexadecimalString string `validate:"hexadecimal"`
110114
HexColorString string `validate:"hexcolor"`
@@ -223,6 +227,10 @@ func TestTranslations(t *testing.T) {
223227

224228
test.AlphaString = "abc3"
225229
test.AlphanumString = "abc3!"
230+
test.AlphaSpaceString = "abc3"
231+
test.AlphaNumSpaceString = "abc!"
232+
test.AlphaUnicodeString = "abc3"
233+
test.AlphaNumUnicodeString = "abc!"
226234
test.NumericString = "12E.00"
227235
test.NumberString = "12E"
228236

@@ -472,6 +480,22 @@ func TestTranslations(t *testing.T) {
472480
ns: "Test.AlphaString",
473481
expected: "AlphaString은(는) 알파벳만 포함할 수 있습니다.",
474482
},
483+
{
484+
ns: "Test.AlphaSpaceString",
485+
expected: "AlphaSpaceString은(는) 알파벳과 공백만 포함할 수 있습니다.",
486+
},
487+
{
488+
ns: "Test.AlphaNumSpaceString",
489+
expected: "AlphaNumSpaceString은(는) 알파벳, 숫자, 공백만 포함할 수 있습니다.",
490+
},
491+
{
492+
ns: "Test.AlphaUnicodeString",
493+
expected: "AlphaUnicodeString은(는) 유니코드 문자만 포함할 수 있습니다.",
494+
},
495+
{
496+
ns: "Test.AlphaNumUnicodeString",
497+
expected: "AlphaNumUnicodeString은(는) 유니코드 문자와 숫자만 포함할 수 있습니다.",
498+
},
475499
{
476500
ns: "Test.LtFieldString",
477501
expected: "LtFieldString은(는) MaxString보다 작아야 합니다.",

0 commit comments

Comments
 (0)