Skip to content

Include NOREPLY address when parsing SSH signature #21692

New issue
New issue
Closed
#35045
Closed
Include NOREPLY address when parsing SSH signature#21692
#35045
Labels
type/enhancementAn improvement of existing functionalitytype/proposalThe new feature has not been accepted yet but needs to be discussed first.
Milestone
 
1.24.3
@markdascher

Description

@markdascher
markdascher
opened on Nov 5, 2022

Feature Description

SSH signatures are only recognized on commits with real email addresses:

gitea/models/asymkey/ssh_key_commit_verification.go

Lines 39 to 45 in 6fe756d

activated := false
for _, e := range committerEmailAddresses {
if e.IsActivated && strings.EqualFold(e.Email, c.Committer.Email) {
activated = true
break
}
}

For comparison, GPG signatures include NOREPLY logic already:

gitea/models/asymkey/gpg_key.go

Lines 272 to 274 in 0ebb45c

if user.KeepEmailPrivate && strings.EqualFold(email, user.GetEmail()) {
return true, user.GetEmail()
}

Should there be similar logic for SSH signatures? Otherwise I'd need to reveal my real email address in order to use SSH signatures.

Screenshots

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/enhancementAn improvement of existing functionalitytype/proposalThe new feature has not been accepted yet but needs to be discussed first.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions