-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Open
Labels
proposal/acceptedWe have reviewed the proposal and agree that it should be implemented like that/at all.We have reviewed the proposal and agree that it should be implemented like that/at all.type/proposalThe new feature has not been accepted yet but needs to be discussed first.The new feature has not been accepted yet but needs to be discussed first.type/refactoringExisting code has been cleaned up. There should be no new functionality.Existing code has been cleaned up. There should be no new functionality.
Description
At the moment, there are a couple of places, where we need to query the filesystem - especially for git data, customizations, templates.
Oftentimes, the places we need to query are user-supplied and must thus be sanitized.
Through the new os.Root
in 1.24 we can now ensure that access is only possible in directories we want to access.
As such, we should migrate all filesystem access to use os.Root
wherever possible as a security measure.
hiifong, lunny and devhaozi
Metadata
Metadata
Assignees
Labels
proposal/acceptedWe have reviewed the proposal and agree that it should be implemented like that/at all.We have reviewed the proposal and agree that it should be implemented like that/at all.type/proposalThe new feature has not been accepted yet but needs to be discussed first.The new feature has not been accepted yet but needs to be discussed first.type/refactoringExisting code has been cleaned up. There should be no new functionality.Existing code has been cleaned up. There should be no new functionality.