Skip to content

Commit f3d0e51

Browse files
committed
revert unnecessary change
1 parent 381e5bd commit f3d0e51

29 files changed

+53
-85
lines changed

cmd/admin_user_delete.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,5 @@ func runDeleteUser(ctx context.Context, c *cli.Command) error {
8080
return fmt.Errorf("the user %s does not match the provided id %d", user.Name, c.Int64("id"))
8181
}
8282

83-
adminUser, err := user_model.GetAdminUser(ctx)
84-
if err != nil {
85-
return fmt.Errorf("failed to get admin user: %w", err)
86-
}
87-
88-
return user_service.DeleteUser(ctx, adminUser, user, c.Bool("purge"))
83+
return user_service.DeleteUser(ctx, user, c.Bool("purge"))
8984
}

models/issues/pull_list_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,8 @@ func TestPullRequestList_LoadReviewCommentsCounts(t *testing.T) {
3939
reviewComments, err := prs.LoadReviewCommentsCounts(db.DefaultContext)
4040
assert.NoError(t, err)
4141
assert.Len(t, reviewComments, 2)
42-
for _, pr := range prs {
43-
assert.Equal(t, 1, reviewComments[pr.IssueID])
44-
}
42+
assert.Equal(t, 1, reviewComments[prs[0].IssueID])
43+
assert.Equal(t, 2, reviewComments[prs[1].IssueID])
4544
}
4645

4746
func TestPullRequestList_LoadReviews(t *testing.T) {

routers/api/v1/admin/user.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ func DeleteUser(ctx *context.APIContext) {
300300
return
301301
}
302302

303-
if err := user_service.DeleteUser(ctx, ctx.Doer, ctx.ContextUser, ctx.FormBool("purge")); err != nil {
303+
if err := user_service.DeleteUser(ctx, ctx.ContextUser, ctx.FormBool("purge")); err != nil {
304304
if repo_model.IsErrUserOwnRepos(err) ||
305305
org_model.IsErrUserHasOrgs(err) ||
306306
packages_model.IsErrUserOwnPackages(err) ||

routers/api/v1/org/org.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ func Delete(ctx *context.APIContext) {
421421
// "404":
422422
// "$ref": "#/responses/notFound"
423423

424-
if err := org.DeleteOrganization(ctx, ctx.Doer, ctx.Org.Organization, false); err != nil {
424+
if err := org.DeleteOrganization(ctx, ctx.Org.Organization, false); err != nil {
425425
ctx.APIErrorInternal(err)
426426
return
427427
}

routers/api/v1/repo/migrate.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ func Migrate(ctx *context.APIContext) {
203203
}
204204

205205
if repo != nil {
206-
if errDelete := repo_service.DeleteRepositoryDirectly(ctx, ctx.Doer, repo.ID); errDelete != nil {
206+
if errDelete := repo_service.DeleteRepositoryDirectly(ctx, repo.ID); errDelete != nil {
207207
log.Error("DeleteRepository: %v", errDelete)
208208
}
209209
}

routers/web/admin/users.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -496,7 +496,7 @@ func DeleteUser(ctx *context.Context) {
496496
return
497497
}
498498

499-
if err = user_service.DeleteUser(ctx, ctx.Doer, u, ctx.FormBool("purge")); err != nil {
499+
if err = user_service.DeleteUser(ctx, u, ctx.FormBool("purge")); err != nil {
500500
switch {
501501
case repo_model.IsErrUserOwnRepos(err):
502502
ctx.Flash.Error(ctx.Tr("admin.users.still_own_repo"))

routers/web/org/setting.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ func SettingsDeleteOrgPost(ctx *context.Context) {
149149
return
150150
}
151151

152-
if err := org_service.DeleteOrganization(ctx, ctx.Doer, ctx.Org.Organization, false /* no purge */); err != nil {
152+
if err := org_service.DeleteOrganization(ctx, ctx.Org.Organization, false /* no purge */); err != nil {
153153
if repo_model.IsErrUserOwnRepos(err) {
154154
ctx.JSONError(ctx.Tr("form.org_still_own_repo"))
155155
} else if packages_model.IsErrUserOwnPackages(err) {

routers/web/user/setting/account.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ func DeleteAccount(ctx *context.Context) {
272272
return
273273
}
274274

275-
if err := user.DeleteUser(ctx, ctx.Doer, ctx.Doer, false); err != nil {
275+
if err := user.DeleteUser(ctx, ctx.Doer, false); err != nil {
276276
switch {
277277
case repo_model.IsErrUserOwnRepos(err):
278278
ctx.Flash.Error(ctx.Tr("form.still_own_repo"))

services/cron/tasks_extended.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,7 @@ func registerDeleteInactiveUsers() {
3030
OlderThan: time.Minute * time.Duration(setting.Service.ActiveCodeLives),
3131
}, func(ctx context.Context, _ *user_model.User, config Config) error {
3232
olderThanConfig := config.(*OlderThanConfig)
33-
adminUser, err := user_model.GetAdminUser(ctx)
34-
if err != nil {
35-
return err
36-
}
37-
return user_service.DeleteInactiveUsers(ctx, adminUser, olderThanConfig.OlderThan)
33+
return user_service.DeleteInactiveUsers(ctx, olderThanConfig.OlderThan)
3834
})
3935
}
4036

@@ -115,7 +111,7 @@ func registerDeleteMissingRepositories() {
115111
RunAtStart: false,
116112
Schedule: "@every 72h",
117113
}, func(ctx context.Context, user *user_model.User, _ Config) error {
118-
return repo_service.DeleteMissingRepositories(ctx, user)
114+
return repo_service.DeleteMissingRepositories(ctx)
119115
})
120116
}
121117

services/doctor/repository.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77
"context"
88

99
"code.gitea.io/gitea/models/db"
10-
user_model "code.gitea.io/gitea/models/user"
1110
"code.gitea.io/gitea/modules/log"
1211
"code.gitea.io/gitea/modules/storage"
1312
repo_service "code.gitea.io/gitea/services/repository"
@@ -38,10 +37,6 @@ func deleteOrphanedRepos(ctx context.Context) (int64, error) {
3837

3938
batchSize := db.MaxBatchInsertSize("repository")
4039
var deleted int64
41-
adminUser, err := user_model.GetAdminUser(ctx)
42-
if err != nil {
43-
return deleted, err
44-
}
4540

4641
for {
4742
select {
@@ -62,7 +57,7 @@ func deleteOrphanedRepos(ctx context.Context) (int64, error) {
6257
}
6358

6459
for _, id := range ids {
65-
if err := repo_service.DeleteRepositoryDirectly(ctx, adminUser, id, true); err != nil {
60+
if err := repo_service.DeleteRepositoryDirectly(ctx, id, true); err != nil {
6661
return deleted, err
6762
}
6863
deleted++

0 commit comments

Comments
 (0)