Skip to content

Suggestion #75

Open
Open
@Idomo

Description

@Idomo

Hi @gmarm,
First thing, thanks for building this library, it's great and exactly what I was needed!

I'd like to suggest few things to change, to make the library even better:

  1. Make settings options more easier to understand
    In the beginning I thought there is no way to change it, but now I find out that I can change it via options property, it's not the most understandable way and I couldn't find any examples in the README.md or in the Example project, I think you should do something about it.

  2. Remove layer.masksToBounds = true from line 310 when indicatorViewInset is negative
    When the indicatorViewInset is negative you should get nice effect like this:
    img_ea39e9e44b0f-1
    But instead of that the indicatorViewBackground is cutting of when it's passing the BetterSegmentedControl parent view because of this line.
    I don't see any problem after comment it out so it's just unnecessary.

I'v created pull request for this: #87

Thanks,
Ido.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions