Big deployment template schema doesn't work

[TyOverby]

JSON Schema file in question: http://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json

Running quicktype -s schema deploymentTemplate.json -o deps.ts yields a rather small output file.

You'll notice the resources: any[] field. This is where the bulk of the schema code should be.

Fair warning: once the URL links fully resolved, this file is massive. I wrote a compiler for it once, and it produced tens of thousands of lines of typescript.

[schani]

We don't support external $ref references and allOf yet, unfortunately.

What types would you expect this file to generate?

[TyOverby]

The "expected" output is too big to reason about, but I would expect that the typescript would successfully typecheck all the json that the schema typechecks.

[schani]

I'm curious: if you only care about validation, why wouldn't you use a schema validator like ajv?

[TyOverby]

Oh, it's because I'd like the really nice tooling in Typescript that you get from having the schema translated.

I should add that I'm not really worried about this bug, like I said, I'm currently using a custom json-schema->typescript compiler that I made for this file specifically. I'd like to move off it, and quicktype looks neat, but no rush.

[TyOverby]

Here's the same file, but with all of the $ref references inlined. Warning, it's 93,000 lines.

https://gist.githubusercontent.com/TyOverby/2f4a7036a511684c99accba28128e204/raw/29f25d3067dc7b28a60030e5b256813ea925f5d3/deploymentTemplate.json

[schani]

Thanks!

How do you compile allOf?

[TyOverby]

allOf: [ a, b, c ] becomes a & b & c

[schani]

@TyOverby I implemented all-of in #574. It doesn't completely accept your schema yet, because the schema contains enums with integers and booleans, which I haven't implemented yet. I removed all those here. The types I get look a LOT simpler than the schema, so I'm very skeptical. Could you please provide me with a couple of JSON files that satisfy that schema or, if that's not possible, test it yourself and give me feedback?

[TyOverby]

@schani Yeah, here's a repo filled with them!

https://github.com/Azure/azure-quickstart-templates

Every one of those folders has an azuredeploy.json file that (should) satisfy that schema.

[schani]

@TyOverby I went over all those JSONs with ajv, and most of them do not satisfy the schema. Here's a list of the ones that do.

[TyOverby]

hahaha, good thing I threw that "(should)"!