glideapps
diff --git a/‎.github/workflows/node.js.yml
Lines changed: 2 additions & 0 deletions b/‎.github/workflows/node.js.yml
Lines changed: 2 additions & 0 deletions
diff --git a/‎CONTRIBUTING.md
Lines changed: 6 additions & 2 deletions b/‎CONTRIBUTING.md
Lines changed: 6 additions & 2 deletions
diff --git a/‎README.md
Lines changed: 6 additions & 9 deletions b/‎README.md
Lines changed: 6 additions & 9 deletions
diff --git a/‎bootstrap.sh
Lines changed: 4 additions & 3 deletions b/‎bootstrap.sh
Lines changed: 4 additions & 3 deletions
@@ -21,6 +21,8 @@ jobs:
             - run: npm run bootstrap
             - run: npm run build
             - run: npm run test -- --coverage
+            - run: npm run test-source
+            - run: npm run test-projects
             - name: Coveralls
               uses: coverallsapp/github-action@master
               with:
 
@@ -12,16 +12,20 @@ is to use Codespaces if you have access to it. If you do not, simply cloning the
 -   If this is your first time, then create a new codespace. It will open a new browser tab and build the docker container for it - there will be a button to open the environment in VSCode if you'd prefer to run it that way
 -   You should see a screen that says `Setting up your codespace` As soon as that's done, you should see a VSCode like UI with files on the left.
 
-Once codespaces is up and runnng:
+Once codespaces is up and runnng make sure `jq` is installed and then:
 
 ```bash
-npm run i && npm run storybook
+npm run bootstrap && npm run storybook
 ```
 
 ## Forking the data grid?
 
 Please consider submitting your work for review. We are a small project but we are super enthused when anyone comes by to help us build the best damned data grid on the internet.
 
+## Contributing new cells
+
+If you wish to contribute new cells, please add them to the `cells` package. There are already other cells in that package which can be used as an example. If your cell editor requires additional third party dependencies please consider using a React.lazy to allow for code splitting.
+
 ## Any contributions you make will be under the MIT Software License
 
 In short, when you submit code changes, your submissions are understood to be under the same MIT License that covers the project. Feel free to contact the maintainers if that's a concern.
@@ -4,11 +4,11 @@
 </h1>
 <p align="center">A relatively small HTML5 Canvas based data editor supporting <b>millions</b> of rows, <b>rapid</b> updating, and fully <b>native scrolling</b>. We built <a href="https://grid.glideapps.com" target="_blank">Data Grid</a> as the basis for the <a href="https://docs.glideapps.com/all/reference/data-editor/introduction-to-the-data-editor" target="_blank">Glide Data Editor</a>.</p>
 
-[![Version](https://img.shields.io/badge/latest-v3.4.0-blue?style=for-the-badge&logo=none)](https://github.com/glideapps/glide-data-grid/releases)
+[![Version](https://img.shields.io/npm/v/@glideapps/glide-data-grid?color=blue&label=latest&style=for-the-badge)](https://github.com/glideapps/glide-data-grid/releases)
 [![React 16+](https://img.shields.io/badge/React-16+-00ADD8?style=for-the-badge&logo=react)](https://reactjs.org)
-![Code Coverage](https://img.shields.io/coveralls/github/glideapps/glide-data-grid?color=457aba&label=Cover&style=for-the-badge)
-[![Bundle Size](https://img.shields.io/badge/Bundle-48.6kb-success?style=for-the-badge&logo=none)](https://bundlephobia.com/package/@glideapps/glide-data-grid)
-[![License MIT](https://img.shields.io/badge/license-mit-red?style=for-the-badge&logo=none)](https://github.com/glideapps/glide-data-grid/blob/main/LICENSE)
+[![Code Coverage](https://img.shields.io/coveralls/github/glideapps/glide-data-grid?color=457aba&label=Cover&style=for-the-badge)](https://coveralls.io/github/glideapps/glide-data-grid)
+[![npm bundle size](https://img.shields.io/bundlephobia/minzip/@glideapps/glide-data-grid/3.4.1?color=success&label=bundle&style=for-the-badge)](https://bundlephobia.com/package/@glideapps/glide-data-grid)
+[![License](https://img.shields.io/github/license/glideapps/glide-data-grid?color=red&style=for-the-badge)](https://github.com/glideapps/glide-data-grid/blob/main/LICENSE)
 [![Made By Glide](https://img.shields.io/badge/❤_Made_by-Glide-11CCE5?style=for-the-badge&logo=none)](https://www.glideapps.com/jobs)
 
 ![Data Grid](https://raw.githubusercontent.com/glideapps/glide-data-grid/master/data-grid.jpg)
@@ -47,10 +47,7 @@ npm i lodash marked react-responsive-carousel styled-components
 Create a new `DataEditor` wherever you need to display lots and lots of data
 
 ```tsx
-// The container is not required, but is convenient for getting started
-<DataEditorContainer width={1000} height={700}>
-    <DataEditor getCellContent={getData} columns={columns} rows={numRows} />
-</DataEditorContainer>
+<DataEditor getCellContent={getData} columns={columns} rows={numRows} />
 ```
 
 Making your columns is easy
@@ -68,7 +65,7 @@ Last provide data to the grid
 ```ts
 // If fetching data is slow you can use the DataEditor ref to send updates for cells
 // once data is loaded.
-function getData([col, row]: readonly [number, number]): GridCell {
+function getData([col, row]: Item): GridCell {
     const person = getData(row);
 
     if (col === 0) {
 
@@ -21,11 +21,12 @@ popd
 for DIR in "cells" "source"
 do
     pushd packages/$DIR
-    update ".dependencies.\"@glideapps/glide-data-grid\" = \"3.1.0-beta5\"" package.json
+    update ".dependencies.\"@glideapps/glide-data-grid\" = \"3.4.1\"" package.json
     npm ci
     update ".dependencies.\"@glideapps/glide-data-grid\" = $VERSION" package.json
     update ".version = $VERSION" package.json
-    rm -rf node_modules/@glideapps/glide-data-grid
-    ln -s ../../../core node_modules/@glideapps/glide-data-grid
+    rm -rf node_modules/@glideapps/glide-data-grid/*
+    ln -s ../../../../core/dist node_modules/@glideapps/glide-data-grid/dist
+    ln -s ../../../../core/package.json node_modules/@glideapps/glide-data-grid/package.json
     popd
 done