Skip to content

When the terminal is insufficient to display all the commands, the cmdbar_bg configuration color does not fully take effect. #2347

Open
@wugeer

Description

@wugeer

Describe the bug
In my terminal, Kitty, I've customized the font size. In the GitUI window, when the commands do not fully display on one line, and I press . to show more commands, the background color of these additional commands does not match the cmdbar_bg color configured in ~/.config/gitui/theme.ron.
录屏 2024-08-30 11-59-18.webm

To Reproduce
Steps to reproduce the behavior:

  1. adjust the terminal font size to ensure that the command cannot be displayed in one line
  2. vim ~/.config/gitui/theme.ron
(
    cmdbar_bg: Some("#FFFFFF"),
)
  1. execute gitui command then express . to show more command
    4 . See the difference two command line

Expected behavior
The background color of the two lines of commands is the color configured by cmdbar_bg in ~/.config/gitui/theme.ron.

Screenshots
image

Context (please complete the following information):

  • OS/Distro + Version: [CachyOS Linux x86_64 Linux 6.6.47-1-lts]
  • GitUI Version [ gitui nightly 2024-06-02 (95e1d4d)]
  • Rust version: [rustc 1.80.1 (3f5fd8dd4 2024-08-06)]

Activity

changed the title [-]When the terminal font is insufficient to display all the commands, the cmdbar_bg configuration color does not fully take effect.[/-] [+]When the terminal is insufficient to display all the commands, the cmdbar_bg configuration color does not fully take effect.[/+] on Aug 30, 2024
extrawurst

extrawurst commented on Aug 30, 2024

@extrawurst
Collaborator

interesting. good catch!

added this to the v0.27 milestone on Aug 30, 2024
wugeer

wugeer commented on Aug 30, 2024

@wugeer
ContributorAuthor

@extrawurst hello, maybe I have discovered why this problem occurs. I would like to ask what is the meaning of the fields cmdbar_extra_lines_bg and cmdbar_bg under struct Theme? From my personal perspective, cmdbar_extra_lines_bg actually does not need to exist, the background of cmdbar should remain consistent.
I will submit a PR to fix this issue later. :)

modified the milestones: v0.27, v0.28 on Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      When the terminal is insufficient to display all the commands, the cmdbar_bg configuration color does not fully take effect. · Issue #2347 · gitui-org/gitui