Skip to content

[ssh signing] support custom signing program #2188

@seanaye

Description

@seanaye

Describe the bug
When performing a commit I get the error
sign builder error: Failed to retrieve 'user.signingkey' from the git configuration: Currently, we only support a pair of ssh key in disk.

This is likely because of my git configuration for commit signing.

To Reproduce
Steps to reproduce the behavior:

  1. Add the following to your ~/.gitconfig
[user]
...

[gpg]
	format = ssh
[gpg "ssh"]
	program = /Applications/1Password.app/Contents/MacOS/op-ssh-sign
[commit]
	gpgsign = true
[push]
	autoSetupRemote = true
  1. try to perform a commit
  2. See the error above

Expected behavior
This should work without error. git on the CLI works fine without error

Screenshots
Screenshot 2024-04-15 at 11 38 03 AM

Context (please complete the following information):

  • M2 MacOS 14.4.1
  • GitUI Version gitui nightly 2024-04-14
  • Rust version: cargo 1.77.1 (e52e36006 2024-03-26)

Additional context
Add any other context about the problem here.

Activity

extrawurst

extrawurst commented on Apr 15, 2024

@extrawurst
Collaborator

Yeah right now we do not support calling a custom ssh program as you have configured

changed the title [-]Cant use commit signing [/-] [+][ssh signing] support custom signing program[/+] on Apr 15, 2024
added
enhancementNew feature or request
and removed
bugSomething isn't working
on Apr 15, 2024
seanaye

seanaye commented on Apr 17, 2024

@seanaye
Author

I am working on a PR to support this.

linked a pull request that will close this issue on Apr 19, 2024
chirpcel

chirpcel commented on Jan 3, 2025

@chirpcel

I'll take a look as this as the opened pull request seems to be abandoned

chirpcel

chirpcel commented on Jan 4, 2025

@chirpcel

First prototype is ready (see #2464), looking into support for key literal in .gitconfig and writing tests. Then I'll mark it as ready.

chirpcel

chirpcel commented on Jan 4, 2025

@chirpcel

Done, waiting for review.

fredriksvensson

fredriksvensson commented on May 10, 2025

@fredriksvensson

Hey @chirpcel and @naseschwarz . Is there anything happening on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      [ssh signing] support custom signing program · Issue #2188 · gitui-org/gitui