[server] increase pagesize and fail when too much is requested. (#19817)

Author: svenefftinge

components/public-api/typescript-common/src/public-api-pagination.ts

@@ -16,15 +16,16 @@ const DEFAULT_PAGE_SIZE = 50;
 export function parsePagination(
     pagination: Partial<PaginationRequest> | undefined,
     defaultPageSize = DEFAULT_PAGE_SIZE,
+    maxPageSize = MAX_PAGE_SIZE,
 ): ParsedPagination {
     let pageSize = pagination?.pageSize ?? defaultPageSize;
     if (!Number.isInteger(pageSize)) {
         pageSize = defaultPageSize;
     }
     if (pageSize < 0) {
         pageSize = defaultPageSize;
-    } else if (pageSize > MAX_PAGE_SIZE) {
-        pageSize = MAX_PAGE_SIZE;
+    } else if (pageSize > maxPageSize) {
+        pageSize = maxPageSize;
     }
     let page = pagination?.page ?? 0;
     if (!Number.isInteger(page) || (page ?? 0) < 0) {

components/server/src/api/workspace-service-api.ts

@@ -90,7 +90,10 @@ export class WorkspaceServiceAPI implements ServiceImpl<typeof WorkspaceServiceI
     }
 
     async listWorkspaces(req: ListWorkspacesRequest, _: HandlerContext): Promise<ListWorkspacesResponse> {
-        const { limit } = parsePagination(req.pagination, 50);
+        if (req.pagination?.pageSize && req.pagination?.pageSize > 400) {
+            throw new ApplicationError(ErrorCodes.BAD_REQUEST, "Pagesize must not exceed 400");
+        }
+        const { limit } = parsePagination(req.pagination, 50, 400);
         if (!uuidValidate(req.organizationId)) {
             throw new ApplicationError(ErrorCodes.BAD_REQUEST, "organizationId is required");
         }
@@ -112,7 +115,10 @@ export class WorkspaceServiceAPI implements ServiceImpl<typeof WorkspaceServiceI
         req: ListWorkspaceSessionsRequest,
         _: HandlerContext,
     ): Promise<ListWorkspaceSessionsResponse> {
-        const page = parsePagination(req.pagination, 50);
+        if (req.pagination?.pageSize && req.pagination?.pageSize > 400) {
+            throw new ApplicationError(ErrorCodes.BAD_REQUEST, "Pagesize must not exceed 400");
+        }
+        const page = parsePagination(req.pagination, 100, 400);
         if (!uuidValidate(req.organizationId)) {
             throw new ApplicationError(ErrorCodes.BAD_REQUEST, "organizationId is required");
         }