Remove token refresh feature flags (#19768)

* [server] Drop feature flag opportunistic_token_refresh

* [server] Drop feature flag workspace_start_scm_access_token_lifetime

Author: geropl

components/server/src/user/token-service.spec.db.ts

@@ -69,7 +69,6 @@ describe("TokenService", async () => {
         container = createTestContainer();
         Experiments.configureTestingClient({
             centralizedPermissions: true,
-            opportunistic_token_refresh: true,
         });
 
         // re-overwrite the stuff mocked out in createTestContainer

components/server/src/user/token-service.ts

@@ -18,7 +18,6 @@ import {
     reportScmTokenRefreshRequest,
     scmTokenRefreshLatencyHistogram,
 } from "../prometheus-metrics";
-import { getExperimentsClientForBackend } from "@gitpod/gitpod-protocol/lib/experiments/configcat-server";
 
 @injectable()
 export class TokenService implements TokenProvider {
@@ -94,9 +93,7 @@ export class TokenService implements TokenProvider {
                     const { authProvider } = this.hostContextProvider.get(host)!;
                     if (isValidUntil(token, requestedLifetimeDate)) {
                         const doOpportunisticRefresh =
-                            (await isOpportunisticTokenRefreshEnabled(userId)) &&
-                            !!authProvider.requiresOpportunisticRefresh &&
-                            authProvider.requiresOpportunisticRefresh();
+                            !!authProvider.requiresOpportunisticRefresh && authProvider.requiresOpportunisticRefresh();
                         if (!doOpportunisticRefresh) {
                             // No opportunistic refresh? Update reserveation and we are done.
                             await updateReservation(tokenEntry.uid, token, requestedLifetimeDate);
@@ -203,14 +200,6 @@ export class TokenService implements TokenProvider {
     }
 }
 
-export async function isOpportunisticTokenRefreshEnabled(userId: string): Promise<boolean> {
-    return getExperimentsClientForBackend().getValueAsync("opportunistic_token_refresh", false, {
-        user: {
-            id: userId,
-        },
-    });
-}
-
 function nowPlusMins(mins: number): Date {
     const now = new Date();
     now.setTime(now.getTime() + mins * 60 * 1000);

components/server/src/workspace/workspace-starter.ts

@@ -144,7 +144,7 @@ export interface StartWorkspaceOptions extends Omit<GitpodServer.StartWorkspaceO
 const MAX_INSTANCE_START_RETRIES = 2;
 const INSTANCE_START_RETRY_INTERVAL_SECONDS = 2;
 /** [mins] */
-const SCM_TOKEN_LIFETIME_MINS = 10;
+const SCM_TOKEN_LIFETIME_MINS = 30;
 
 export async function getWorkspaceClassForInstance(
     ctx: TraceContext,
@@ -1852,8 +1852,7 @@ export class WorkspaceStarter {
             targetMode = CloneTargetMode.REMOTE_HEAD;
         }
 
-        const tokenValidityPeriodMins = await getScmAccessTokenLifetimeMins(user);
-        const gitToken = await this.tokenProvider.getTokenForHost(user, host, tokenValidityPeriodMins);
+        const gitToken = await this.tokenProvider.getTokenForHost(user, host, SCM_TOKEN_LIFETIME_MINS);
         if (!gitToken) {
             throw new Error(`No token for host: ${host}`);
         }
@@ -1979,18 +1978,6 @@ export async function isWorkspaceClassDiscoveryEnabled(user: { id: string }): Pr
     });
 }
 
-export async function getScmAccessTokenLifetimeMins(user: { id: string }): Promise<number> {
-    const customValue = await getExperimentsClientForBackend().getValueAsync<number | undefined>(
-        "workspace_start_scm_access_token_lifetime",
-        undefined,
-        {
-            user: user,
-        },
-    );
-
-    return customValue || SCM_TOKEN_LIFETIME_MINS;
-}
-
 export class ScmStartError extends Error {
     constructor(public readonly host: string, msg: string) {
         super(`${host}: ` + msg);