Skip to content

fix: Add loading state to "Refresh Notifications" button #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eriklindebratt
Copy link
Contributor

@eriklindebratt eriklindebratt commented Apr 4, 2024

Adds a small animation as loading state to the "Refresh Notifications" button, shown when notifications are fetching.

@eriklindebratt eriklindebratt marked this pull request as ready for review April 4, 2024 21:05
@setchy
Copy link
Member

setchy commented Apr 5, 2024

@eriklindebratt - thanks for the contributions. Simple change, but BIG impact. Love it!

@setchy setchy merged commit 61e5c95 into gitify-app:main Apr 5, 2024
@eriklindebratt eriklindebratt deleted the fix/add-visual-indication-when-fetching-notifications branch April 5, 2024 06:42
@bmulholland
Copy link
Collaborator

I also love it, thank you!

@setchy setchy added this to the Release 5.3.0 milestone Apr 5, 2024
@setchy setchy added the bug Something isn't working label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants