chore(deps): update @biomejs/biome to v2 (#2063)

* chore(deps): update @biomejs/biome to v2

* apply biome fixes

Signed-off-by: Adam Setch <[email protected]>

* apply biome fixes

Signed-off-by: Adam Setch <[email protected]>

---------

Signed-off-by: Adam Setch <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Adam Setch <[email protected]>

Author: renovate[bot]

biome.json

@@ -1,17 +1,52 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
-  "organizeImports": {
-    "enabled": true
+  "$schema": "https://biomejs.dev/schemas/2.0.0/schema.json",
+  "assist": {
+    "actions": {
+      "source": {
+        "organizeImports": {
+          "level": "on",
+          "options": {
+            "groups": [
+              ":NODE:",
+              ":BLANK_LINE:",
+              ["react*", "@testing-library/**"],
+              ":BLANK_LINE:",
+              ["*electron*", "menubar"],
+              ":BLANK_LINE:",
+              "@primer/**",
+              ":BLANK_LINE:",
+              ":PACKAGE:",
+              ":BLANK_LINE:",
+              "**"
+            ]
+          }
+        }
+      }
+    }
   },
   "linter": {
     "enabled": true,
+    "domains": {
+      "react": "recommended",
+      "test": "recommended"
+    },
     "rules": {
       "recommended": true,
       "suspicious": {
-        "noConsoleLog": "error"
+        "noConsole": "error"
       },
       "style": {
-        "useDefaultSwitchClause": "error"
+        "useDefaultSwitchClause": "error",
+        "noParameterAssign": "error",
+        "useAsConstAssertion": "error",
+        "useDefaultParameterLast": "error",
+        "useEnumInitializers": "error",
+        "useSelfClosingElements": "error",
+        "useSingleVarDeclarator": "error",
+        "noUnusedTemplateLiteral": "error",
+        "useNumberNamespace": "error",
+        "noInferrableTypes": "error",
+        "noUselessElse": "error"
       },
       "a11y": {
         "useKeyWithClickEvents": "off",
@@ -25,6 +60,9 @@
             "hooks": [{ "name": "useNavigate", "stableResult": true }]
           }
         }
+      },
+      "nursery": {
+        "useUniqueElementIds": "warn"
       }
     }
   },

config/webpack.config.main.base.ts

@@ -1,6 +1,8 @@
 import path from 'node:path';
+
 import type webpack from 'webpack';
 import { merge } from 'webpack-merge';
+
 import baseConfig from './webpack.config.common';
 import webpackPaths from './webpack.paths';
 

config/webpack.config.main.prod.ts

@@ -1,6 +1,7 @@
 import TerserPlugin from 'terser-webpack-plugin';
 import type webpack from 'webpack';
 import { merge } from 'webpack-merge';
+
 import baseConfig from './webpack.config.main.base';
 
 const configuration: webpack.Configuration = {

config/webpack.config.renderer.base.ts

@@ -1,13 +1,14 @@
 import path from 'node:path';
+
 import CopyWebpackPlugin from 'copy-webpack-plugin';
 import HtmlWebpackPlugin from 'html-webpack-plugin';
 import MiniCssExtractPlugin from 'mini-css-extract-plugin';
 import webpack from 'webpack';
 import { merge } from 'webpack-merge';
-import baseConfig from './webpack.config.common';
-import webpackPaths from './webpack.paths';
 
 import { ALL_EMOJI_SVG_FILENAMES } from '../src/renderer/utils/emojis';
+import baseConfig from './webpack.config.common';
+import webpackPaths from './webpack.paths';
 
 const configuration: webpack.Configuration = {
   devtool: 'inline-source-map',

config/webpack.config.renderer.prod.ts

@@ -2,6 +2,7 @@ import CssMinimizerPlugin from 'css-minimizer-webpack-plugin';
 import TerserPlugin from 'terser-webpack-plugin';
 import type webpack from 'webpack';
 import { merge } from 'webpack-merge';
+
 import baseConfig from './webpack.config.renderer.base';
 
 const configuration: webpack.Configuration = {

package.json

@@ -77,7 +77,7 @@
     "update-electron-app": "3.1.1"
   },
   "devDependencies": {
-    "@biomejs/biome": "1.9.4",
+    "@biomejs/biome": "2.0.0",
     "@discordapp/twemoji": "15.1.0",
     "@electron/notarize": "3.0.1",
     "@primer/octicons-react": "19.15.2",

pnpm-lock.yaml

@@ -6,7 +6,7 @@ const builderConfig = require('../config/electron-builder');
 const electronLanguages = builderConfig.electronLanguages;
 
 function logAfterPackProgress(msg) {
-  // biome-ignore lint/suspicious/noConsoleLog: log notarizing progress
+  // biome-ignore lint/suspicious/noConsole: log notarizing progress
   console.log(`  • [afterPack]: ${msg}`);
 }
 

scripts/afterPack.js

@@ -2,7 +2,7 @@ const { notarize } = require('@electron/notarize');
 const { AfterPackContext } = require('electron-builder');
 
 function logAfterSignProgress(msg) {
-  // biome-ignore lint/suspicious/noConsoleLog: log notarizing progress
+  // biome-ignore lint/suspicious/noConsole: log notarizing progress
   console.log(`  • [afterSign]: ${msg}`);
 }
 

scripts/afterSign.js

@@ -1,6 +1,8 @@
 import fs from 'node:fs';
 import path from 'node:path';
+
 import { rimrafSync } from 'rimraf';
+
 import webpackPaths from '../config/webpack.paths';
 
 function deleteSourceMaps() {

scripts/delete-source-maps.ts

@@ -1,5 +1,6 @@
 import fs from 'node:fs';
 import path from 'node:path';
+
 import { app, dialog } from 'electron';
 
 import { APPLICATION } from '../shared/constants';

src/main/first-run.ts

@@ -1,6 +1,7 @@
 import fs from 'node:fs';
 import os from 'node:os';
 import path from 'node:path';
+
 import { dialog, shell } from 'electron';
 import log from 'electron-log';
 import type { Menubar } from 'menubar';

src/main/utils.ts

@@ -1,6 +1,7 @@
-import { Stack } from '@primer/react';
 import type { FC, ReactNode } from 'react';
 
+import { Stack } from '@primer/react';
+
 import { cn } from '../../utils/cn';
 import { CustomCounter } from '../primitives/CustomCounter';
 import { Tooltip } from './Tooltip';

src/renderer/components/fields/Checkbox.tsx

@@ -1,6 +1,7 @@
+import { type FC, type ReactNode, useState } from 'react';
+
 import { QuestionIcon } from '@primer/octicons-react';
 import { Box } from '@primer/react';
-import { type FC, type ReactNode, useState } from 'react';
 
 export interface ITooltip {
   name: string;

src/renderer/components/fields/Tooltip.tsx

@@ -1,8 +1,9 @@
-import { MarkGithubIcon } from '@primer/octicons-react';
 import { act, render, screen } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import { MemoryRouter } from 'react-router-dom';
 
+import { MarkGithubIcon } from '@primer/octicons-react';
+
 import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
 import { mockSettings } from '../../__mocks__/state-mocks';
 import { AppContext } from '../../context/App';

src/renderer/components/filters/FilterSection.test.tsx

@@ -1,6 +1,7 @@
-import { Text } from '@primer/react';
 import type { FC } from 'react';
 
+import { Text } from '@primer/react';
+
 export const RequiresDetailedNotificationWarning: FC = () => (
   <Text className="text-gitify-caution">
     ⚠️ This filter requires the <Text as="strong">Detailed Notifications</Text>{' '}

src/renderer/components/filters/RequiresDetailedNotificationsWarning.tsx

@@ -1,12 +1,12 @@
 import { type FC, useContext, useEffect, useState } from 'react';
 
-import { Box, Stack, Text, TextInputWithTokens } from '@primer/react';
-
 import {
   CheckCircleFillIcon,
   MentionIcon,
   NoEntryFillIcon,
 } from '@primer/octicons-react';
+import { Box, Stack, Text, TextInputWithTokens } from '@primer/react';
+
 import { AppContext } from '../../context/App';
 import { IconColor, type UserHandle } from '../../types';
 import {

src/renderer/components/filters/UserHandleFilter.tsx

@@ -1,6 +1,7 @@
-import { Box } from '@primer/react';
 import type { FC, ReactNode } from 'react';
 
+import { Box } from '@primer/react';
+
 import { Sidebar } from '../Sidebar';
 
 interface IAppLayout {

src/renderer/components/layout/AppLayout.tsx

@@ -1,6 +1,7 @@
-import { Stack } from '@primer/react';
 import type { FC, ReactNode } from 'react';
 
+import { Stack } from '@primer/react';
+
 interface ICentered {
   children: ReactNode;
   fullHeight: boolean;

src/renderer/components/layout/Centered.tsx

@@ -1,6 +1,7 @@
-import { Box } from '@primer/react';
 import type { FC, ReactNode } from 'react';
 
+import { Box } from '@primer/react';
+
 import { cn } from '../../utils/cn';
 
 interface IContents {

src/renderer/components/layout/Contents.tsx

@@ -1,6 +1,7 @@
-import { Box, Stack } from '@primer/react';
 import type { FC } from 'react';
 
+import { Box, Stack } from '@primer/react';
+
 import { EmojiText } from '../primitives/EmojiText';
 import { Centered } from './Centered';