refactor: resolve sonar feedback on regex patterns (#1825)

setchy · web-flow · commit a9de61faaa4d · 2025-02-08T16:30:08.000-05:00
refactor: sonar regex tweaks

Signed-off-by: Adam Setch &lt;adam.setch@outlook.com&gt;
diff --git a/src/renderer/utils/api/utils.ts b/src/renderer/utils/api/utils.ts
@@ -28,6 +28,6 @@ export function getNextURLFromLinkHeader(
   response: AxiosResponse,
 ): string | null {
   const linkHeader = response.headers.link;
-  const matches = linkHeader?.match(/<([^>]+)>;\s*rel="next"/);
+  const matches = linkHeader?.match(/<([^<>]+)>;\s*rel="next"/);
   return matches ? matches[1] : null;
 }
diff --git a/src/renderer/utils/subject.ts b/src/renderer/utils/subject.ts
@@ -338,8 +338,7 @@ export function parseLinkedIssuesFromPr(pr: PullRequest): string[] {
     return linkedIssues;
   }
 
-  const regexPattern = /\s*#(\d+)\s*/gi;
-
+  const regexPattern = /\s?#(\d+)\s?/gi;
   const matches = pr.body.matchAll(regexPattern);
 
   for (const match of matches) {

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,6 @@ export function getNextURLFromLinkHeader(`
`28`	`28`	`response: AxiosResponse,`
`29`	`29`	`): string \| null {`
`30`	`30`	`const linkHeader = response.headers.link;`
`31`		`- const matches = linkHeader?.match(/<([^>]+)>;\s*rel="next"/);`
	`31`	`+ const matches = linkHeader?.match(/<([^<>]+)>;\s*rel="next"/);`
`32`	`32`	`return matches ? matches[1] : null;`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -338,8 +338,7 @@ export function parseLinkedIssuesFromPr(pr: PullRequest): string[] {`
`338`	`338`	`return linkedIssues;`
`339`	`339`	`}`
`340`	`340`
`341`		`- const regexPattern = /\s#(\d+)\s/gi;`
`342`		`-`
	`341`	`+ const regexPattern = /\s?#(\d+)\s?/gi;`
`343`	`342`	`const matches = pr.body.matchAll(regexPattern);`
`344`	`343`
`345`	`344`	`for (const match of matches) {`