Merge pull request #1230 from github/meme_generator_errors

[meme_generator] Better error handling

Author: technicalpickles

src/scripts/meme_generator.coffee

@@ -35,6 +35,9 @@
 # Author:
 #   skalnik
 
+
+inspect = require('util').inspect
+
 module.exports = (robot) ->
   unless robot.brain.data.memes?
     robot.brain.data.memes = [
@@ -196,19 +199,33 @@ memeGenerator = (msg, generatorID, imageID, text0, text1, callback) ->
       text0: text0,
       text1: text1
     .get() (err, res, body) ->
-      result = JSON.parse(body)['result']
-      if result? and result['instanceUrl']? and result['instanceImageUrl']? and result['instanceID']?
-        instanceID = result['instanceID']
-        instanceURL = result['instanceUrl']
-        img = result['instanceImageUrl']
-        msg.http(instanceURL).get() (err, res, body) ->
-          # Need to hit instanceURL so that image gets generated
-          if preferredDimensions?
-            callback "http://images.memegenerator.net/instances/#{preferredDimensions}/#{instanceID}.jpg"
-          else
-            callback "http://images.memegenerator.net/instances/#{instanceID}.jpg"
-      else
-        msg.reply "Sorry, I couldn't generate that image."
+      if err
+        msg.reply "Ugh, I got an exception trying to contact memegenerator.net:", inspect(err)
+        return
+
+      jsonBody = JSON.parse(body)
+      success = jsonBody.success
+      errorMessage = jsonBody.errorMessage
+      result = jsonBody.result
+
+      if not success
+        msg.reply "Ugh, stupid request to memegenerator.net failed: \"#{errorMessage}.\" What does that even mean?"
+        return
+
+      instanceID = result?.instanceID
+      instanceURL = result?.instanceUrl
+      img = result?.instanceImageUrl
+
+      unless instanceID and instanceURL and img
+        msg.reply "Ugh, I got back weird results from memegenerator.net. Expected an image URL, but couldn't find it in the result. Here's what I got:", inspect(jsonBody)
+        return
+
+      msg.http(instanceURL).get() (err, res, body) ->
+        # Need to hit instanceURL so that image gets generated
+        if preferredDimensions?
+          callback "http://images.memegenerator.net/instances/#{preferredDimensions}/#{instanceID}.jpg"
+        else
+          callback "http://images.memegenerator.net/instances/#{instanceID}.jpg"
 
 khanify = (msg) ->
   msg = msg.toUpperCase()