chore(dashboards): Remove backend feature flag for favorites (#92998)

Remove the favorites feature flag from the backend code

Author: narsaynorath

src/sentry/api/endpoints/organization_dashboard_details.py

@@ -214,9 +214,6 @@ def put(self, request: Request, organization, dashboard) -> Response:
         Toggle favorite status for current user by adding or removing
         current user from dashboard favorites
         """
-        if not features.has("organizations:dashboards-favourite", organization, actor=request.user):
-            return Response(status=404)
-
         if not features.has(EDIT_FEATURE, organization, actor=request.user):
             return Response(status=404)
 

src/sentry/api/endpoints/organization_dashboards.py

@@ -102,18 +102,15 @@ def get(self, request: Request, organization) -> Response:
         if not features.has("organizations:dashboards-basic", organization, actor=request.user):
             return Response(status=404)
 
-        if features.has("organizations:dashboards-favourite", organization, actor=request.user):
-            filter_by = request.query_params.get("filter")
-            if filter_by == "onlyFavorites":
-                dashboards = Dashboard.objects.filter(
-                    organization_id=organization.id, dashboardfavoriteuser__user_id=request.user.id
-                )
-            elif filter_by == "excludeFavorites":
-                dashboards = Dashboard.objects.exclude(
-                    organization_id=organization.id, dashboardfavoriteuser__user_id=request.user.id
-                )
-            else:
-                dashboards = Dashboard.objects.filter(organization_id=organization.id)
+        filter_by = request.query_params.get("filter")
+        if filter_by == "onlyFavorites":
+            dashboards = Dashboard.objects.filter(
+                organization_id=organization.id, dashboardfavoriteuser__user_id=request.user.id
+            )
+        elif filter_by == "excludeFavorites":
+            dashboards = Dashboard.objects.exclude(
+                organization_id=organization.id, dashboardfavoriteuser__user_id=request.user.id
+            )
         else:
             dashboards = Dashboard.objects.filter(organization_id=organization.id)
 
@@ -195,23 +192,20 @@ def get(self, request: Request, organization) -> Response:
         else:
             order_by = ["title"]
 
-        if features.has("organizations:dashboards-favourite", organization, actor=request.user):
-            pin_by = request.query_params.get("pin")
-            if pin_by == "favorites":
-                favorited_by_subquery = DashboardFavoriteUser.objects.filter(
-                    dashboard=OuterRef("pk"), user_id=request.user.id
+        pin_by = request.query_params.get("pin")
+        if pin_by == "favorites":
+            favorited_by_subquery = DashboardFavoriteUser.objects.filter(
+                dashboard=OuterRef("pk"), user_id=request.user.id
+            )
+
+            order_by_favorites = [
+                Case(
+                    When(Exists(favorited_by_subquery), then=-1),
+                    default=1,
+                    output_field=IntegerField(),
                 )
-
-                order_by_favorites = [
-                    Case(
-                        When(Exists(favorited_by_subquery), then=-1),
-                        default=1,
-                        output_field=IntegerField(),
-                    )
-                ]
-                dashboards = dashboards.order_by(*order_by_favorites, *order_by)
-            else:
-                dashboards = dashboards.order_by(*order_by)
+            ]
+            dashboards = dashboards.order_by(*order_by_favorites, *order_by)
         else:
             dashboards = dashboards.order_by(*order_by)
 
@@ -236,9 +230,8 @@ def handle_results(results):
             return serialized
 
         render_pre_built_dashboard = True
-        if features.has("organizations:dashboards-favourite", organization, actor=request.user):
-            if filter_by and filter_by == "onlyFavorites" or pin_by and pin_by == "favorites":
-                render_pre_built_dashboard = False
+        if filter_by and filter_by == "onlyFavorites" or pin_by and pin_by == "favorites":
+            render_pre_built_dashboard = False
 
         return self.paginate(
             request=request,

tests/sentry/api/endpoints/test_organization_dashboard_details.py

@@ -413,10 +413,9 @@ def test_get_favorited_user_status(self):
         self.dashboard.favorited_by = [self.user_1.id, self.user_2.id]
 
         self.login_as(user=self.user_1)
-        with self.feature({"organizations:dashboards-favourite": True}):
-            response = self.do_request("get", self.url(self.dashboard.id))
-            assert response.status_code == 200
-            assert response.data["isFavorited"] is True
+        response = self.do_request("get", self.url(self.dashboard.id))
+        assert response.status_code == 200
+        assert response.data["isFavorited"] is True
 
     def test_get_not_favorited_user_status(self):
         self.user_1 = self.create_user(email="[email protected]")
@@ -426,10 +425,9 @@ def test_get_not_favorited_user_status(self):
         user_3 = self.create_user()
         self.create_member(user=user_3, organization=self.organization)
         self.login_as(user=user_3)
-        with self.feature({"organizations:dashboards-favourite": True}):
-            response = self.do_request("get", self.url(self.dashboard.id))
-            assert response.status_code == 200
-            assert response.data["isFavorited"] is False
+        response = self.do_request("get", self.url(self.dashboard.id))
+        assert response.status_code == 200
+        assert response.data["isFavorited"] is False
 
     def test_get_favorite_status_no_dashboard_edit_access(self):
         self.user_1 = self.create_user(email="[email protected]")
@@ -455,10 +453,9 @@ def test_get_favorite_status_no_dashboard_edit_access(self):
         assert response.status_code == 403
 
         # assert user can see if they favorited the dashboard
-        with self.feature({"organizations:dashboards-favourite": True}):
-            response = self.do_request("get", self.url(self.dashboard.id))
-            assert response.status_code == 200
-            assert response.data["isFavorited"] is True
+        response = self.do_request("get", self.url(self.dashboard.id))
+        assert response.status_code == 200
+        assert response.data["isFavorited"] is True
 
 
 class OrganizationDashboardDetailsDeleteTest(OrganizationDashboardDetailsTestCase):
@@ -3255,22 +3252,16 @@ def url(self, dashboard_id):
     def test_favorite_dashboard(self):
         assert self.user.id not in self.dashboard.favorited_by
         self.login_as(user=self.user)
-        with self.feature({"organizations:dashboards-favourite": True}):
-            response = self.do_request(
-                "put", self.url(self.dashboard.id), data={"isFavorited": "true"}
-            )
-            assert response.status_code == 204
-            assert self.user.id in self.dashboard.favorited_by
+        response = self.do_request("put", self.url(self.dashboard.id), data={"isFavorited": "true"})
+        assert response.status_code == 204
+        assert self.user.id in self.dashboard.favorited_by
 
     def test_unfavorite_dashboard(self):
         assert self.user_1.id in self.dashboard.favorited_by
         self.login_as(user=self.user_1)
-        with self.feature({"organizations:dashboards-favourite": True}):
-            response = self.do_request(
-                "put", self.url(self.dashboard.id), data={"isFavorited": False}
-            )
-            assert response.status_code == 204
-            assert self.user_1.id not in self.dashboard.favorited_by
+        response = self.do_request("put", self.url(self.dashboard.id), data={"isFavorited": False})
+        assert response.status_code == 204
+        assert self.user_1.id not in self.dashboard.favorited_by
 
     def test_favorite_dashboard_no_dashboard_edit_access(self):
         DashboardPermissions.objects.create(is_editable_by_everyone=False, dashboard=self.dashboard)
@@ -3288,9 +3279,6 @@ def test_favorite_dashboard_no_dashboard_edit_access(self):
 
         # assert if user can edit the favorite status of the dashboard
         assert self.user_2.id in self.dashboard.favorited_by
-        with self.feature({"organizations:dashboards-favourite": True}):
-            response = self.do_request(
-                "put", self.url(self.dashboard.id), data={"isFavorited": False}
-            )
-            assert response.status_code == 204
-            assert self.user_2.id not in self.dashboard.favorited_by
+        response = self.do_request("put", self.url(self.dashboard.id), data={"isFavorited": False})
+        assert response.status_code == 204
+        assert self.user_2.id not in self.dashboard.favorited_by

tests/sentry/api/endpoints/test_organization_dashboards.py

@@ -315,13 +315,12 @@ def test_get_only_favorites_no_sort(self):
         dashboard_6.favorited_by = [user_2.id]
 
         self.login_as(user_1)
-        with self.feature("organizations:dashboards-favourite"):
-            response = self.client.get(self.url, data={"filter": "onlyFavorites"})
-            assert response.status_code == 200, response.content
+        response = self.client.get(self.url, data={"filter": "onlyFavorites"})
+        assert response.status_code == 200, response.content
 
-            values = [row["title"] for row in response.data]
-            # sorted by title by default
-            assert values == ["Dashboard 3", "Dashboard 4", "Dashboard 5"]
+        values = [row["title"] for row in response.data]
+        # sorted by title by default
+        assert values == ["Dashboard 3", "Dashboard 4", "Dashboard 5"]
 
     def test_get_only_favorites_with_sort(self):
         user_1 = self.create_user(username="user_1")
@@ -366,14 +365,13 @@ def test_get_only_favorites_with_sort(self):
         dashboard_7.favorited_by = [user_2.id]
 
         self.login_as(user_1)
-        with self.feature("organizations:dashboards-favourite"):
-            response = self.client.get(
-                self.url, data={"filter": "onlyFavorites", "sort": "dateCreated"}
-            )
-            assert response.status_code == 200, response.content
+        response = self.client.get(
+            self.url, data={"filter": "onlyFavorites", "sort": "dateCreated"}
+        )
+        assert response.status_code == 200, response.content
 
-            values = [row["title"] for row in response.data]
-            assert values == ["Dashboard 4", "Dashboard 3", "Dashboard 5"]
+        values = [row["title"] for row in response.data]
+        assert values == ["Dashboard 4", "Dashboard 3", "Dashboard 5"]
 
     def test_get_exclude_favorites_with_no_sort(self):
         user_1 = self.create_user(username="user_1")
@@ -418,13 +416,12 @@ def test_get_exclude_favorites_with_no_sort(self):
         dashboard_6.favorited_by = [user_2.id]
 
         self.login_as(user_1)
-        with self.feature("organizations:dashboards-favourite"):
-            response = self.client.get(self.url, data={"filter": "excludeFavorites"})
-            assert response.status_code == 200, response.content
+        response = self.client.get(self.url, data={"filter": "excludeFavorites"})
+        assert response.status_code == 200, response.content
 
-            values = [row["title"] for row in response.data]
-            # sorted by title by default
-            assert values == ["General", "Dashboard 1", "Dashboard 2", "Dashboard 6", "Dashboard 7"]
+        values = [row["title"] for row in response.data]
+        # sorted by title by default
+        assert values == ["General", "Dashboard 1", "Dashboard 2", "Dashboard 6", "Dashboard 7"]
 
     def test_get_exclude_favorites_with_sort(self):
         user_1 = self.create_user(username="user_1")
@@ -469,14 +466,13 @@ def test_get_exclude_favorites_with_sort(self):
         dashboard_6.favorited_by = [user_2.id]
 
         self.login_as(user_1)
-        with self.feature("organizations:dashboards-favourite"):
-            response = self.client.get(
-                self.url, data={"filter": "excludeFavorites", "sort": "dateCreated"}
-            )
-            assert response.status_code == 200, response.content
+        response = self.client.get(
+            self.url, data={"filter": "excludeFavorites", "sort": "dateCreated"}
+        )
+        assert response.status_code == 200, response.content
 
-            values = [row["title"] for row in response.data]
-            assert values == ["General", "Dashboard 1", "Dashboard 2", "Dashboard 7", "Dashboard 6"]
+        values = [row["title"] for row in response.data]
+        assert values == ["General", "Dashboard 1", "Dashboard 2", "Dashboard 7", "Dashboard 6"]
 
     def test_pin_favorites_with_my_dashboards_sort(self):
         user_1 = self.create_user(username="user_1")
@@ -513,21 +509,20 @@ def test_pin_favorites_with_my_dashboards_sort(self):
         dashboard_E.favorited_by = [self.user.id]
         dashboard_C.favorited_by = [user_1.id]
 
-        with self.feature("organizations:dashboards-favourite"):
-            response = self.client.get(self.url, data={"sort": "mydashboards", "pin": "favorites"})
-            assert response.status_code == 200, response.content
-            values = [row["title"] for row in response.data]
-            assert values == [
-                # favorites
-                "Dashboard D",  # self.user's favorite
-                "Dashboard E",  # user_1's dashboard
-                "Dashboard B",  # user_1's dashboard
-                # other dashboards
-                "Dashboard A",  # self.user's dashboard
-                "Dashboard 2",  # self.user's dashboard
-                "Dashboard 1",  # self.user's dashboard
-                "Dashboard C",  # user_1's dashbaord
-            ]
+        response = self.client.get(self.url, data={"sort": "mydashboards", "pin": "favorites"})
+        assert response.status_code == 200, response.content
+        values = [row["title"] for row in response.data]
+        assert values == [
+            # favorites
+            "Dashboard D",  # self.user's favorite
+            "Dashboard E",  # user_1's dashboard
+            "Dashboard B",  # user_1's dashboard
+            # other dashboards
+            "Dashboard A",  # self.user's dashboard
+            "Dashboard 2",  # self.user's dashboard
+            "Dashboard 1",  # self.user's dashboard
+            "Dashboard C",  # user_1's dashbaord
+        ]
 
     def test_pin_favorites_with_my_date_created_sort(self):
         user_1 = self.create_user(username="user_1")
@@ -564,21 +559,20 @@ def test_pin_favorites_with_my_date_created_sort(self):
         dashboard_E.favorited_by = [self.user.id]
         dashboard_C.favorited_by = [user_1.id]
 
-        with self.feature("organizations:dashboards-favourite"):
-            response = self.client.get(self.url, data={"sort": "dateCreated", "pin": "favorites"})
-            assert response.status_code == 200, response.content
-            values = [row["title"] for row in response.data]
-            assert values == [
-                # favorites
-                "Dashboard B",
-                "Dashboard D",
-                "Dashboard E",
-                # other dashboards
-                "Dashboard 1",
-                "Dashboard 2",
-                "Dashboard A",
-                "Dashboard C",
-            ]
+        response = self.client.get(self.url, data={"sort": "dateCreated", "pin": "favorites"})
+        assert response.status_code == 200, response.content
+        values = [row["title"] for row in response.data]
+        assert values == [
+            # favorites
+            "Dashboard B",
+            "Dashboard D",
+            "Dashboard E",
+            # other dashboards
+            "Dashboard 1",
+            "Dashboard 2",
+            "Dashboard A",
+            "Dashboard C",
+        ]
 
     def test_post(self):
         response = self.do_request("post", self.url, data={"title": "Dashboard from Post"})
@@ -1445,16 +1439,15 @@ def test_dasboard_list_permissions_is_valid(self):
     def test_gets_dashboard_favorited_with_dashboard_list(self):
         self.dashboard.favorited_by = [self.user.id]
 
-        with self.feature({"organizations:dashboards-favourite": True}):
-            response = self.do_request("get", self.url)
-            assert response.status_code == 200, response.content
+        response = self.do_request("get", self.url)
+        assert response.status_code == 200, response.content
 
-            for dashboard in response.data:
-                assert "isFavorited" in dashboard
-            self.assert_equal_dashboards(self.dashboard, response.data[1])
-            assert response.data[1]["isFavorited"] is True
-            assert response.data[0]["isFavorited"] is False  # general template
-            assert response.data[2]["isFavorited"] is False  # dashboard_2 w/ no favorites set
+        for dashboard in response.data:
+            assert "isFavorited" in dashboard
+        self.assert_equal_dashboards(self.dashboard, response.data[1])
+        assert response.data[1]["isFavorited"] is True
+        assert response.data[0]["isFavorited"] is False  # general template
+        assert response.data[2]["isFavorited"] is False  # dashboard_2 w/ no favorites set
 
     def test_post_errors_widget_with_is_filter(self):
         data: dict[str, Any] = {