Skip to content

Commit c746f36

Browse files
authored
fix(plugin): dont throw if exec operation fails (#360)
* Dont throw on non-zero exit value * Swallow non-zero exit value * Update CHANGELOG
1 parent 1a49c4d commit c746f36

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Unreleased
44

5+
### Fixes
6+
7+
- Do not throw if exec operation fails ([#360](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/360))
8+
59
### Miscellaneous
610

711
- Update native android sdk name to `sentry.native.android.kmp` ([#353](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/353))

sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/DerivedDataPathValueSource.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ abstract class DerivedDataPathValueSource :
4141
)
4242
it.standardOutput = buildDirOutput
4343
it.errorOutput = errOutput
44+
it.isIgnoreExitValue = true
4445
}
4546

4647
if (execOperations.exitValue == 0) {

sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/ManualFrameworkPathSearchValueSource.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ abstract class ManualFrameworkPathSearchValueSource :
5050
)
5151
it.standardOutput = stdOutput
5252
it.errorOutput = errOutput
53+
it.isIgnoreExitValue = true
5354
}
5455

5556
val stringOutput = stdOutput.toString("UTF-8")

0 commit comments

Comments
 (0)