Wrong behaviour with LanguageSwitcher

[HoloBack]

Hi @rhukster,

my website has German as a default language and English as a second language.
When I have a page available in both languages, then languageswitcher and the hreflang links are working correctly.

When I create a page just in English, Grav creates a virtual link for German (Language N/A) even though there is no German page and then languageswitcher creates the virtual links which, of course, lead to 404.

So when I switch language, it leads to an virtual link of a page, that doesn't exist.
Same for the hreflang links - alternate and x-default links are created with that virtual link.

Is that a bug or how can be that behaviour changed?

All the best.

[pamtbaau]

@HoloBack, It is not really a LangSwitcher plugin issue, but it's how Grav core collections work.

Unfortunately, this is a known and longstanding issue. See Pages: Collection for secondary language contains dummy items for untranslated default language
#2985

As Mahagr suggested in that issue:

@pamtbaau I think the best thing to do is to filter blog pages if they are routable or not. Filtering is something that really needs to be done with Flex, too, as you may want to have page pointing to the other translations if you try to access it in a language that doesn't exist (it doesn't mean that the page is not there -- it is just not published using your current language).

Taking the Quark navigation macro (templates/macros/macros.html.twig) as an example, the following change might solve your issue:

{% for p in page.children.visible %}
  {% if p.routable %}            <== Added
    ... etc
  {% endif %}                    <== Added
{% endfor %}

[HoloBack]

Thank you @pamtbaau. This means, that in my case I have to change the code of the languageswitcher and filter the collection according to your example.

[HoloBack]

Maybe interesting for other people, the langswitcher works correctly with pages existing in only one language, as soon as you set the correct value in the plugin settings.

Furthermore I just needed to change the langswitcher href module:

{% set language_obj = grav.language %}
{% for language in langswitcher.languages %}
{% if langswitcher.translated_routes[language] %}
{% set lang_url = langswitcher.translated_routes[language] ~ page.urlExtension %}
{% else %}
{% set base_lang_url = base_url_simple ~ grav.language.getLanguageURLPrefix(language) %}
{% set lang_url = base_lang_url ~ langswitcher.page_route ~ page.urlExtension %}
{% endif %}

{% set href_url = uri.base ~ lang_url ~ uri.params ~ (uri.query|length > 1 ? '?' ~ uri.query) %}

{% set translated_page = langswitcher.translated_pages[language] %}
{% if translated_page or translated_page.published %}
	{% if (language_obj.default == language and config.languages.include_default_lang == false) %}
	<link rel="alternate" hreflang="x-default" href="{{ href_url }}" />
	{% endif %}
	<link rel="alternate" hreflang="{{ html_lang[language|lower] }}" href="{{ href_url }}" />
{% endif %}

{% endfor %}