Skip to content

Commit 65641ec

Browse files
committed
Cleaned out some dead code
1 parent eed37d5 commit 65641ec

File tree

2 files changed

+2
-38
lines changed

2 files changed

+2
-38
lines changed

pygetdns.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,6 @@ struct getdns_dict *extensions_to_getdnsdict(PyDictObject *);
149149
PyObject *decode_getdns_response(struct getdns_dict *);
150150
PyObject *decode_getdns_replies_tree_response(struct getdns_dict *response);
151151
PyObject *getFullResponse(struct getdns_dict *dict);
152-
char *reverse_address(struct getdns_bindata *address_data);
153-
PyObject *context_fd(PyObject *self, PyObject *args, PyObject *keywds);
154-
PyObject *context_get_num_pending_requests(PyObject *self, PyObject *args, PyObject *keywds);
155-
PyObject *context_process_async(PyObject *self, PyObject *args, PyObject *keywds);
156152
getdns_dict *getdnsify_addressdict(PyObject *pydict);
153+
157154
#endif /* PYGETDNS_H */

pygetdns_util.c

Lines changed: 1 addition & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ extensions_to_getdnsdict(PyDictObject *pydict)
118118
struct getdns_bindata *option_data;
119119
struct getdns_dict *tmpoptions_list_dict; /* a dict to hold add_opt_parameters[options] stuff */
120120

121-
if (!PyDict_Check(pydict)) {
121+
if ((!pydict) || (!PyDict_Check(pydict))) {
122122
PyErr_SetString(getdns_error, "Expected dict, didn't get one");
123123
return NULL;
124124
}
@@ -633,39 +633,6 @@ void error_exit(char* msg, getdns_return_t ret)
633633

634634

635635

636-
/**
637-
* reverse an IP address for PTR lookup
638-
* @param address_data IP address to reverse
639-
* @return NULL on allocation failure
640-
* @return reversed string on success, caller must free storage via call to free()
641-
*/
642-
char *
643-
reverse_address(struct getdns_bindata *address_data)
644-
{
645-
ldns_rdf *addr_rdf;
646-
ldns_rdf *rev_rdf;
647-
char *rev_str;
648-
649-
if (address_data->size == 4)
650-
addr_rdf = ldns_rdf_new(LDNS_RDF_TYPE_A, 4, address_data->data);
651-
else if (address_data->size == 16)
652-
addr_rdf = ldns_rdf_new(LDNS_RDF_TYPE_AAAA, 16, address_data->data);
653-
else
654-
return NULL;
655-
if (!addr_rdf)
656-
return NULL;
657-
658-
rev_rdf = ldns_rdf_address_reverse(addr_rdf);
659-
ldns_rdf_free(addr_rdf);
660-
if (!rev_rdf)
661-
return NULL;
662-
663-
rev_str = ldns_rdf2str(rev_rdf);
664-
ldns_rdf_deep_free(rev_rdf);
665-
return rev_str;
666-
}
667-
668-
669636
// Code to display the entire response.
670637
// answer_type
671638
// canonical_name

0 commit comments

Comments
 (0)