@@ -118,7 +118,7 @@ extensions_to_getdnsdict(PyDictObject *pydict)
118
118
struct getdns_bindata * option_data ;
119
119
struct getdns_dict * tmpoptions_list_dict ; /* a dict to hold add_opt_parameters[options] stuff */
120
120
121
- if (! PyDict_Check (pydict )) {
121
+ if ((! pydict ) || (! PyDict_Check (pydict ) )) {
122
122
PyErr_SetString (getdns_error , "Expected dict, didn't get one" );
123
123
return NULL ;
124
124
}
@@ -633,39 +633,6 @@ void error_exit(char* msg, getdns_return_t ret)
633
633
634
634
635
635
636
- /**
637
- * reverse an IP address for PTR lookup
638
- * @param address_data IP address to reverse
639
- * @return NULL on allocation failure
640
- * @return reversed string on success, caller must free storage via call to free()
641
- */
642
- char *
643
- reverse_address (struct getdns_bindata * address_data )
644
- {
645
- ldns_rdf * addr_rdf ;
646
- ldns_rdf * rev_rdf ;
647
- char * rev_str ;
648
-
649
- if (address_data -> size == 4 )
650
- addr_rdf = ldns_rdf_new (LDNS_RDF_TYPE_A , 4 , address_data -> data );
651
- else if (address_data -> size == 16 )
652
- addr_rdf = ldns_rdf_new (LDNS_RDF_TYPE_AAAA , 16 , address_data -> data );
653
- else
654
- return NULL ;
655
- if (!addr_rdf )
656
- return NULL ;
657
-
658
- rev_rdf = ldns_rdf_address_reverse (addr_rdf );
659
- ldns_rdf_free (addr_rdf );
660
- if (!rev_rdf )
661
- return NULL ;
662
-
663
- rev_str = ldns_rdf2str (rev_rdf );
664
- ldns_rdf_deep_free (rev_rdf );
665
- return rev_str ;
666
- }
667
-
668
-
669
636
// Code to display the entire response.
670
637
// answer_type
671
638
// canonical_name
0 commit comments