refactor(test): make test attendance deterministic

Author: ruthra-kumar

hrms/hr/doctype/attendance/test_attendance.py

@@ -35,13 +35,7 @@
 
 class TestAttendance(HRMSTestSuite):
 	def setUp(self):
-		from hrms.payroll.doctype.salary_slip.test_salary_slip import make_holiday_list
-
-		from_date = get_year_start(add_months(getdate(), -1))
-		to_date = get_year_ending(getdate())
-		self.holiday_list = make_holiday_list(from_date=from_date, to_date=to_date)
-		frappe.db.delete("Attendance")
-		frappe.db.delete("Employee Checkin")
+		self.holiday_list = "Salary Slip Test Holiday List"
 
 	def test_duplicate_attendance(self):
 		employee = make_employee("test_duplicate_attendance@example.com", company="_Test Company")
@@ -144,7 +138,7 @@ def test_allow_attendance_with_different_shifts(self):
 		).insert()
 
 	def test_mark_absent(self):
-		employee = make_employee("test_mark_absent@example.com")
+		employee = make_employee("test_mark_absent@example.com", company="_Test Company")
 		date = nowdate()
 
 		attendance = mark_attendance(employee, date, "Absent")
@@ -158,7 +152,9 @@ def test_unmarked_days(self):
 		attendance_date = add_days(first_sunday, 1)
 
 		employee = make_employee(
-			"test_unmarked_days@example.com", date_of_joining=add_days(attendance_date, -1)
+			"test_unmarked_days@example.com",
+			date_of_joining=add_days(attendance_date, -1),
+			company="_Test Company",
 		)
 		frappe.db.set_value("Employee", employee, "holiday_list", self.holiday_list)
 
@@ -182,7 +178,9 @@ def test_unmarked_days_excluding_holidays(self):
 		attendance_date = add_days(first_sunday, 1)
 
 		employee = make_employee(
-			"test_unmarked_days@example.com", date_of_joining=add_days(attendance_date, -1)
+			"test_unmarked_days@example.com",
+			date_of_joining=add_days(attendance_date, -1),
+			company="_Test Company",
 		)
 
 		mark_attendance(employee, attendance_date, "Present")
@@ -228,7 +226,10 @@ def test_unmarked_days_as_per_joining_and_relieving_dates(self):
 		doj = add_days(date, 1)
 		relieving_date = add_days(date, 5)
 		employee = make_employee(
-			"test_unmarked_days_as_per_doj@example.com", date_of_joining=doj, relieving_date=relieving_date
+			"test_unmarked_days_as_per_doj@example.com",
+			date_of_joining=doj,
+			relieving_date=relieving_date,
+			company="_Test Company",
 		)
 
 		frappe.db.set_value("Employee", employee, "holiday_list", self.holiday_list)
@@ -270,14 +271,14 @@ def test_duplicate_attendance_when_created_from_checkins_and_tool(self):
 		self.assertEqual(len(attendances), 1)
 
 	def test_get_events_returns_attendance(self):
-		employee = make_employee("calendar.user@example.com", company="_Test Company")
+		employee = frappe.get_doc("Employee", {"first_name": "_Test Employee"})
 
-		attendance_name = mark_attendance(employee, getdate(), status="Present")
+		attendance_name = mark_attendance(employee.name, getdate(), status="Present")
 		attendance = frappe.get_value("Attendance", attendance_name, "status")
 
 		self.assertEqual(attendance, "Present")
 
-		frappe.set_user("calendar.user@example.com")
+		frappe.set_user(employee.user_id)
 		try:
 			events = get_events(start=getdate(), end=getdate())
 		finally:
@@ -289,9 +290,6 @@ def test_get_events_returns_attendance(self):
 		self.assertEqual(attendance_events[0].get("status"), "Present")
 		self.assertEqual(
 			attendance_events[0].get("employee_name"),
-			frappe.db.get_value("Employee", employee, "employee_name"),
+			frappe.db.get_value("Employee", employee.name, "employee_name"),
 		)
 		self.assertEqual(attendance_events[0].get("attendance_date"), getdate())
-
-	def tearDown(self):
-		frappe.db.rollback()

hrms/hr/doctype/shift_type/shift_type.py

@@ -216,7 +216,8 @@ def _process(self, logs):
 			)
 
 		# commit after processing checkin logs to avoid losing progress
-		frappe.db.commit()  # nosemgrep
+		if not frappe.in_test:
+			frappe.db.commit()  # nosemgrep
 
 		assigned_employees = self.get_assigned_employees(self.process_attendance_after, True)
 		# mark absent in batches & commit to avoid losing progress since this tries to process remaining attendance
@@ -226,7 +227,8 @@ def _process(self, logs):
 				self.mark_absent_for_dates_with_no_attendance(employee)
 				self.mark_absent_for_half_day_dates(employee)
 
-			frappe.db.commit()  # nosemgrep
+			if not frappe.in_test:
+				frappe.db.commit()  # nosemgrep
 
 	def is_half_holiday(self, employee, attendance_date):
 		holiday_list = self.get_holiday_list(employee, attendance_date)

hrms/tests/utils.py

@@ -21,6 +21,9 @@ def make_persistent_master_data(cls):
 		cls.make_holiday_list_assignment()
 		cls.update_system_settings()
 		cls.update_email_account_settings()
+		# TODO: clean up
+		if frappe.db.get_value("Holiday List Assignment", {"assigned_to": "_Test Company"}, "docstatus") == 0:
+			frappe.get_doc("Holiday List Assignment", {"assigned_to": "_Test Company"}).submit()
 		frappe.db.commit()
 
 	@classmethod