Update lints, rename local variables with underscrore

MatthaiosSait · MatthaiosSait · commit 3538c25d4108 · 2023-06-02T14:49:20.000+02:00
diff --git a/arcgis_map/analysis_options.yaml b/arcgis_map/analysis_options.yaml
@@ -1 +1 @@
-include: package:tapped_lints/flutter.yaml
+include: package:flutter_lints/flutter.yaml
diff --git a/arcgis_map/example/pubspec.lock b/arcgis_map/example/pubspec.lock
@@ -142,10 +142,10 @@ packages:
     dependency: "direct dev"
     description:
       name: lint
-      sha256: "4a539aa34ec5721a2c7574ae2ca0336738ea4adc2a34887d54b7596310b33c85"
+      sha256: f4bd4dbaa39f4ae8836f2d1275f2f32bc68b3a8cce0a0735dd1f7a601f06682a
       url: "https://pub.dev"
     source: hosted
-    version: "1.10.0"
+    version: "2.1.2"
   matcher:
     dependency: transitive
     description:
@@ -248,4 +248,4 @@ packages:
     source: hosted
     version: "2.1.4"
 sdks:
-  dart: ">=3.0.0-0 <4.0.0"
+  dart: ">=3.0.0 <4.0.0"
diff --git a/arcgis_map/example/pubspec.yaml b/arcgis_map/example/pubspec.yaml
@@ -6,7 +6,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
 version: 1.0.0+1
 
 environment:
-  sdk: ">=2.15.0 <3.0.0"
+  sdk: ">=2.15.0 <4.0.0"
 
 dependencies:
   arcgis_map:
@@ -35,7 +35,7 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
-  lint: ^1.0.0
+  lint: ^2.0.0
 
 # Used to work locally on the package
 dependency_overrides:
diff --git a/arcgis_map/pubspec.yaml b/arcgis_map/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.9.0
 publish_to: none
 
 environment:
-  sdk: ">=2.15.0 <3.0.0"
+  sdk: ">=2.15.0 <4.0.0"
 
 dependencies:
   arcgis_map_android:
@@ -44,7 +44,3 @@ dependency_overrides:
 
 dev_dependencies:
   flutter_lints: ^2.0.1
-  tapped_lints:
-    git:
-      url: https://github.com/tappeddev/tapped_lints.git
-      ref: master
diff --git a/arcgis_map_android/analysis_options.yaml b/arcgis_map_android/analysis_options.yaml
@@ -1,2 +1,2 @@
-include: package:tapped_lints/flutter.yaml
+include: package:flutter_lints/flutter.yaml
 
diff --git a/arcgis_map_android/pubspec.yaml b/arcgis_map_android/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.9.0
 publish_to: none
 
 environment:
-  sdk: ">=2.15.0 <3.0.0"
+  sdk: ">=2.15.0 <4.0.0"
 
 dependencies:
   arcgis_map_platform_interface:
@@ -24,10 +24,6 @@ dependencies:
 
 dev_dependencies:
   flutter_lints: ^2.0.1
-  tapped_lints:
-    git:
-      url: https://github.com/tappeddev/tapped_lints.git
-      ref: master
 
 # Used to work locally on the package
 dependency_overrides:
diff --git a/arcgis_map_ios/analysis_options.yaml b/arcgis_map_ios/analysis_options.yaml
@@ -1,2 +1,2 @@
-include: package:tapped_lints/flutter.yaml
+include: package:flutter_lints/flutter.yaml
 
diff --git a/arcgis_map_ios/pubspec.yaml b/arcgis_map_ios/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.9.0
 publish_to: none
 
 environment:
-  sdk: ">=2.15.0 <3.0.0"
+  sdk: ">=2.15.0 <4.0.0"
 
 dependencies:
   arcgis_map_platform_interface:
@@ -24,10 +24,6 @@ dependencies:
 
 dev_dependencies:
   flutter_lints: ^2.0.1
-  tapped_lints:
-    git:
-      url: https://github.com/tappeddev/tapped_lints.git
-      ref: master
 
 # Used to work locally on the package
 dependency_overrides:
diff --git a/arcgis_map_method_channel/analysis_options.yaml b/arcgis_map_method_channel/analysis_options.yaml
@@ -1,2 +1,2 @@
-include: package:tapped_lints/flutter.yaml
+include: package:flutter_lints/flutter.yaml
 
diff --git a/arcgis_map_method_channel/pubspec.yaml b/arcgis_map_method_channel/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.9.0
 publish_to: none
 
 environment:
-  sdk: ">=2.15.0 <3.0.0"
+  sdk: ">=2.15.0 <4.0.0"
 
 dependencies:
   arcgis_map_platform_interface:
@@ -19,10 +19,6 @@ dependencies:
 
 dev_dependencies:
   flutter_lints: ^2.0.1
-  tapped_lints:
-    git:
-      url: https://github.com/tappeddev/tapped_lints.git
-      ref: master
 
 # Used to work locally on the package
 dependency_overrides:
diff --git a/arcgis_map_platform_interface/analysis_options.yaml b/arcgis_map_platform_interface/analysis_options.yaml
@@ -1,2 +1,2 @@
-include: package:tapped_lints/flutter.yaml
+include: package:flutter_lints/flutter.yaml
 
diff --git a/arcgis_map_platform_interface/pubspec.yaml b/arcgis_map_platform_interface/pubspec.yaml
@@ -3,7 +3,7 @@ description: Esri ArcGIS Flutter platform interface.
 version: 0.9.0
 
 environment:
-  sdk: ">=2.15.0 <3.0.0"
+  sdk: ">=2.15.0 <4.0.0"
 
 dependencies:
   flutter:
@@ -14,9 +14,5 @@ dependencies:
 
 dev_dependencies:
   flutter_lints: ^2.0.1
-  tapped_lints:
-    git:
-      url: https://github.com/tappeddev/tapped_lints.git
-      ref: master
 
 flutter:
diff --git a/arcgis_map_web/lib/src/arcgis_map_web_controller.dart b/arcgis_map_web/lib/src/arcgis_map_web_controller.dart
@@ -96,13 +96,13 @@ class ArcgisMapWebController {
 
     // If "hideDefaultZoomButtons" is true, do not show the default zoom buttons.
     // If "hideAttribution" is true, the attribution is not shown.
-    final _hideDefaultZoomButtons = _mapOptions.hideDefaultZoomButtons;
-    final _hideAttribution = _mapOptions.hideAttribution;
-    if (_hideDefaultZoomButtons == true && _hideAttribution == true) {
+    final hideDefaultZoomButtons = _mapOptions.hideDefaultZoomButtons;
+    final hideAttribution = _mapOptions.hideAttribution;
+    if (hideDefaultZoomButtons == true && hideAttribution == true) {
       _view!.ui.components = [];
-    } else if (_hideDefaultZoomButtons == true && _hideAttribution == false) {
+    } else if (hideDefaultZoomButtons == true && hideAttribution == false) {
       _view!.ui.components = ["attribution"];
-    } else if (_hideDefaultZoomButtons == false && _hideAttribution == true) {
+    } else if (hideDefaultZoomButtons == false && hideAttribution == true) {
       _view!.ui.components = ["zoom"];
     }
 
diff --git a/arcgis_map_web/lib/src/feature_layer_controller.dart b/arcgis_map_web/lib/src/feature_layer_controller.dart
@@ -105,9 +105,9 @@ class FeatureLayerController {
 
     featureLayers.add(layer);
 
-    final FeatureLayer _featureLayer = FeatureLayer(id: layer.id);
+    final FeatureLayer featureLayer = FeatureLayer(id: layer.id);
 
-    return _featureLayer;
+    return featureLayer;
   }
 
   /// Check if the polygon with the [polygonId] contains the point with the
@@ -140,18 +140,18 @@ class FeatureLayerController {
     // In order to stop watching on the zoom when the stream is canceled in Dart,
     // a handle is assigned to the watch method, and it is removed when the Stream is canceled.
     dynamic handle;
-    final StreamController<double> _zoomController =
+    final StreamController<double> zoomController =
         StreamController(onCancel: () => handle.remove());
     handle = view.watch(
       'zoom',
       allowInterop(
         (newValue, _, __, ___) {
-          _zoomController.add(newValue as double);
+          zoomController.add(newValue as double);
         },
       ),
     );
 
-    return _zoomController.stream;
+    return zoomController.stream;
   }
 
   /// A stream for the 'center' attributes
@@ -162,7 +162,7 @@ class FeatureLayerController {
     // a handle is assigned to the watch method, and it is removed when the Stream is canceled.
     dynamic handle;
 
-    final StreamController<LatLng> _positionController = StreamController(
+    final StreamController<LatLng> positionController = StreamController(
       onCancel: () {
         handle.remove();
       },
@@ -173,17 +173,17 @@ class FeatureLayerController {
       allowInterop(
         (newValue, _, __, ___) {
           if (newValue != null) {
-            final _centerViewPoint = LatLng(
+            final centerViewPoint = LatLng(
               newValue.latitude as double,
               newValue.longitude as double,
             );
-            _positionController.add(_centerViewPoint);
+            positionController.add(centerViewPoint);
           }
         },
       ),
     );
 
-    return _positionController.stream;
+    return positionController.stream;
   }
 
   /// Return a Stream of Lists with the ids of the Graphics, that are visible in the current view.
@@ -193,7 +193,7 @@ class FeatureLayerController {
   Stream<List<String>> visibleGraphics(JsMapView view) {
     List<String> graphicIdsInViewBuffer = <String>[];
     dynamic handle;
-    final StreamController<List<String>> _visibleGraphicsController =
+    final StreamController<List<String>> visibleGraphicsController =
         StreamController(
       onCancel: () {
         handle?.remove();
@@ -214,12 +214,12 @@ class FeatureLayerController {
           }),
         );
         if (!listEquals(graphicIdsInViewBuffer, graphicIdsInView)) {
-          _visibleGraphicsController.add(graphicIdsInView);
+          visibleGraphicsController.add(graphicIdsInView);
           graphicIdsInViewBuffer = graphicIdsInView;
         }
       }),
     );
-    return _visibleGraphicsController.stream;
+    return visibleGraphicsController.stream;
   }
 
   /// Return a List with the ids of the Graphics, that are visible in the current view, on demand.
@@ -249,7 +249,7 @@ class FeatureLayerController {
     // In order to stop watching on the extent when the stream is canceled in Dart,
     // a handle is assigned to the watch method, and it is removed when the Stream is canceled.
     dynamic handle;
-    final StreamController<BoundingBox> _boundsController = StreamController(
+    final StreamController<BoundingBox> boundsController = StreamController(
       onCancel: () {
         handle?.remove();
       },
@@ -278,7 +278,7 @@ class FeatureLayerController {
             y: yDistanceFromViewCenter,
           );
 
-          _boundsController.add(
+          boundsController.add(
             BoundingBox(
               height: newValue.height,
               width: newValue.width,
@@ -289,7 +289,7 @@ class FeatureLayerController {
         }
       }),
     );
-    return _boundsController.stream;
+    return boundsController.stream;
   }
 
   /// Get the attribution text as a [Stream]
@@ -328,8 +328,8 @@ class FeatureLayerController {
 
   /// Changes the mouse cursor to a specified [SystemMouseCursor].
   void setMouseCursor(String mapId, SystemMouseCursor cursor) {
-    final _cursor = cursor.kind == 'basic' ? 'default' : 'pointer';
-    document.getElementById(mapId)?.style.cursor = _cursor;
+    final newCursor = cursor.kind == 'basic' ? 'default' : 'pointer';
+    document.getElementById(mapId)?.style.cursor = newCursor;
   }
 
   /// Updates the graphic representation of an existing [Graphic] with a the [Symbol].
diff --git a/arcgis_map_web/pubspec.lock b/arcgis_map_web/pubspec.lock
@@ -70,10 +70,10 @@ packages:
     dependency: "direct dev"
     description:
       name: lint
-      sha256: "29e4570fcef31050c9ca1873f27dd881f462717a1d786d0767ccc19296efd51f"
+      sha256: f4bd4dbaa39f4ae8836f2d1275f2f32bc68b3a8cce0a0735dd1f7a601f06682a
       url: "https://pub.dev"
     source: hosted
-    version: "1.7.2"
+    version: "2.1.2"
   material_color_utilities:
     dependency: transitive
     description:
@@ -120,4 +120,4 @@ packages:
     source: hosted
     version: "2.1.4"
 sdks:
-  dart: ">=3.0.0-0 <4.0.0"
+  dart: ">=3.0.0 <4.0.0"

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-include: package:tapped_lints/flutter.yaml`
	`1`	`+include: package:flutter_lints/flutter.yaml`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`		`-include: package:tapped_lints/flutter.yaml`
	`1`	`+include: package:flutter_lints/flutter.yaml`
`2`	`2`