Add 'explicit' to header files (#29741)

Author: zanderso

benchmarking/benchmarking.h

@@ -11,7 +11,7 @@ namespace benchmarking {
 
 class ScopedPauseTiming {
  public:
-  ScopedPauseTiming(::benchmark::State& state, bool enabled = true)
+  explicit ScopedPauseTiming(::benchmark::State& state, bool enabled = true)
       : state_(state), enabled_(enabled) {
     if (enabled_) {
       state_.PauseTiming();

common/graphics/gl_context_switch.h

@@ -57,7 +57,7 @@ class GLContextResult {
   bool GetResult();
 
  protected:
-  GLContextResult(bool static_result);
+  explicit GLContextResult(bool static_result);
   bool result_;
 
   FML_DISALLOW_COPY_AND_ASSIGN(GLContextResult);
@@ -78,7 +78,7 @@ class GLContextDefaultResult : public GLContextResult {
   ///
   /// @param  static_result a static value that will be returned from
   /// |GetResult|
-  GLContextDefaultResult(bool static_result);
+  explicit GLContextDefaultResult(bool static_result);
 
   ~GLContextDefaultResult() override;
 
@@ -99,7 +99,7 @@ class GLContextSwitch final : public GLContextResult {
   /// @param  context The context that is going to be set as the current
   /// context. The |GLContextSwitch| should not outlive the owner of the gl
   /// context wrapped inside the `context`.
-  GLContextSwitch(std::unique_ptr<SwitchableGLContext> context);
+  explicit GLContextSwitch(std::unique_ptr<SwitchableGLContext> context);
 
   ~GLContextSwitch() override;
 

common/graphics/persistent_cache.h

@@ -59,7 +59,7 @@ class PersistentCache : public GrContextOptions::PersistentCache {
     static const uint32_t kSignature = 0xA869593F;
     static const uint32_t kVersion1 = 1;
 
-    CacheObjectHeader(uint32_t p_key_size) : key_size(p_key_size) {}
+    explicit CacheObjectHeader(uint32_t p_key_size) : key_size(p_key_size) {}
 
     uint32_t signature = kSignature;
     uint32_t version = kVersion1;
@@ -163,7 +163,7 @@ class PersistentCache : public GrContextOptions::PersistentCache {
 
   bool IsValid() const;
 
-  PersistentCache(bool read_only = false);
+  explicit PersistentCache(bool read_only = false);
 
   // |GrContextOptions::PersistentCache|
   void store(const SkData& key, const SkData& data) override;

flow/compositor_context.h

@@ -138,7 +138,8 @@ class CompositorContext {
     FML_DISALLOW_COPY_AND_ASSIGN(ScopedFrame);
   };
 
-  CompositorContext(fml::Milliseconds frame_budget = fml::kDefaultFrameBudget);
+  explicit CompositorContext(
+      fml::Milliseconds frame_budget = fml::kDefaultFrameBudget);
 
   virtual ~CompositorContext();
 

flow/display_list.cc

@@ -105,7 +105,7 @@ DEFINE_SET_ENUM_OP(Join)
 struct SetStyleOp final : DLOp {
   static const auto kType = DisplayListOpType::kSetStyle;
 
-  SetStyleOp(SkPaint::Style style) : style(style) {}
+  explicit SetStyleOp(SkPaint::Style style) : style(style) {}
 
   const SkPaint::Style style;
 
@@ -115,7 +115,7 @@ struct SetStyleOp final : DLOp {
 struct SetStrokeWidthOp final : DLOp {
   static const auto kType = DisplayListOpType::kSetStrokeWidth;
 
-  SetStrokeWidthOp(SkScalar width) : width(width) {}
+  explicit SetStrokeWidthOp(SkScalar width) : width(width) {}
 
   const SkScalar width;
 
@@ -127,7 +127,7 @@ struct SetStrokeWidthOp final : DLOp {
 struct SetStrokeMiterOp final : DLOp {
   static const auto kType = DisplayListOpType::kSetStrokeMiter;
 
-  SetStrokeMiterOp(SkScalar limit) : limit(limit) {}
+  explicit SetStrokeMiterOp(SkScalar limit) : limit(limit) {}
 
   const SkScalar limit;
 
@@ -140,7 +140,7 @@ struct SetStrokeMiterOp final : DLOp {
 struct SetColorOp final : DLOp {
   static const auto kType = DisplayListOpType::kSetColor;
 
-  SetColorOp(SkColor color) : color(color) {}
+  explicit SetColorOp(SkColor color) : color(color) {}
 
   const SkColor color;
 
@@ -150,7 +150,7 @@ struct SetColorOp final : DLOp {
 struct SetBlendModeOp final : DLOp {
   static const auto kType = DisplayListOpType::kSetBlendMode;
 
-  SetBlendModeOp(SkBlendMode mode) : mode(mode) {}
+  explicit SetBlendModeOp(SkBlendMode mode) : mode(mode) {}
 
   const SkBlendMode mode;
 
@@ -224,7 +224,7 @@ struct SaveOp final : DLOp {
 struct SaveLayerOp final : DLOp {
   static const auto kType = DisplayListOpType::kSaveLayer;
 
-  SaveLayerOp(bool with_paint) : with_paint(with_paint) {}
+  explicit SaveLayerOp(bool with_paint) : with_paint(with_paint) {}
 
   bool with_paint;
 
@@ -283,7 +283,7 @@ struct ScaleOp final : DLOp {
 struct RotateOp final : DLOp {
   static const auto kType = DisplayListOpType::kRotate;
 
-  RotateOp(SkScalar degrees) : degrees(degrees) {}
+  explicit RotateOp(SkScalar degrees) : degrees(degrees) {}
 
   const SkScalar degrees;
 
@@ -454,7 +454,7 @@ DEFINE_DRAW_1ARG_OP(RRect, SkRRect, rrect)
 struct DrawPathOp final : DLOp {
   static const auto kType = DisplayListOpType::kDrawPath;
 
-  DrawPathOp(SkPath path) : path(path) {}
+  explicit DrawPathOp(SkPath path) : path(path) {}
 
   const SkPath path;
 
@@ -804,7 +804,7 @@ struct DrawSkPictureMatrixOp final : DLOp {
 struct DrawDisplayListOp final : DLOp {
   static const auto kType = DisplayListOpType::kDrawDisplayList;
 
-  DrawDisplayListOp(const sk_sp<DisplayList> display_list)
+  explicit DrawDisplayListOp(const sk_sp<DisplayList> display_list)
       : display_list(std::move(display_list)) {}
 
   sk_sp<DisplayList> display_list;

flow/display_list.h

@@ -747,7 +747,7 @@ class DisplayListOpFlags : DisplayListFlags {
 // the DisplayListCanvasRecorder class.
 class DisplayListBuilder final : public virtual Dispatcher, public SkRefCnt {
  public:
-  DisplayListBuilder(const SkRect& cull_rect = kMaxCullRect_);
+  explicit DisplayListBuilder(const SkRect& cull_rect = kMaxCullRect_);
   ~DisplayListBuilder();
 
   void setAntiAlias(bool aa) override {

flow/display_list_canvas.h

@@ -27,7 +27,7 @@ namespace flutter {
 class DisplayListCanvasDispatcher : public virtual Dispatcher,
                                     public SkPaintDispatchHelper {
  public:
-  DisplayListCanvasDispatcher(SkCanvas* canvas) : canvas_(canvas) {}
+  explicit DisplayListCanvasDispatcher(SkCanvas* canvas) : canvas_(canvas) {}
 
   void save() override;
   void restore() override;
@@ -123,7 +123,7 @@ class DisplayListCanvasRecorder
       public SkRefCnt,
       DisplayListOpFlags {
  public:
-  DisplayListCanvasRecorder(const SkRect& bounds);
+  explicit DisplayListCanvasRecorder(const SkRect& bounds);
 
   const sk_sp<DisplayListBuilder> builder() { return builder_; }
 

flow/display_list_utils.h

@@ -199,7 +199,7 @@ class ClipBoundsDispatchHelper : public virtual Dispatcher,
  public:
   ClipBoundsDispatchHelper() : ClipBoundsDispatchHelper(nullptr) {}
 
-  ClipBoundsDispatchHelper(const SkRect* cull_rect)
+  explicit ClipBoundsDispatchHelper(const SkRect* cull_rect)
       : has_clip_(cull_rect),
         bounds_(cull_rect && !cull_rect->isEmpty() ? *cull_rect
                                                    : SkRect::MakeEmpty()) {}
@@ -279,7 +279,7 @@ class DisplayListBoundsCalculator final
   // queried using |isUnbounded| if an alternate plan is available
   // for such cases.
   // The flag should never be set if a cull_rect is provided.
-  DisplayListBoundsCalculator(const SkRect* cull_rect = nullptr);
+  explicit DisplayListBoundsCalculator(const SkRect* cull_rect = nullptr);
 
   void setStrokeCap(SkPaint::Cap cap) override;
   void setStrokeJoin(SkPaint::Join join) override;
@@ -403,7 +403,8 @@ class DisplayListBoundsCalculator final
     // the stack.
     // Some layers may substitute their own accumulator to compute
     // their own local bounds while they are on the stack.
-    LayerData(BoundsAccumulator* outer) : outer_(outer), is_unbounded_(false) {}
+    explicit LayerData(BoundsAccumulator* outer)
+        : outer_(outer), is_unbounded_(false) {}
     virtual ~LayerData() = default;
 
     // The accumulator to use while this layer is put in play by

flow/frame_timings.h

@@ -41,7 +41,7 @@ class FrameTimingsRecorder {
   FrameTimingsRecorder();
 
   /// Constructor with a pre-populated frame number.
-  FrameTimingsRecorder(uint64_t frame_number);
+  explicit FrameTimingsRecorder(uint64_t frame_number);
 
   ~FrameTimingsRecorder();
 

flow/instrumentation.h

@@ -16,7 +16,7 @@ namespace flutter {
 
 class Stopwatch {
  public:
-  Stopwatch(fml::Milliseconds frame_budget = fml::kDefaultFrameBudget);
+  explicit Stopwatch(fml::Milliseconds frame_budget = fml::kDefaultFrameBudget);
 
   ~Stopwatch();
 

flow/layers/clip_path_layer.h

@@ -11,7 +11,8 @@ namespace flutter {
 
 class ClipPathLayer : public ContainerLayer {
  public:
-  ClipPathLayer(const SkPath& clip_path, Clip clip_behavior = Clip::antiAlias);
+  explicit ClipPathLayer(const SkPath& clip_path,
+                         Clip clip_behavior = Clip::antiAlias);
 
   void Diff(DiffContext* context, const Layer* old_layer) override;
 

flow/layers/color_filter_layer.h

@@ -12,7 +12,7 @@ namespace flutter {
 
 class ColorFilterLayer : public ContainerLayer {
  public:
-  ColorFilterLayer(sk_sp<SkColorFilter> filter);
+  explicit ColorFilterLayer(sk_sp<SkColorFilter> filter);
 
   void Diff(DiffContext* context, const Layer* old_layer) override;
 

flow/layers/image_filter_layer.h

@@ -12,7 +12,7 @@ namespace flutter {
 
 class ImageFilterLayer : public MergedContainerLayer {
  public:
-  ImageFilterLayer(sk_sp<SkImageFilter> filter);
+  explicit ImageFilterLayer(sk_sp<SkImageFilter> filter);
 
   void Diff(DiffContext* context, const Layer* old_layer) override;
 

flow/layers/transform_layer.h

@@ -13,7 +13,7 @@ namespace flutter {
 // at all. Hence |set_transform| must be called with an initialized SkMatrix.
 class TransformLayer : public ContainerLayer {
  public:
-  TransformLayer(const SkMatrix& transform);
+  explicit TransformLayer(const SkMatrix& transform);
 
   void Diff(DiffContext* context, const Layer* old_layer) override;
 

flow/testing/gl_context_switch_test.h

@@ -20,7 +20,7 @@ class GLContextSwitchTest : public ::testing::Test {
 /// The renderer context used for testing
 class TestSwitchableGLContext : public SwitchableGLContext {
  public:
-  TestSwitchableGLContext(int context);
+  explicit TestSwitchableGLContext(int context);
 
   ~TestSwitchableGLContext() override;
 

flow/testing/mock_layer.h

@@ -16,10 +16,10 @@ namespace testing {
 // verify the data against expected values.
 class MockLayer : public Layer {
  public:
-  MockLayer(SkPath path,
-            SkPaint paint = SkPaint(),
-            bool fake_has_platform_view = false,
-            bool fake_reads_surface = false);
+  explicit MockLayer(SkPath path,
+                     SkPaint paint = SkPaint(),
+                     bool fake_has_platform_view = false,
+                     bool fake_reads_surface = false);
 
   void Preroll(PrerollContext* context, const SkMatrix& matrix) override;
   void Paint(PaintContext& context) const override;

flow/testing/mock_raster_cache.h

@@ -24,7 +24,7 @@ namespace testing {
  */
 class MockRasterCacheResult : public RasterCacheResult {
  public:
-  MockRasterCacheResult(SkIRect device_rect);
+  explicit MockRasterCacheResult(SkIRect device_rect);
 
   void draw(SkCanvas& canvas, const SkPaint* paint = nullptr) const override{};
 

fml/closure.h

@@ -33,7 +33,8 @@ class ScopedCleanupClosure {
  public:
   ScopedCleanupClosure() = default;
 
-  ScopedCleanupClosure(const fml::closure& closure) : closure_(closure) {}
+  explicit ScopedCleanupClosure(const fml::closure& closure)
+      : closure_(closure) {}
 
   ~ScopedCleanupClosure() {
     if (closure_) {

fml/concurrent_message_loop.h

@@ -46,7 +46,7 @@ class ConcurrentMessageLoop
   std::map<std::thread::id, std::vector<fml::closure>> thread_tasks_;
   bool shutdown_ = false;
 
-  ConcurrentMessageLoop(size_t worker_count);
+  explicit ConcurrentMessageLoop(size_t worker_count);
 
   void WorkerMain();
 
@@ -61,7 +61,7 @@ class ConcurrentMessageLoop
 
 class ConcurrentTaskRunner : public BasicTaskRunner {
  public:
-  ConcurrentTaskRunner(std::weak_ptr<ConcurrentMessageLoop> weak_loop);
+  explicit ConcurrentTaskRunner(std::weak_ptr<ConcurrentMessageLoop> weak_loop);
 
   virtual ~ConcurrentTaskRunner();
 

fml/log_settings.h

@@ -37,7 +37,7 @@ int GetMinLogLevel();
 
 class ScopedSetLogSettings {
  public:
-  ScopedSetLogSettings(const LogSettings& settings);
+  explicit ScopedSetLogSettings(const LogSettings& settings);
   ~ScopedSetLogSettings();
 
  private:

fml/mapping.h

@@ -44,9 +44,9 @@ class FileMapping final : public Mapping {
     kExecute,
   };
 
-  FileMapping(const fml::UniqueFD& fd,
-              std::initializer_list<Protection> protection = {
-                  Protection::kRead});
+  explicit FileMapping(const fml::UniqueFD& fd,
+                       std::initializer_list<Protection> protection = {
+                           Protection::kRead});
 
   ~FileMapping() override;
 
@@ -91,9 +91,9 @@ class FileMapping final : public Mapping {
 
 class DataMapping final : public Mapping {
  public:
-  DataMapping(std::vector<uint8_t> data);
+  explicit DataMapping(std::vector<uint8_t> data);
 
-  DataMapping(const std::string& string);
+  explicit DataMapping(const std::string& string);
 
   ~DataMapping() override;
 

fml/memory/ref_ptr.h

@@ -65,8 +65,8 @@ template <typename T>
 class RefPtr final {
  public:
   RefPtr() : ptr_(nullptr) {}
-  RefPtr(std::nullptr_t)
-      : ptr_(nullptr) {}  // NOLINT(google-explicit-constructor)
+  RefPtr(std::nullptr_t)  // NOLINT(google-explicit-constructor)
+      : ptr_(nullptr) {}
 
   // Explicit constructor from a plain pointer (to an object that must have
   // already been adopted). (Note that in |T::T()|, references to |this| cannot
@@ -80,22 +80,25 @@ class RefPtr final {
   }
 
   // Copy constructor.
-  RefPtr(const RefPtr<T>& r) : ptr_(r.ptr_) {
+  RefPtr(const RefPtr<T>& r)  // NOLINT(google-explicit-constructor)
+      : ptr_(r.ptr_) {
     if (ptr_) {
       ptr_->AddRef();
     }
   }
 
   template <typename U>
-  RefPtr(const RefPtr<U>& r)
-      : ptr_(r.ptr_) {  // NOLINT(google-explicit-constructor)
+  RefPtr(const RefPtr<U>& r)  // NOLINT(google-explicit-constructor)
+      : ptr_(r.ptr_) {
     if (ptr_) {
       ptr_->AddRef();
     }
   }
 
   // Move constructor.
-  RefPtr(RefPtr<T>&& r) : ptr_(r.ptr_) { r.ptr_ = nullptr; }
+  RefPtr(RefPtr<T>&& r) : ptr_(r.ptr_) {  // NOLINT(google-explicit-constructor)
+    r.ptr_ = nullptr;
+  }
 
   template <typename U>
   RefPtr(RefPtr<U>&& r) : ptr_(r.ptr_) {  // NOLINT(google-explicit-constructor)