Resolve Flutter 3.29 analyze issues (#819)

Author: JSUYA

analysis_options.yaml

@@ -127,7 +127,6 @@ linter:
     # - one_member_abstracts # too many false positives
     - only_throw_errors # this does get disabled in a few places where we have legacy code that uses strings et al
     - overridden_fields
-    - package_api_docs
     - package_names
     - package_prefixed_library_names
     # - parameter_assignments # we do this commonly
@@ -215,7 +214,6 @@ linter:
     - unnecessary_to_list_in_spreads
     - unreachable_from_main
     - unrelated_type_equality_checks
-    - unsafe_html
     - use_build_context_synchronously
     - use_colored_box
     # - use_decorated_box # leads to bugs: DecoratedBox and Container are not equivalent (Container inserts extra padding)

packages/audioplayers/example/integration_test/audioplayers_test.dart

@@ -14,8 +14,9 @@ void main() {
     testWidgets('can be initialized', (WidgetTester tester) async {
       final player = AudioPlayer();
       final initialized = Completer<void>();
-      player.onDurationChanged
-          .listen((Duration duration) => initialized.complete());
+      player.onDurationChanged.listen(
+        (Duration duration) => initialized.complete(),
+      );
 
       await player.setSourceAsset(_kAssetAudio);
       await initialized.future;
@@ -73,8 +74,9 @@ void main() {
       await player.dispose();
     });
 
-    testWidgets('can seek with different playrate',
-        (WidgetTester tester) async {
+    testWidgets('can seek with different playrate', (
+      WidgetTester tester,
+    ) async {
       final player = AudioPlayer();
       final started = Completer<void>();
       player.onPositionChanged.listen((position) {
@@ -127,8 +129,9 @@ void main() {
       await player.dispose();
     });
 
-    testWidgets('do not exceed duration after audio completed',
-        (WidgetTester tester) async {
+    testWidgets('do not exceed duration after audio completed', (
+      WidgetTester tester,
+    ) async {
       final player = AudioPlayer();
       final initialized = Completer<void>();
       final seek = Completer<void>();
@@ -161,8 +164,9 @@ void main() {
       await player.dispose();
     });
 
-    testWidgets('receives position updates regularly',
-        (WidgetTester tester) async {
+    testWidgets('receives position updates regularly', (
+      WidgetTester tester,
+    ) async {
       final player = AudioPlayer();
       final started = Completer<void>();
       var count = 0;

packages/audioplayers/example/lib/components/btn.dart

@@ -4,11 +4,7 @@ class Btn extends StatelessWidget {
   final String txt;
   final VoidCallback onPressed;
 
-  const Btn({
-    required this.txt,
-    required this.onPressed,
-    super.key,
-  });
+  const Btn({required this.txt, required this.onPressed, super.key});
 
   @override
   Widget build(BuildContext context) {

packages/audioplayers/example/lib/components/cbx.dart

@@ -5,12 +5,7 @@ class Cbx extends StatelessWidget {
   final bool value;
   final void Function({required bool? value}) update;
 
-  const Cbx(
-    this.label,
-    this.update, {
-    required this.value,
-    super.key,
-  });
+  const Cbx(this.label, this.update, {required this.value, super.key});
 
   @override
   Widget build(BuildContext context) {

packages/audioplayers/example/lib/components/dlg.dart

@@ -5,11 +5,7 @@ class SimpleDlg extends StatelessWidget {
   final String message;
   final String action;
 
-  const SimpleDlg({
-    required this.message,
-    required this.action,
-    super.key,
-  });
+  const SimpleDlg({required this.message, required this.action, super.key});
 
   @override
   Widget build(BuildContext context) {
@@ -18,10 +14,7 @@ class SimpleDlg extends StatelessWidget {
         mainAxisSize: MainAxisSize.min,
         children: [
           Text(message),
-          Btn(
-            txt: action,
-            onPressed: Navigator.of(context).pop,
-          ),
+          Btn(txt: action, onPressed: Navigator.of(context).pop),
         ],
       ),
     );
@@ -31,18 +24,12 @@ class SimpleDlg extends StatelessWidget {
 class Dlg extends StatelessWidget {
   final Widget child;
 
-  const Dlg({
-    required this.child,
-    super.key,
-  });
+  const Dlg({required this.child, super.key});
 
   @override
   Widget build(BuildContext context) {
     return Dialog(
-      child: Padding(
-        padding: const EdgeInsets.all(16.0),
-        child: child,
-      ),
+      child: Padding(padding: const EdgeInsets.all(16.0), child: child),
     );
   }
 }

packages/audioplayers/example/lib/components/drop_down.dart

@@ -47,14 +47,15 @@ class CustomDropDown<T> extends StatelessWidget {
       isExpanded: isExpanded,
       value: selected,
       onChanged: onChange,
-      items: options.entries
-          .map<DropdownMenuItem<T>>(
-            (entry) => DropdownMenuItem<T>(
-              value: entry.key,
-              child: Text(entry.value),
-            ),
-          )
-          .toList(),
+      items:
+          options.entries
+              .map<DropdownMenuItem<T>>(
+                (entry) => DropdownMenuItem<T>(
+                  value: entry.key,
+                  child: Text(entry.value),
+                ),
+              )
+              .toList(),
     );
   }
 }

packages/audioplayers/example/lib/components/list_tile.dart

@@ -15,10 +15,7 @@ class WrappedListTile extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     return ListTile(
-      title: Wrap(
-        alignment: WrapAlignment.end,
-        children: children,
-      ),
+      title: Wrap(alignment: WrapAlignment.end, children: children),
       leading: leading,
       trailing: trailing,
     );

packages/audioplayers/example/lib/components/pad.dart

@@ -8,9 +8,6 @@ class Pad extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return Container(
-      width: width,
-      height: height,
-    );
+    return Container(width: width, height: height);
   }
 }

packages/audioplayers/example/lib/components/player_widget.dart

@@ -7,10 +7,7 @@ import 'package:flutter/material.dart';
 class PlayerWidget extends StatefulWidget {
   final AudioPlayer player;
 
-  const PlayerWidget({
-    required this.player,
-    super.key,
-  });
+  const PlayerWidget({required this.player, super.key});
 
   @override
   State<StatefulWidget> createState() {
@@ -44,15 +41,15 @@ class _PlayerWidgetState extends State<PlayerWidget> {
     // Use initial values from player
     _playerState = player.state;
     player.getDuration().then(
-          (value) => setState(() {
-            _duration = value;
-          }),
-        );
+      (value) => setState(() {
+        _duration = value;
+      }),
+    );
     player.getCurrentPosition().then(
-          (value) => setState(() {
-            _position = value;
-          }),
-        );
+      (value) => setState(() {
+        _position = value;
+      }),
+    );
     _initStreams();
   }
 
@@ -115,19 +112,20 @@ class _PlayerWidgetState extends State<PlayerWidget> {
             final position = value * duration.inMilliseconds;
             player.seek(Duration(milliseconds: position.round()));
           },
-          value: (_position != null &&
-                  _duration != null &&
-                  _position!.inMilliseconds > 0 &&
-                  _position!.inMilliseconds < _duration!.inMilliseconds)
-              ? _position!.inMilliseconds / _duration!.inMilliseconds
-              : 0.0,
+          value:
+              (_position != null &&
+                      _duration != null &&
+                      _position!.inMilliseconds > 0 &&
+                      _position!.inMilliseconds < _duration!.inMilliseconds)
+                  ? _position!.inMilliseconds / _duration!.inMilliseconds
+                  : 0.0,
         ),
         Text(
           _position != null
               ? '$_positionText / $_durationText'
               : _duration != null
-                  ? _durationText
-                  : '',
+              ? _durationText
+              : '',
           style: const TextStyle(fontSize: 16.0),
         ),
       ],
@@ -150,8 +148,9 @@ class _PlayerWidgetState extends State<PlayerWidget> {
       });
     });
 
-    _playerStateChangeSubscription =
-        player.onPlayerStateChanged.listen((state) {
+    _playerStateChangeSubscription = player.onPlayerStateChanged.listen((
+      state,
+    ) {
       setState(() {
         _playerState = state;
       });

packages/audioplayers/example/lib/components/properties_widget.dart

@@ -5,10 +5,7 @@ import 'package:flutter/material.dart';
 class PropertiesWidget extends StatefulWidget {
   final AudioPlayer player;
 
-  const PropertiesWidget({
-    required this.player,
-    super.key,
-  });
+  const PropertiesWidget({required this.player, super.key});
 
   @override
   State<PropertiesWidget> createState() => _PropertiesWidgetState();

packages/audioplayers/example/lib/components/stream_widget.dart

@@ -7,10 +7,7 @@ import 'package:flutter/material.dart';
 class StreamWidget extends StatefulWidget {
   final AudioPlayer player;
 
-  const StreamWidget({
-    required this.player,
-    super.key,
-  });
+  const StreamWidget({required this.player, super.key});
 
   @override
   State<StreamWidget> createState() => _StreamWidgetState();
@@ -31,16 +28,19 @@ class _StreamWidgetState extends State<StreamWidget> {
     streamState = player.state;
     player.getDuration().then((it) => setState(() => streamDuration = it));
     player.getCurrentPosition().then(
-          (it) => setState(() => streamPosition = it),
-        );
+      (it) => setState(() => streamPosition = it),
+    );
 
     streams = <StreamSubscription>[
-      player.onDurationChanged
-          .listen((it) => setState(() => streamDuration = it)),
-      player.onPlayerStateChanged
-          .listen((it) => setState(() => streamState = it)),
-      player.onPositionChanged
-          .listen((it) => setState(() => streamPosition = it)),
+      player.onDurationChanged.listen(
+        (it) => setState(() => streamDuration = it),
+      ),
+      player.onPlayerStateChanged.listen(
+        (it) => setState(() => streamState = it),
+      ),
+      player.onPositionChanged.listen(
+        (it) => setState(() => streamPosition = it),
+      ),
     ];
   }
 

packages/audioplayers/example/lib/components/tab_content.dart

@@ -3,10 +3,7 @@ import 'package:flutter/material.dart';
 class TabContent extends StatelessWidget {
   final List<Widget> children;
 
-  const TabContent({
-    required this.children,
-    super.key,
-  });
+  const TabContent({required this.children, super.key});
 
   @override
   Widget build(BuildContext context) {
@@ -17,9 +14,7 @@ class TabContent extends StatelessWidget {
           controller: ScrollController(),
           child: Padding(
             padding: const EdgeInsets.symmetric(vertical: 8),
-            child: Column(
-              children: children,
-            ),
+            child: Column(children: children),
           ),
         ),
       ),

packages/audioplayers/example/lib/components/tabs.dart

@@ -3,10 +3,7 @@ import 'package:flutter/material.dart';
 class Tabs extends StatelessWidget {
   final List<TabData> tabs;
 
-  const Tabs({
-    required this.tabs,
-    super.key,
-  });
+  const Tabs({required this.tabs, super.key});
 
   @override
   Widget build(BuildContext context) {
@@ -18,14 +15,15 @@ class Tabs extends StatelessWidget {
           children: [
             TabBar(
               labelColor: Colors.black,
-              tabs: tabs
-                  .map(
-                    (tData) => Tab(
-                      key: tData.key != null ? Key(tData.key!) : null,
-                      text: tData.label,
-                    ),
-                  )
-                  .toList(),
+              tabs:
+                  tabs
+                      .map(
+                        (tData) => Tab(
+                          key: tData.key != null ? Key(tData.key!) : null,
+                          text: tData.label,
+                        ),
+                      )
+                      .toList(),
             ),
             Expanded(
               child: TabBarView(
@@ -44,9 +42,5 @@ class TabData {
   final String label;
   final Widget content;
 
-  TabData({
-    required this.label,
-    required this.content,
-    this.key,
-  });
+  TabData({required this.label, required this.content, this.key});
 }