-
Notifications
You must be signed in to change notification settings - Fork 76
chore(rollup-boost/deps): remove dependency on op-reth from rollup-boost #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request removes the reth-optimism-payload-builder dependency from the rollup-boost crate to enable publishing to crates.io. The change replaces a standalone function call with a method on the OpPayloadAttributes type, made available by upgrading op-alloy dependencies from version 0.22.0 to 0.22.3 and patching op-alloy-rpc-types-engine to use a git revision.
Key Changes:
- Removed
reth-optimism-payload-builderdependency and replacedpayload_id_optimismfunction withOpPayloadAttributes.payload_id()method - Updated op-alloy dependencies from 0.22.0 to 0.22.3
- Added git patch for
op-alloy-rpc-types-engineto use a specific commit from the op-alloy repository
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/rollup-boost/src/flashblocks/service.rs | Replaced payload_id_optimism function call with attr.payload_id() method and removed import |
| crates/rollup-boost/Cargo.toml | Removed reth-optimism-payload-builder dependency |
| Cargo.toml | Removed reth dependency definitions, updated op-alloy versions to 0.22.3, added patch for op-alloy-rpc-types-engine |
| Cargo.lock | Updated dependency versions including alloy and op-alloy crates, added borsh dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| testcontainers-modules = { version = "0.11", features = ["redis"] } | ||
|
|
||
| [patch.crates-io] | ||
| op-alloy-rpc-types-engine = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"} |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch configuration is incomplete. Only op-alloy-rpc-types-engine is patched to use the git repository, but this creates a version conflict where both op-alloy-consensus 0.22.3 (from git, as a dependency of the patched op-alloy-rpc-types-engine) and 0.22.4 (from crates.io) appear in the dependency tree.
To fix this, you should also patch op-alloy-consensus to use the same git revision:
[patch.crates-io]
op-alloy-rpc-types-engine = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"}
op-alloy-consensus = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"}This ensures all op-alloy crates use compatible versions from the same source.
| op-alloy-rpc-types-engine = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"} | |
| op-alloy-rpc-types-engine = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"} | |
| op-alloy-consensus = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"} |
| testcontainers-modules = { version = "0.11", features = ["redis"] } | ||
|
|
||
| [patch.crates-io] | ||
| op-alloy-rpc-types-engine = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to remove that before merging the PR
Description
Removes
rethdependency fromrollup-boost. Will allow to publishrollup-booston crates.io and then konaDepends on alloy-rs/op-alloy#613