Skip to content

Conversation

@theochap
Copy link
Contributor

@theochap theochap commented Dec 4, 2025

Description

Removes reth dependency from rollup-boost. Will allow to publish rollup-boost on crates.io and then kona

Depends on alloy-rs/op-alloy#613

Copilot AI review requested due to automatic review settings December 4, 2025 22:29
@vercel
Copy link

vercel bot commented Dec 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rollup-boost Ignored Ignored Dec 4, 2025 10:29pm

Copilot finished reviewing on behalf of theochap December 4, 2025 22:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the reth-optimism-payload-builder dependency from the rollup-boost crate to enable publishing to crates.io. The change replaces a standalone function call with a method on the OpPayloadAttributes type, made available by upgrading op-alloy dependencies from version 0.22.0 to 0.22.3 and patching op-alloy-rpc-types-engine to use a git revision.

Key Changes:

  • Removed reth-optimism-payload-builder dependency and replaced payload_id_optimism function with OpPayloadAttributes.payload_id() method
  • Updated op-alloy dependencies from 0.22.0 to 0.22.3
  • Added git patch for op-alloy-rpc-types-engine to use a specific commit from the op-alloy repository

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
crates/rollup-boost/src/flashblocks/service.rs Replaced payload_id_optimism function call with attr.payload_id() method and removed import
crates/rollup-boost/Cargo.toml Removed reth-optimism-payload-builder dependency
Cargo.toml Removed reth dependency definitions, updated op-alloy versions to 0.22.3, added patch for op-alloy-rpc-types-engine
Cargo.lock Updated dependency versions including alloy and op-alloy crates, added borsh dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

testcontainers-modules = { version = "0.11", features = ["redis"] }

[patch.crates-io]
op-alloy-rpc-types-engine = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"}
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch configuration is incomplete. Only op-alloy-rpc-types-engine is patched to use the git repository, but this creates a version conflict where both op-alloy-consensus 0.22.3 (from git, as a dependency of the patched op-alloy-rpc-types-engine) and 0.22.4 (from crates.io) appear in the dependency tree.

To fix this, you should also patch op-alloy-consensus to use the same git revision:

[patch.crates-io]
op-alloy-rpc-types-engine = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"}
op-alloy-consensus = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"}

This ensures all op-alloy crates use compatible versions from the same source.

Suggested change
op-alloy-rpc-types-engine = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"}
op-alloy-rpc-types-engine = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"}
op-alloy-consensus = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"}

Copilot uses AI. Check for mistakes.
testcontainers-modules = { version = "0.11", features = ["redis"] }

[patch.crates-io]
op-alloy-rpc-types-engine = { git = "https://github.com/alloy-rs/op-alloy", rev = "f297e3f"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to remove that before merging the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant