Skip to content

bug: race condition due to multiple backend connections being open #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0x416e746f6e opened this issue Mar 28, 2025 · 2 comments
Closed

Comments

@0x416e746f6e
Copy link

at the periods of high loads rollup-boost tends to open multiple (dozens) of TCP connections to the builder, which can deliver otherwise sequential updates from sequencer in arbitrary order.

one example timeline (from rollup-boost logs):

2025-03-28T13:31:15.296Z,"{""level"":""INFO"",""fields"":{""has_attributes"":true,""head_block_hash"":""0xf7b308e151bf7c13aa362494ab499d3eee3c634a5eb0a1228e9e1cd44e874c69"",""message"":""received fork_choice_updated_v3""},""timestamp"":""2025-03-28T13:31:15.296585Z"",""target"":""rollup_boost::server""}"
2025-03-28T13:31:15.297Z,"{""level"":""INFO"",""fields"":{""method"":""\""engine_getPayloadV3\"""",""message"":""proxying request to rollup-boost server""},""timestamp"":""2025-03-28T13:31:15.297978Z"",""target"":""proxy::call""}"
2025-03-28T13:31:15.298Z,"{""level"":""INFO"",""fields"":{""payload_id"":""0x03e01ec8a970741a"",""message"":""received get_payload_v3""},""timestamp"":""2025-03-28T13:31:15.298012Z"",""target"":""rollup_boost::server""}"
2025-03-28T13:31:15.318Z,"{""level"":""ERROR"",""fields"":{""local_payload_id"":""0x03e01ec8a970741a"",""external_payload_id"":""0x03e01ec8a970741a"",""message"":""error calling get_payload_v3 from builder"",""error"":""ErrorObject { code: ServerError(-38001), message: \""Unknown payload\"", data: None }"",""url"":""http://34.162.194.218:8651/""},""timestamp"":""2025-03-28T13:31:15.318342Z"",""target"":""rollup_boost::server""}"
2025-03-28T13:31:15.318Z,"{""level"":""INFO"",""fields"":{""number"":""3098535"",""payload_id"":""0x03e01ec8a970741a"",""context"":""l2"",""message"":""returning block"",""hash"":""0x9bb4f13f944d146aac771d7304230f3a07b5bf9c50ab3da78e88fce046de360f""},""timestamp"":""2025-03-28T13:31:15.318365Z"",""target"":""rollup_boost::server""}"

related logs from the builder side (timestamps are for when the response was sent back):

Image

related to: #126

@avalonche
Copy link
Collaborator

there's only a 10ms difference between the fcu and getPayload request. I think by the time the fcu response was completed another getPayload request was received, initiating a new request. Is this not a bug caused by op-node having too little time between requests?

@ferranbt
Copy link
Collaborator

Closing this since #206 fixed the "Unknown Payload" issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants