-
Notifications
You must be signed in to change notification settings - Fork 118
Description
Related PRS
- Add definition and dataspace implementation - artifact generation + dataspace impl legend-engine#833
- Update definition based on 8/31 discussion - minor updates to ArtifactGenerationExtension legend-engine#900
- Add handling to sdlc pipeline - handle ArtifactGenerationExtensions #481
- Add reading and storing artifacts to depot handle artifacts generations legend-depot#98
- legend-studio use depot api to fetch dataspace analytics
Description of Problem
We want to generate useful artifacts for specific Packageable Elements. This is useful for caching the contents of these artifacts through legend-depot to improve performance when fetching these artifacts.
This comes in handy when doing complicated analytics on Packageable elements which takes time and resources to recalculate. An example is generating an ExecutionPlan for a service element. With this feature, the generation of the execution plan will occur once during the build step of the project and can therefore be used whenever the generation plan for the service is needed (i.e executing query etc.).
Solution Overview
We already have a maven plugin to generate files for an sdlc project. Right now it reads FileGeneration elements defined in the GenerationSpecification. The limitation here is that the user must specify the generation and also it is tied to having a generator driven by a schema/code generation.
We will define the ArtifactGenerationExtension more loosely. The main driver will be a packageable element, which will now be referred as the generator, in the graph that can define its own generation.
Current Approach: Use element path as driver for file paths
ArtifactGenerationExtension Diagram
File Structure
The generate method of the ArtifactGenerationExtension will return a list of artifacts with filePaths on them. When seralizing them to files we will place these files under the sub folder with the name tied to the generator that generated these files + the extension root folder.
Example
Generators with files generated
model::CodeGeneration: (extension with root path code-generation)- generated/MyJava.java
- MyPython.py
model::CodeGeneration2: (extension with root path code-generation)- MyPthon.py
model::SchemaGeneration- schemaGen/MyJson.json : (extension with root path schmea-generation)
- MyProto.proto
model::MyClass: (extension with root path other-generation)- someGeneration/stuff.txt
- MyStuff.txt
File Structure on file generation jar output
- model
- CodeGeneration
- code-generation
- generated
- MyJava.java
- MyPyton.py
- generated
- code-generation
- CodeGeneration2
- code-generation
- MyPyton.py
- code-generation
- SchemaGeneration
- schema-generation
- schemaGen
- MyJson.json
- MyProto.proto
- schemaGen
- schema-generation
- ClassGeneration
- other-generation
- someGeneration
- stuff.txt
- MyStuff.txt
- someGeneration
- other-generation
- CodeGeneration
Impact on Depot
- Currently depot uses classifier path to index files generated through the file generation maven plugin by:
- fetching
GenerationSpecificationentity through classifier path. - fetching
fileGenerationsdefined in GenerationSpecification - for each fileGeneration we use either the
generationOutputPathif defined in thefileGenerationpath or we use the file generation path to determine thepathto index - this
pathwill be indexed as the location of where the expected files generated by this fileGeneration will be located.
- fetching
EnhancementWe should update apis to unpack all files generated as part of file generation maven plugin. We con potentially query files generated by generator.
Abandoned Approach: Use of RootPaths per extensions
abandonedon 08/31 due to
Approach (Abandoned )
We will define the ArtifactGenerationExtension more loosely. It is driven by a packageable element in the graph that can define its own generation.
The generate method on the extension will be the main driver of the extension and will expect the element with its compiled model PureModel to produce artifacts.
Impact on Depot (Abandoned )
Current depot apis rely on the paths of the files generated. This will not change for the current FileGeneration element as the location of the files generated by those elements will stay the same and will continue to be defined (for now in GenerationSpecification)
Folder Structure (Abandoned )
All files generated by ArtifactGenerationExtension will be generated under the root folder artifacts-generation-root. Furthermore, each extension will define its artifactsRootPath that will create a folder under the root folder for the files generated by the extension
- (root) artifacts-generation-root
- (extension1) extenstion1-root-path
- generatedFile.json (generated by extension1)
- (extension2) extenstion2-root-path
- generatedFile.json (generated by extension2)
- (extension1) extenstion1-root-path


