Skip to content

Commit dcfc8e6

Browse files
committed
chore: improve comments for standalone distribution example
1 parent 187dad4 commit dcfc8e6

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

examples/standalone-distribution/cloudfront_distribution.tf

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,21 +47,24 @@ resource "aws_cloudfront_distribution" "fpjs_cloudfront_distribution" {
4747
}
4848
}
4949

50+
viewer_certificate {
51+
cloudfront_default_certificate = true
52+
}
53+
5054
# You can make the distribution available on a subdomain of your website
51-
# Uncomment the following and define the referenced variables
55+
# - Uncomment the following and define the referenced variables in a `terraform.tfvars` file
56+
# - Remove the default viewer certificate above
57+
5258
# aliases = [var.proxy_subdomain_domain]
5359
# viewer_certificate {
5460
# acm_certificate_arn = var.certificate_arn
5561
# ssl_support_method = "sni-only"
5662
# }
57-
58-
59-
viewer_certificate {
60-
cloudfront_default_certificate = true
61-
}
6263
}
6364

6465
# You can make the distribution available on a subdomain of your website
66+
# - Uncomment the following and define the referenced variables in a `terraform.tfvars` file
67+
6568
# resource "aws_route53_record" "cloudfront_terraform_new_distribution_record" {
6669
# zone_id = var.domain_zone_id
6770
# name = var.proxy_subdomain_domain

examples/standalone-distribution/variables.tf

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,17 @@ variable "fpjs_get_result_path" {
1616
type = string
1717
}
1818

19+
/**
20+
* The following variables are only relevant for this example.
21+
* - They are not relevant to the module itself
22+
* - They are optional, uncomment them out if you want to add a subdomain for the CloudFront distribution
23+
*/
24+
1925
# variable "proxy_subdomain_domain" {
2026
# description = "The subdomain for the CloudFront distribution, including the root domain of your website, for example `metrics.yourwebsite.com`"
2127
# type = string
2228
# }
2329

24-
2530
# variable "domain_zone_id" {
2631
# description = "Zone ID of the domain for the CloudFront distribution"
2732
# type = string

0 commit comments

Comments
 (0)