Skip to content

Commit 6a276a4

Browse files
authored
Merge branch 'main' into feat/default-heading
2 parents d5c10a0 + 56ab0c0 commit 6a276a4

File tree

3 files changed

+14
-15
lines changed

3 files changed

+14
-15
lines changed

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,8 @@ Example generated release notes:
8282

8383
### Supported Native SDK Version Range
8484

85-
Fingerprint Android SDK Version Range: `>= 2.7.0 and < 3.0.0`
86-
87-
Fingerprint iOS SDK Version Range: `>= 2.7.0 and < 3.0.0`
85+
* Fingerprint Android SDK Version Range: `>= 2.7.0 and < 3.0.0`
86+
* Fingerprint iOS SDK Version Range: `>= 2.7.0 and < 3.0.0`
8887
```
8988

9089
## Requirements

src/generateNotes.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ const formatter = (platforms: { displayName: string; versionRange: string }[], h
88

99
result += platforms
1010
.map(({ displayName, versionRange }) => {
11-
return `${displayName} Version Range: **\`${versionRange}\`**`
11+
return `* ${displayName} Version Range: **\`${versionRange}\`**`
1212
})
13-
.join('\n\n')
13+
.join('\n')
1414

1515
return result
1616
}

test/index.test.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ describe('index', () => {
4444
},
4545
generateNotesContext
4646
)
47-
).resolves.toBe(`${defaultHeading}\n\n${android.displayName} Version Range: **\`>= 1.2.3 and < 4.5.6\`**`)
47+
).resolves.toBe(`${defaultHeading}\n\n* ${android.displayName} Version Range: **\`>= 1.2.3 and < 4.5.6\`**`)
4848
}, 30000)
4949
it('resolves android version (backport)', async () => {
5050
const android = pluginConfig.platforms.android
@@ -56,7 +56,7 @@ describe('index', () => {
5656
},
5757
generateNotesContext
5858
)
59-
).resolves.toBe(`${defaultHeading}\n\n${android.displayName} Version Range: **\`>= 1.2.3 and < 4.5.6\`**`)
59+
).resolves.toBe(`${defaultHeading}\n\n* ${android.displayName} Version Range: **\`>= 1.2.3 and < 4.5.6\`**`)
6060
}, 30000)
6161
it('resolves iOS version', async () => {
6262
const iOS = pluginConfig.platforms.iOS
@@ -70,7 +70,7 @@ describe('index', () => {
7070
},
7171
generateNotesContext
7272
)
73-
).resolves.toBe(`${defaultHeading}\n\n${iOS.displayName} Version Range: **\`>= 1.2.3 and < 4.5.6\`**`)
73+
).resolves.toBe(`${defaultHeading}\n\n* ${iOS.displayName} Version Range: **\`>= 1.2.3 and < 4.5.6\`**`)
7474
})
7575
it('resolves iOS version (backport)', async () => {
7676
const iOS = pluginConfig.platforms.iOS
@@ -82,7 +82,7 @@ describe('index', () => {
8282
},
8383
generateNotesContext
8484
)
85-
).resolves.toBe(`${defaultHeading}\n\n${iOS.displayName} Version Range: **\`>= 1.2.3 and < 4.5.6\`**`)
85+
).resolves.toBe(`${defaultHeading}\n\n* ${iOS.displayName} Version Range: **\`>= 1.2.3 and < 4.5.6\`**`)
8686
})
8787
it('throws error on cwd not set', async () => {
8888
const testGenerateNotesContext = {
@@ -114,22 +114,22 @@ describe('index', () => {
114114
const heading = 'Example Heading'
115115
const { iOS, android } = pluginConfig.platforms
116116

117-
const expectedHeading = `### ${heading}`
118-
const expectedAndroid = `${android.displayName} Version Range: **\`>= 1.2.3 and < 4.5.6\`**`
119-
const expectedIOS = `${iOS.displayName} Version Range: **\`>= 1.2.3 and < 4.5.6\`**`
117+
const expectedHeading = `### ${heading}\n`
118+
const expectedAndroid = `* ${android.displayName} Version Range: **\`>= 1.2.3 and < 4.5.6\`**`
119+
const expectedIOS = `* ${iOS.displayName} Version Range: **\`>= 1.2.3 and < 4.5.6\`**`
120120

121121
const subTestCases = [
122122
{
123123
platforms: { iOS, android },
124-
expected: [expectedHeading, expectedAndroid, expectedIOS].join('\n\n'),
124+
expected: [expectedHeading, expectedAndroid, expectedIOS].join('\n'),
125125
},
126126
{
127127
platforms: { iOS },
128-
expected: [expectedHeading, expectedIOS].join('\n\n'),
128+
expected: [expectedHeading, expectedIOS].join('\n'),
129129
},
130130
{
131131
platforms: { android },
132-
expected: [expectedHeading, expectedAndroid].join('\n\n'),
132+
expected: [expectedHeading, expectedAndroid].join('\n'),
133133
},
134134
]
135135

0 commit comments

Comments
 (0)