Skip to content

Commit 77e0c16

Browse files
feat: rename Webhook class to WebhookValidation
1 parent 7e9fa27 commit 77e0c16

File tree

7 files changed

+19
-13
lines changed

7 files changed

+19
-13
lines changed

.changeset/sweet-tables-bathe.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"fingerprint-pro-server-api-dotnet-sdk": major
3+
---
4+
5+
Rename `Webhook` class to `WebhookValidation`.
6+
Right now, `Webhook` class points to the actual data model.

docs/SdkWebhook.md renamed to docs/WebhookValidation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# FingerprintPro.ServerSdk.Webhook
1+
# FingerprintPro.ServerSdk.WebhookValidation
22

33
## **IsValidWebhookSignature**
44

generate.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
# clean models and docs before generating
44
find ./src/FingerprintPro.ServerSdk/Model -type f ! -name "DictionaryModel.cs" -exec rm {} +
5-
find ./docs -type f ! -name "DecryptionKey.md" ! -name "Sealed.md" ! -name "SdkWebhook.md" -exec rm {} +
5+
find ./docs -type f ! -name "DecryptionKey.md" ! -name "Sealed.md" ! -name "WebhookValidation.md" -exec rm {} +
66

77
# jar was downloaded from here https://repo1.maven.org/maven2/io/swagger/codegen/v3/swagger-codegen-cli/3.0.34/
88

src/FingerprintPro.ServerSdk.Test/Model/WebhookVisitTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ public void FromBytesTest()
1313
{
1414
var bytes = MockLoader.Load("webhook.json");
1515
var json = Encoding.UTF8.GetString(bytes);
16-
var webhook = JsonUtils.Deserialize<ServerSdk.Model.Webhook>(json);
16+
var webhook = JsonUtils.Deserialize<Webhook>(json);
1717

18-
Assert.That(webhook, Is.InstanceOf<ServerSdk.Model.Webhook>());
18+
Assert.That(webhook, Is.InstanceOf<Webhook>());
1919
}
2020
}

src/FingerprintPro.ServerSdk.Test/WebhookTests.cs renamed to src/FingerprintPro.ServerSdk.Test/WebhookValidationTests.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace FingerprintPro.ServerSdk.Test;
44

55
[TestFixture]
6-
public class WebhookTests
6+
public class WebhookValidationTests
77
{
88
private const string _validHeader = "v1=1b2c16b75bd2a870c114153ccda5bcfca63314bc722fa160d690de133ccbb9db";
99
private const string _secret = "secret";
@@ -12,15 +12,15 @@ public class WebhookTests
1212
[Test]
1313
public void ValidHeaderTest()
1414
{
15-
var result = Webhook.IsValidWebhookSignature(_validHeader, Data, _secret);
15+
var result = WebhookValidation.IsValidWebhookSignature(_validHeader, Data, _secret);
1616

1717
Assert.That(result, Is.True);
1818
}
1919

2020
[Test]
2121
public void InvalidHeaderTest()
2222
{
23-
var result = Webhook.IsValidWebhookSignature("v2=invalid", Data, _secret);
23+
var result = WebhookValidation.IsValidWebhookSignature("v2=invalid", Data, _secret);
2424

2525
Assert.That(result, Is.False);
2626
}
@@ -29,31 +29,31 @@ public void InvalidHeaderTest()
2929
[Test]
3030
public void HeaderWithoutVersionTest()
3131
{
32-
var result = Webhook.IsValidWebhookSignature("invalid", Data, _secret);
32+
var result = WebhookValidation.IsValidWebhookSignature("invalid", Data, _secret);
3333

3434
Assert.That(result, Is.False);
3535
}
3636

3737
[Test]
3838
public void EmptyHeaderTest()
3939
{
40-
var result = Webhook.IsValidWebhookSignature("invalid", Data, _secret);
40+
var result = WebhookValidation.IsValidWebhookSignature("invalid", Data, _secret);
4141

4242
Assert.That(result, Is.False);
4343
}
4444

4545
[Test]
4646
public void EmptySecretTest()
4747
{
48-
var result = Webhook.IsValidWebhookSignature("invalid", Data, "");
48+
var result = WebhookValidation.IsValidWebhookSignature("invalid", Data, "");
4949

5050
Assert.That(result, Is.False);
5151
}
5252

5353
[Test]
5454
public void EmptyDataTest()
5555
{
56-
var result = Webhook.IsValidWebhookSignature(_validHeader, ""u8.ToArray(), _secret);
56+
var result = WebhookValidation.IsValidWebhookSignature(_validHeader, ""u8.ToArray(), _secret);
5757

5858
Assert.That(result, Is.False);
5959
}

src/FingerprintPro.ServerSdk.WebhookExample/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
const string secret = "secret";
55
var data = "data"u8.ToArray();
66

7-
var isValid = Webhook.IsValidWebhookSignature(header, data, secret);
7+
var isValid = WebhookValidation.IsValidWebhookSignature(header, data, secret);
88

99
Console.WriteLine(isValid ? "Webhook signature is correct!" : "Webhook signature is incorrect!");

src/FingerprintPro.ServerSdk/Webhook.cs renamed to src/FingerprintPro.ServerSdk/WebhookValidation.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
namespace FingerprintPro.ServerSdk;
55

6-
public static class Webhook
6+
public static class WebhookValidation
77
{
88
private static bool IsValidHmacSignature(string signature, byte[] data, string secret)
99
{

0 commit comments

Comments
 (0)