Code Quality: Enable NuGet Transitive Pinning#18177
Open
dfederm wants to merge 1 commit intofiles-community:mainfrom
Open
Code Quality: Enable NuGet Transitive Pinning#18177dfederm wants to merge 1 commit intofiles-community:mainfrom
dfederm wants to merge 1 commit intofiles-community:mainfrom
Conversation
Member
|
Thank you for the pull request. In the future, it's recommended to only open pull requests for issues marked 'Ready to build', this helps prevent extra work in the event we don't end up accepting a change. In any event, since the work is already done, we'll take a look 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
N/A
Steps used to test these changes
Build (no behavioral changes expected)
Changes
This enables Transitive Pinning which essentially makes your
Directory.Packages.propsa partial lock file. If a package is listed inDirectory.Packages.props, that will be the version, even if a project doesn't explicitly reference that package and it's just a transitive dependency. This is the primary benefit of transitive pinning, to ensure all projects within the repo are using the same version of all packages. It also allows security issues in transitive dependencies to be more easily addressed by simply updatingDirectory.Packages.propsinstead of adding a top-level dependency to all impacted projects, which is far messier and less maintainable.