Skip to content

Commit fbacc90

Browse files
committed
Use only SingleItem
1 parent 0804de9 commit fbacc90

File tree

3 files changed

+7
-18
lines changed

3 files changed

+7
-18
lines changed

src/Files.App/Data/Enums/IconOptions.cs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,5 @@ public enum IconOptions
3838
/// Retrieve a thumbnail only if it is cached or embedded in the file.
3939
/// </summary>
4040
ReturnOnlyIfCached = 16,
41-
42-
/// <summary>
43-
/// Default. Retrieve a thumbnail to display a preview of any single item (like a file, folder, or file group).
44-
/// </summary>
45-
SingleItem = 32,
46-
47-
/// <summary>
48-
/// Retrieve a thumbnail to display previews of files (or other items) in a list.
49-
/// </summary>
50-
ListView = 64,
5141
}
5242
}

src/Files.App/Utils/Storage/Helpers/FileThumbnailHelper.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,7 @@ public static class FileThumbnailHelper
3737
(iconOptions.HasFlag(IconOptions.ReturnOnlyIfCached) ? ThumbnailOptions.ReturnOnlyIfCached : 0) |
3838
(iconOptions.HasFlag(IconOptions.ResizeThumbnail) ? ThumbnailOptions.ResizeThumbnail : 0);
3939

40-
var thumbnailMode = iconOptions.HasFlag(IconOptions.ListView) ? ThumbnailMode.ListView : ThumbnailMode.SingleItem;
41-
42-
return GetIconAsync(item, requestedSize, thumbnailMode, thumbnailOptions);
40+
return GetIconAsync(item, requestedSize, ThumbnailMode.SingleItem, thumbnailOptions);
4341
}
4442

4543
public static async Task<byte[]?> GetIconAsync(IStorageItem item, uint requestedSize, ThumbnailMode thumbnailMode, ThumbnailOptions thumbnailOptions)

src/Files.App/ViewModels/ShellViewModel.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1096,17 +1096,18 @@ private async Task<bool> LoadThumbnailAsync(ListedItem item, IStorageItem matchi
10961096
// SingleItem returns image thumbnails in the correct aspect ratio for the grid layouts
10971097
// ListView is used for the details and columns layout
10981098
// We use ReturnOnlyIfCached because otherwise folders thumbnails have a black background, this has the downside the folder previews don't work
1099-
var iconOptions = matchingStorageItem switch
1099+
var (mode, options) = matchingStorageItem switch
11001100
{
1101-
BaseStorageFolder => IconOptions.SingleItem | IconOptions.ReturnOnlyIfCached,
1102-
BaseStorageFile when thumbnailSize < 96 => IconOptions.ListView | IconOptions.ResizeThumbnail,
1103-
_ => IconOptions.SingleItem | IconOptions.ResizeThumbnail,
1101+
BaseStorageFolder => (ThumbnailMode.SingleItem, ThumbnailOptions.ReturnOnlyIfCached),
1102+
BaseStorageFile when thumbnailSize < 96 => (ThumbnailMode.ListView, ThumbnailOptions.ResizeThumbnail),
1103+
_ => (ThumbnailMode.SingleItem, ThumbnailOptions.ResizeThumbnail),
11041104
};
11051105

11061106
var result = await FileThumbnailHelper.GetIconAsync(
11071107
matchingStorageItem,
11081108
thumbnailSize,
1109-
iconOptions);
1109+
mode,
1110+
options);
11101111

11111112
if (result is not null)
11121113
{

0 commit comments

Comments
 (0)