Skip to content

Commit 2577838

Browse files
refactor: BlocObserver instances to use const constructors (#3713)
1 parent c4500b6 commit 2577838

File tree

20 files changed

+42
-15
lines changed

20 files changed

+42
-15
lines changed

examples/angular_counter/web/main.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
import 'package:angular/angular.dart';
2-
import 'package:bloc/bloc.dart';
32
import 'package:angular_counter/app_component.template.dart' as ng;
3+
import 'package:bloc/bloc.dart';
44

55
class SimpleBlocObserver extends BlocObserver {
6+
const SimpleBlocObserver();
7+
68
@override
79
void onEvent(Bloc bloc, Object? event) {
810
print(event);
@@ -23,6 +25,6 @@ class SimpleBlocObserver extends BlocObserver {
2325
}
2426

2527
void main() {
26-
Bloc.observer = SimpleBlocObserver();
28+
Bloc.observer = const SimpleBlocObserver();
2729
runApp(ng.AppComponentNgFactory);
2830
}

examples/flutter_complex_list/lib/main.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ import 'package:flutter_complex_list/repository.dart';
66
import 'package:flutter_complex_list/simple_bloc_observer.dart';
77

88
void main() {
9-
Bloc.observer = SimpleBlocObserver();
9+
Bloc.observer = const SimpleBlocObserver();
1010
runApp(App(repository: Repository()));
1111
}

examples/flutter_complex_list/lib/simple_bloc_observer.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import 'package:bloc/bloc.dart';
22

33
class SimpleBlocObserver extends BlocObserver {
4+
const SimpleBlocObserver();
5+
46
@override
57
void onError(BlocBase<dynamic> bloc, Object error, StackTrace stackTrace) {
68
// ignore: avoid_print

examples/flutter_counter/lib/counter_observer.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ import 'package:bloc/bloc.dart';
55
/// observes all state changes.
66
/// {@endtemplate}
77
class CounterObserver extends BlocObserver {
8+
/// {@macro counter_observer}
9+
const CounterObserver();
10+
811
@override
912
void onChange(BlocBase<dynamic> bloc, Change<dynamic> change) {
1013
super.onChange(bloc, change);

examples/flutter_counter/lib/main.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ import 'package:flutter_counter/app.dart';
44
import 'package:flutter_counter/counter_observer.dart';
55

66
void main() {
7-
Bloc.observer = CounterObserver();
7+
Bloc.observer = const CounterObserver();
88
runApp(const CounterApp());
99
}

examples/flutter_firebase_login/lib/app/bloc_observer.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
import 'package:bloc/bloc.dart';
33

44
class AppBlocObserver extends BlocObserver {
5+
const AppBlocObserver();
6+
57
@override
68
void onEvent(Bloc<dynamic, dynamic> bloc, Object? event) {
79
super.onEvent(bloc, event);

examples/flutter_firebase_login/lib/main.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import 'package:flutter_firebase_login/app/app.dart';
66

77
Future<void> main() async {
88
WidgetsFlutterBinding.ensureInitialized();
9-
Bloc.observer = AppBlocObserver();
9+
Bloc.observer = const AppBlocObserver();
1010

1111
await Firebase.initializeApp();
1212

examples/flutter_infinite_list/lib/main.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ import 'package:flutter_infinite_list/app.dart';
55
import 'package:flutter_infinite_list/simple_bloc_observer.dart';
66

77
void main() {
8-
Bloc.observer = SimpleBlocObserver();
8+
Bloc.observer = const SimpleBlocObserver();
99
runApp(const App());
1010
}

examples/flutter_infinite_list/lib/simple_bloc_observer.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import 'package:bloc/bloc.dart';
44

55
class SimpleBlocObserver extends BlocObserver {
6+
const SimpleBlocObserver();
7+
68
@override
79
void onTransition(
810
Bloc<dynamic, dynamic> bloc,

examples/flutter_shopping_cart/lib/main.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ import 'package:flutter_shopping_cart/shopping_repository.dart';
55
import 'package:flutter_shopping_cart/simple_bloc_observer.dart';
66

77
void main() {
8-
Bloc.observer = SimpleBlocObserver();
8+
Bloc.observer = const SimpleBlocObserver();
99
runApp(App(shoppingRepository: ShoppingRepository()));
1010
}

examples/flutter_shopping_cart/lib/simple_bloc_observer.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ import 'dart:developer';
33
import 'package:bloc/bloc.dart';
44

55
class SimpleBlocObserver extends BlocObserver {
6+
const SimpleBlocObserver();
7+
68
@override
79
void onEvent(Bloc<dynamic, dynamic> bloc, Object? event) {
810
super.onEvent(bloc, event);

examples/flutter_todos/lib/app/app_bloc_observer.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ import 'dart:developer';
33
import 'package:bloc/bloc.dart';
44

55
class AppBlocObserver extends BlocObserver {
6+
const AppBlocObserver();
7+
68
@override
79
void onChange(BlocBase<dynamic> bloc, Change<dynamic> change) {
810
super.onChange(bloc, change);

examples/flutter_todos/lib/bootstrap.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ void bootstrap({required TodosApi todosApi}) {
1313
log(details.exceptionAsString(), stackTrace: details.stack);
1414
};
1515

16-
Bloc.observer = AppBlocObserver();
16+
Bloc.observer = const AppBlocObserver();
1717

1818
final todosRepository = TodosRepository(todosApi: todosApi);
1919

examples/flutter_todos/pubspec.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ packages:
3737
dependency: "direct main"
3838
description:
3939
name: bloc
40-
sha256: bd4f8027bfa60d96c8046dec5ce74c463b2c918dce1b0d36593575995344534a
40+
sha256: "658a5ae59edcf1e58aac98b000a71c762ad8f46f1394c34a52050cafb3e11a80"
4141
url: "https://pub.dev"
4242
source: hosted
43-
version: "8.1.0"
43+
version: "8.1.1"
4444
bloc_test:
4545
dependency: "direct dev"
4646
description:

examples/flutter_todos/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ environment:
77
sdk: ">=2.19.0 <3.0.0"
88

99
dependencies:
10-
bloc: ^8.1.0
10+
bloc: ^8.1.1
1111
equatable: ^2.0.5
1212
flutter:
1313
sdk: flutter

examples/flutter_weather/lib/main.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import 'package:weather_repository/weather_repository.dart';
88

99
void main() async {
1010
WidgetsFlutterBinding.ensureInitialized();
11-
Bloc.observer = WeatherBlocObserver();
11+
Bloc.observer = const WeatherBlocObserver();
1212
HydratedBloc.storage = await HydratedStorage.build(
1313
storageDirectory: kIsWeb
1414
? HydratedStorage.webStorageDirectory

examples/flutter_weather/lib/weather_bloc_observer.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ import 'dart:developer';
33
import 'package:bloc/bloc.dart';
44

55
class WeatherBlocObserver extends BlocObserver {
6+
const WeatherBlocObserver();
7+
68
@override
79
void onEvent(Bloc<dynamic, dynamic> bloc, Object? event) {
810
super.onEvent(bloc, event);

packages/bloc_test/lib/src/bloc_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ Alternatively, consider using Matchers in the expect of the blocTest rather than
249249
}
250250

251251
class _TestBlocObserver extends BlocObserver {
252-
_TestBlocObserver(this._localObserver, this._onError);
252+
const _TestBlocObserver(this._localObserver, this._onError);
253253

254254
final BlocObserver _localObserver;
255255
final void Function(Object error) _onError;

packages/flutter_bloc/example/lib/main.dart

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,17 @@ import 'package:flutter/material.dart';
22
import 'package:flutter_bloc/flutter_bloc.dart';
33

44
void main() {
5-
Bloc.observer = AppBlocObserver();
5+
Bloc.observer = const AppBlocObserver();
66
runApp(const App());
77
}
88

9+
/// {@template app_bloc_observer}
910
/// Custom [BlocObserver] that observes all bloc and cubit state changes.
11+
/// {@endtemplate}
1012
class AppBlocObserver extends BlocObserver {
13+
/// {@macro app_bloc_observer}
14+
const AppBlocObserver();
15+
1116
@override
1217
void onChange(BlocBase bloc, Change change) {
1318
super.onChange(bloc, change);

packages/replay_bloc/example/lib/main.dart

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,17 @@ import 'package:flutter_bloc/flutter_bloc.dart';
33
import 'package:replay_bloc/replay_bloc.dart';
44

55
void main() {
6-
Bloc.observer = AppBlocObserver();
6+
Bloc.observer = const AppBlocObserver();
77
runApp(const App());
88
}
99

10+
/// {@template app_bloc_observer}
1011
/// Custom [BlocObserver] that observes all bloc and cubit state changes.
12+
/// {@endtemplate}
1113
class AppBlocObserver extends BlocObserver {
14+
/// {@macro app_bloc_observer}
15+
const AppBlocObserver();
16+
1217
@override
1318
void onChange(BlocBase bloc, Change change) {
1419
super.onChange(bloc, change);

0 commit comments

Comments
 (0)