-
Notifications
You must be signed in to change notification settings - Fork 87
Open
Labels
enhancementIdea or request for a new featureIdea or request for a new featuregood first issueGood for newcomers (doesn’t require deep knowledge of the project)Good for newcomers (doesn’t require deep knowledge of the project)
Description
Description of the desired feature:
In case the GRD file that is intended to be read is corrupted and there are missing elements in the grid, our hm.load_oasis_montaj_grid function will fail, raising an error complaining about not being able to reshape the grid to the expected shape.
We could improve the user interface by checking if the number of elements in the read 1d array matches the expected shape and raise an error with an informative error message if it doesn't. It could be a ValueError with a message like:
f"Encountered grid with {n} elements that doesn't match the expected shape ({shape}). The '{filename}' file is possibly corrupted."The idea for this new feature was triggered after a conversation with @marcoutojr
Are you willing to help implement and maintain this feature?
Yes, sure! Although I'd love to see someone else tackling this issue.
leouieda
Metadata
Metadata
Assignees
Labels
enhancementIdea or request for a new featureIdea or request for a new featuregood first issueGood for newcomers (doesn’t require deep knowledge of the project)Good for newcomers (doesn’t require deep knowledge of the project)