BREAKING CHANGE: upgrade to fastify v5 (#30)

Author: ilteoood

.github/workflows/ci.yml

@@ -36,10 +36,10 @@ jobs:
       contents: read
     strategy:
       matrix:
-        node-version: [14, 16, 18, 20]
+        node-version: [20, 22]
     services:
       opensearch:
-        image: opensearchproject/opensearch:2.13.0
+        image: opensearchproject/opensearch:2.19.0
         ports:
           - 9200:9200
         options: >-

.taprc

@@ -0,0 +1,8 @@
+services:
+  opensearch:
+    image: opensearchproject/opensearch:2.19.0
+    ports:
+      - 9200:9200
+    environment:
+      - discovery.type=single-node
+      - DISABLE_SECURITY_PLUGIN=true

docker-compose.yml

@@ -40,7 +40,7 @@ async function fastifyOpensearch (fastify, options) {
 }
 
 module.exports = fp(fastifyOpensearch, {
-  fastify: '4.x',
+  fastify: '5.x',
   name: '@fastify/opensearch'
 })
 module.exports.default = fastifyOpensearch

index.js

@@ -8,8 +8,10 @@
   "scripts": {
     "lint": "eslint",
     "lint:fix": "eslint --fix",
+    "infra:up": "docker-compose up -d",
+    "infra:down": "docker-compose down",
     "test": "npm run test:unit && npm run test:typescript",
-    "test:unit": "tap",
+    "test:unit": "c8 --100 node --test",
     "test:typescript": "tsd"
   },
   "repository": {
@@ -41,16 +43,16 @@
     }
   ],
   "dependencies": {
-    "@opensearch-project/opensearch": "^2.5.0",
-    "fastify-plugin": "^4.0.0"
+    "@opensearch-project/opensearch": "^3.3.0",
+    "fastify-plugin": "^5.0.1"
   },
   "devDependencies": {
     "@fastify/pre-commit": "^2.0.2",
     "@types/node": "^22.0.0",
+    "c8": "^10.1.3",
     "eslint": "^9.17.0",
-    "fastify": "^4.0.0-rc.2",
+    "fastify": "^5.2.1",
     "neostandard": "^0.12.0",
-    "tap": "^16.0.0",
     "tsd": "^0.31.0"
   },
   "publishConfig": {

package.json

@@ -1,67 +1,58 @@
 'use strict'
 
-const { test } = require('tap')
+const { test } = require('node:test')
 const { Client } = require('@opensearch-project/opensearch')
 const Fastify = require('fastify')
 const fastifyOpensearch = require('..')
 const isOpensearchClient = require('..').isOpensearchClient
 
 test('with reachable cluster', async t => {
   const fastify = Fastify()
-  t.teardown(() => fastify.close())
+  t.after(() => fastify.close())
   fastify.register(fastifyOpensearch, { node: 'http://localhost:9200' })
 
   await fastify.ready()
-  t.equal(fastify.opensearch.name, 'opensearch-js')
+  t.assert.deepStrictEqual(fastify.opensearch.name, 'opensearch-js')
 })
 
-test('with unreachable cluster', async t => {
+test('with unreachable cluster', t => {
   const fastify = Fastify()
-  t.teardown(() => fastify.close())
+  t.after(() => fastify.close())
   fastify.register(fastifyOpensearch, { node: 'http://localhost:9201' })
 
-  try {
-    await fastify.ready()
-    t.fail('should not boot successfully')
-  } catch (err) {
-    t.ok(err)
-  }
+  return t.assert.rejects(fastify.ready())
 })
 
 test('with unreachable cluster and healthcheck disabled', async t => {
   const fastify = Fastify()
-  t.teardown(() => fastify.close())
+  t.after(() => fastify.close())
   fastify.register(fastifyOpensearch, {
     node: 'http://localhost:9201',
     healthcheck: false
   })
 
-  try {
-    await fastify.ready()
-    t.equal(fastify.opensearch.name, 'opensearch-js')
-  } catch {
-    t.fail('should not error')
-  }
+  await fastify.ready()
+  t.assert.deepStrictEqual(fastify.opensearch.name, 'opensearch-js')
 })
 
 test('namespaced', async t => {
   const fastify = Fastify()
-  t.teardown(() => fastify.close())
+  t.after(() => fastify.close())
   fastify.register(fastifyOpensearch, {
     node: 'http://localhost:9200',
     namespace: 'cluster'
   })
 
   await fastify.ready()
-  t.strictEqual(fastify.opensearch.cluster.name, 'opensearch-js')
-  t.equal(isOpensearchClient(fastify.opensearch), false)
-  t.equal(isOpensearchClient(fastify.opensearch.cluster), true)
+  t.assert.deepStrictEqual(fastify.opensearch.cluster.name, 'opensearch-js')
+  t.assert.deepStrictEqual(isOpensearchClient(fastify.opensearch), false)
+  t.assert.deepStrictEqual(isOpensearchClient(fastify.opensearch.cluster), true)
   await fastify.close()
 })
 
 test('namespaced (errored)', async t => {
   const fastify = Fastify()
-  t.teardown(() => fastify.close())
+  t.after(() => fastify.close())
   fastify.register(fastifyOpensearch, {
     node: 'http://localhost:9200',
     namespace: 'cluster'
@@ -72,12 +63,7 @@ test('namespaced (errored)', async t => {
     namespace: 'cluster'
   })
 
-  try {
-    await fastify.ready()
-    t.fail('should not boot successfully')
-  } catch (err) {
-    t.ok(err)
-  }
+  await t.assert.rejects(fastify.ready())
 })
 
 test('custom client', async t => {
@@ -87,24 +73,19 @@ test('custom client', async t => {
   })
 
   const fastify = Fastify()
-  t.teardown(() => fastify.close())
+  t.after(() => fastify.close())
   fastify.register(fastifyOpensearch, { client })
 
   await fastify.ready()
-  t.equal(isOpensearchClient(fastify.opensearch), true)
-  t.strictEqual(fastify.opensearch.name, 'custom')
+  t.assert.deepStrictEqual(isOpensearchClient(fastify.opensearch), true)
+  t.assert.deepStrictEqual(fastify.opensearch.name, 'custom')
   await fastify.close()
 })
 
-test('Missing configuration', async t => {
+test('Missing configuration', t => {
   const fastify = Fastify()
-  t.teardown(() => fastify.close())
+  t.after(() => fastify.close())
   fastify.register(fastifyOpensearch)
 
-  try {
-    await fastify.ready()
-    t.fail('should not boot successfully')
-  } catch (err) {
-    t.ok(err)
-  }
+  return t.assert.rejects(fastify.ready())
 })