Parsing error on pages with modified `Array` prototypes

[anulman]

A script we distribute uses ua-parser-js, and [this line] throws errors for a site that assigns Array.prototype.isEmpty, since the for...in loop also checks isEmpty (vs. a for...of or for (var i=0; i < foo.length; i++) { ... }).

It looks like the latter syntax is preferred in this project. I'm going to open a patch with it

[anulman]

For project files:

diff --git a/src/main/ua-parser.js b/src/main/ua-parser.js
index a6f1091..0afe197 100755
--- a/src/main/ua-parser.js
+++ b/src/main/ua-parser.js
@@ -1219,7 +1219,7 @@
                 case UA_ENGINE:
                     var brands = uaCH[FULLVERLIST] || uaCH[BRANDS], prevName;
                     if (brands) {
-                        for (var i in brands) {
+                        for (var i=0; i<brands.length; i++) {
                             var brandName = brands[i].brand || brands[i],
                                 brandVersion = brands[i].version;
                             if (this.itemType == UA_BROWSER && !/not.a.brand/i.test(brandName) && (!prevName || (/chrom/i.test(prevName) && brandName != CHROMIUM))) {
diff --git a/src/main/ua-parser.mjs b/src/main/ua-parser.mjs
index 00eb9bb..7ccd899 100644
--- a/src/main/ua-parser.mjs
+++ b/src/main/ua-parser.mjs
@@ -1221,7 +1221,7 @@
                 case UA_ENGINE:
                     var brands = uaCH[FULLVERLIST] || uaCH[BRANDS], prevName;
                     if (brands) {
-                        for (var i in brands) {
+                        for (var i=0; i<brands.length; i++) {
                             var brandName = brands[i].brand || brands[i],
                                 brandVersion = brands[i].version;
                             if (this.itemType == UA_BROWSER && !/not.a.brand/i.test(brandName) && (!prevName || (/chrom/i.test(prevName) && brandName != CHROMIUM))) {

Or as a patch-package patch:

diff --git a/node_modules/ua-parser-js/src/main/ua-parser.js b/node_modules/ua-parser-js/src/main/ua-parser.js
index a6f1091..0afe197 100755
--- a/node_modules/ua-parser-js/src/main/ua-parser.js
+++ b/node_modules/ua-parser-js/src/main/ua-parser.js
@@ -1219,7 +1219,7 @@
                 case UA_ENGINE:
                     var brands = uaCH[FULLVERLIST] || uaCH[BRANDS], prevName;
                     if (brands) {
-                        for (var i in brands) {
+                        for (var i=0; i<brands.length; i++) {
                             var brandName = brands[i].brand || brands[i],
                                 brandVersion = brands[i].version;
                             if (this.itemType == UA_BROWSER && !/not.a.brand/i.test(brandName) && (!prevName || (/chrom/i.test(prevName) && brandName != CHROMIUM))) {
diff --git a/node_modules/ua-parser-js/src/main/ua-parser.mjs b/node_modules/ua-parser-js/src/main/ua-parser.mjs
index 00eb9bb..7ccd899 100644
--- a/node_modules/ua-parser-js/src/main/ua-parser.mjs
+++ b/node_modules/ua-parser-js/src/main/ua-parser.mjs
@@ -1221,7 +1221,7 @@
                 case UA_ENGINE:
                     var brands = uaCH[FULLVERLIST] || uaCH[BRANDS], prevName;
                     if (brands) {
-                        for (var i in brands) {
+                        for (var i=0; i<brands.length; i++) {
                             var brandName = brands[i].brand || brands[i],
                                 brandVersion = brands[i].version;
                             if (this.itemType == UA_BROWSER && !/not.a.brand/i.test(brandName) && (!prevName || (/chrom/i.test(prevName) && brandName != CHROMIUM))) {