Skip to content

Taha's got issues #35

@Taha-Hassan-Git

Description

@Taha-Hassan-Git

Love the Atoll joke.

Design is super cool, you've hit all the acceptance criteria from what I can see.
I love the animate on scroll banner component. Very nice touch.
The price filtering is also really slick.
I can see you've used the context API, which is cool.
Local storage is working and persisting data!

Some small issues, mostly to do with the UI.

  • When there are two rows of islands on the home page, scrolling to the bottom of the page causes the screen to shake and scroll back up
  • Islands look very small on mobile
  • More of a question- does the Banner event listener need to be in a useEffect?

V minor, but I enjoy doing these:
Shouldn't this...

  const allRegions = [...new Set(getAllRegions().map(region => region.region))];

  const allPrices = [...new Set(getAllPrices().map(price => price.price))];

...be this?

  const allRegions = [...new Set(getAllRegions().map(island => island.region))];

  const allPrices = [...new Set(getAllPrices().map(island => island.price))];

🤷🏽

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions