-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Love the Atoll joke.
Design is super cool, you've hit all the acceptance criteria from what I can see.
I love the animate on scroll banner component. Very nice touch.
The price filtering is also really slick.
I can see you've used the context API, which is cool.
Local storage is working and persisting data!
Some small issues, mostly to do with the UI.
- When there are two rows of islands on the home page, scrolling to the bottom of the page causes the screen to shake and scroll back up
- Islands look very small on mobile
- More of a question- does the Banner event listener need to be in a useEffect?
V minor, but I enjoy doing these:
Shouldn't this...
const allRegions = [...new Set(getAllRegions().map(region => region.region))];
const allPrices = [...new Set(getAllPrices().map(price => price.price))];...be this?
const allRegions = [...new Set(getAllRegions().map(island => island.region))];
const allPrices = [...new Set(getAllPrices().map(island => island.price))];🤷🏽
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels